Completed
Push — master ( 44b189...90e00a )
by Jacob
05:11
created
module/form/CommentSubmitModule.class.inc.php 1 patch
Braces   +48 added lines, -32 removed lines patch added patch discarded remove patch
@@ -26,16 +26,20 @@  discard block
 block discarded – undo
26 26
 
27 27
 	public function activate()
28 28
 	{
29
-		if(!Request::hasPost())
30
-			return false;
31
-		if(!Request::getPost('submit') == 'Submit Comment')
32
-			return false;
29
+		if(!Request::hasPost()) {
30
+					return false;
31
+		}
32
+		if(!Request::getPost('submit') == 'Submit Comment') {
33
+					return false;
34
+		}
33 35
 		
34 36
 		$errors = $this->fetch_errors();
35
-		if(count($errors) > 0)
36
-			return $errors;
37
-		if(Request::getPost('catch') !== '')
38
-			return false;
37
+		if(count($errors) > 0) {
38
+					return $errors;
39
+		}
40
+		if(Request::getPost('catch') !== '') {
41
+					return false;
42
+		}
39 43
 		
40 44
 		$page_id = $this->save_comment_page();
41 45
 		$commenter_id = $this->save_commenter();
@@ -50,18 +54,24 @@  discard block
 block discarded – undo
50 54
 	private function fetch_errors()
51 55
 	{
52 56
 		$errors = array();
53
-		if(!Validate::checkRequest('post', 'name', 'name'))
54
-			$errors['name'] = 'You must include a valid name';
55
-		if(!Validate::checkRequest('post', 'email', 'email'))
56
-			$errors['email'] = 'You must include a valid email';
57
-		if(Request::getPost('website') && !Validate::checkRequest('post', 'website', 'url'))
58
-			$errors['website'] = 'Please enter a valid website';
59
-		if(!Validate::checkRequest('post', 'comment', 'string'))
60
-			$errors['comment'] = 'You must enter a comment';
61
-		if(Request::getPost('notify') && Request::getPost('notify') != 'check')
62
-			$errors['notify'] = 'You entered an invalid notify request';
63
-		if(Request::getPost('reply') && !Validate::checkRequest('post', 'reply', 'integer'))
64
-			$errors['reply'] = 'You entered an invalid reply request';
57
+		if(!Validate::checkRequest('post', 'name', 'name')) {
58
+					$errors['name'] = 'You must include a valid name';
59
+		}
60
+		if(!Validate::checkRequest('post', 'email', 'email')) {
61
+					$errors['email'] = 'You must include a valid email';
62
+		}
63
+		if(Request::getPost('website') && !Validate::checkRequest('post', 'website', 'url')) {
64
+					$errors['website'] = 'Please enter a valid website';
65
+		}
66
+		if(!Validate::checkRequest('post', 'comment', 'string')) {
67
+					$errors['comment'] = 'You must enter a comment';
68
+		}
69
+		if(Request::getPost('notify') && Request::getPost('notify') != 'check') {
70
+					$errors['notify'] = 'You entered an invalid notify request';
71
+		}
72
+		if(Request::getPost('reply') && !Validate::checkRequest('post', 'reply', 'integer')) {
73
+					$errors['reply'] = 'You entered an invalid reply request';
74
+		}
65 75
 		
66 76
 		return $errors;
67 77
 	}
@@ -69,8 +79,9 @@  discard block
 block discarded – undo
69 79
 	private function save_comment_page()
70 80
 	{
71 81
 		$page_result = CommentCollector::getCommentPageByURL($this->path, $this->site);
72
-		if($page_result !== null)
73
-			return $page_result->id;
82
+		if($page_result !== null) {
83
+					return $page_result->id;
84
+		}
74 85
 		
75 86
 		$query = "INSERT INTO `jpemeric_comment`.`comment_page` (`site`, `path`) VALUES ('%d', '%s')";
76 87
 		$query = sprintf($query, $this->site, $this->path);
@@ -85,8 +96,9 @@  discard block
 block discarded – undo
85 96
 			'name' => Request::getPost('name'),
86 97
 			'email' => Request::getPost('email'));
87 98
 		
88
-		if(Request::getPost('website') != '')
89
-			$cookie_value['website'] = Request::getPost('website');
99
+		if(Request::getPost('website') != '') {
100
+					$cookie_value['website'] = Request::getPost('website');
101
+		}
90 102
 		
91 103
 		$cookie_value = json_encode($cookie_value);
92 104
 		
@@ -95,8 +107,9 @@  discard block
 block discarded – undo
95 107
 			->save();
96 108
 		
97 109
 		$commenter_result = CommentCollector::getCommenterByFields(Request::getPost('name'), Request::getPost('email'), Request::getPost('website'));
98
-		if($commenter_result !== null)
99
-			return $commenter_result->id;
110
+		if($commenter_result !== null) {
111
+					return $commenter_result->id;
112
+		}
100 113
 		
101 114
 		$query = "INSERT INTO `jpemeric_comment`.`commenter` (`name`,`email`,`url`) VALUES ('%s','%s','%s')";
102 115
 		
@@ -112,8 +125,9 @@  discard block
 block discarded – undo
112 125
 	private function save_comment()
113 126
 	{
114 127
 		$comment_result = CommentCollector::getCommentByBody(Request::getPost('comment'));
115
-		if($comment_result !== null)
116
-			return $comment_result->id;
128
+		if($comment_result !== null) {
129
+					return $comment_result->id;
130
+		}
117 131
 		
118 132
 		$query = "INSERT INTO `jpemeric_comment`.`comment` (`body`, `body_format`) VALUES ('%s', '%s')";
119 133
 		
@@ -133,8 +147,9 @@  discard block
 block discarded – undo
133 147
 		$query = "INSERT INTO `jpemeric_comment`.`comment_meta` (`commenter`,`comment`,`reply`,`notify`,`comment_page`,`date`,`display`) VALUES ('%d','%d','%d','%d','%d','%s','%d')";
134 148
 		
135 149
 		$reply = Database::escape(Request::getPost('type'));
136
-		if($reply == 'new')
137
-			$reply = 0;
150
+		if($reply == 'new') {
151
+					$reply = 0;
152
+		}
138 153
 		// else check to make sure value is legit
139 154
 		
140 155
 		$notify = (Request::getPost('notify') == 'check') ? 1 : 0;
@@ -163,8 +178,9 @@  discard block
 block discarded – undo
163 178
 			
164 179
 			foreach($notification_result as $notification_row)
165 180
 			{
166
-				if($notification_row->email == Request::getPost('email'))
167
-					continue;
181
+				if($notification_row->email == Request::getPost('email')) {
182
+									continue;
183
+				}
168 184
 				
169 185
 				$email_recipient_array[$notification_row->email] = array(
170 186
 					'email' => $notification_row->email,
Please login to merge, or discard this patch.
utility/Environment.class.inc.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -9,8 +9,9 @@
 block discarded – undo
9 9
 
10 10
 	public function __construct($user_agent = null)
11 11
 	{
12
-		if(!isset($user_agent))
13
-			$user_agent = Request::getServer('HTTP_USER_AGENT');
12
+		if(!isset($user_agent)) {
13
+					$user_agent = Request::getServer('HTTP_USER_AGENT');
14
+		}
14 15
 		$this->user_agent = $user_agent;
15 16
 	}
16 17
 
Please login to merge, or discard this patch.
utility/Database.class.inc.php 1 patch
Braces   +12 added lines, -8 removed lines patch added patch discarded remove patch
@@ -36,8 +36,9 @@  discard block
 block discarded – undo
36 36
 		$mysqli = new mysqli($host, $username, $password);
37 37
 		
38 38
 		$has_connection_error = $mysqli->connect_error;
39
-		if(isset($has_connection_error))
40
-			$this->has_connection_error = true;
39
+		if(isset($has_connection_error)) {
40
+					$this->has_connection_error = true;
41
+		}
41 42
 		
42 43
 		return $mysqli;
43 44
 	}
@@ -67,8 +68,9 @@  discard block
 block discarded – undo
67 68
 		{
68 69
 			self::instance()->log_query($query, $start);
69 70
 			$array = array();
70
-			while($row = $result->fetch_object())
71
-				$array[] = $row;
71
+			while($row = $result->fetch_object()) {
72
+							$array[] = $row;
73
+			}
72 74
 			$result->close();
73 75
 			return $array;
74 76
 		}
@@ -79,8 +81,9 @@  discard block
 block discarded – undo
79 81
 	public static function selectRow($query)
80 82
 	{
81 83
 		$result = self::select($query);
82
-		if(is_array($result))
83
-			return array_pop($result);
84
+		if(is_array($result)) {
85
+					return array_pop($result);
86
+		}
84 87
 		return false;
85 88
 	}
86 89
 
@@ -99,8 +102,9 @@  discard block
 block discarded – undo
99 102
 	public static function lastInsertID()
100 103
 	{
101 104
 		$id = self::instance()->write_connection->insert_id;
102
-		if($id == 0)
103
-			return false;
105
+		if($id == 0) {
106
+					return false;
107
+		}
104 108
 		return $id;
105 109
 	}
106 110
 
Please login to merge, or discard this patch.
utility/Loader.class.inc.php 1 patch
Braces   +17 added lines, -12 removed lines patch added patch discarded remove patch
@@ -17,8 +17,9 @@  discard block
 block discarded – undo
17 17
 
18 18
 	public static function instance()
19 19
 	{
20
-		if(!isset(self::$instance))
21
-			self::$instance = new Loader();
20
+		if(!isset(self::$instance)) {
21
+					self::$instance = new Loader();
22
+		}
22 23
 		return self::$instance;
23 24
 	}
24 25
 
@@ -71,8 +72,9 @@  discard block
 block discarded – undo
71 72
 
72 73
 	public static function getImagePath($type, $file)
73 74
 	{
74
-		if($type == 'photo')
75
-			$type = 'photo/processed';
75
+		if($type == 'photo') {
76
+					$type = 'photo/processed';
77
+		}
76 78
 		
77 79
 		$path = self::instance()->get_root();
78 80
 		$path .= 'images';
@@ -110,11 +112,13 @@  discard block
 block discarded – undo
110 112
 		foreach((array) $files as $file)
111 113
 		{
112 114
 			$file_path = self::instance()->get_path($type, $file);
113
-			if(in_array($file_path, self::instance()->get_included_files()) && $type !== 'view')
114
-				continue;
115
+			if(in_array($file_path, self::instance()->get_included_files()) && $type !== 'view') {
116
+							continue;
117
+			}
115 118
 			
116
-			if(!file_exists($file_path))
117
-				Debugger::logMessage("Requested file does not exist: {$type}, {$file}");
119
+			if(!file_exists($file_path)) {
120
+							Debugger::logMessage("Requested file does not exist: {$type}, {$file}");
121
+			}
118 122
 			
119 123
 			self::instance()->add_included_file($file_path);
120 124
 			
@@ -163,10 +167,11 @@  discard block
 block discarded – undo
163 167
 		
164 168
 		$reflectionObject = self::create_reflection_class($file);
165 169
 		
166
-		if($reflectionObject->hasMethod('__construct'))
167
-			return $reflectionObject->newInstanceArgs($data);
168
-		else
169
-			return $reflectionObject->newInstance();
170
+		if($reflectionObject->hasMethod('__construct')) {
171
+					return $reflectionObject->newInstanceArgs($data);
172
+		} else {
173
+					return $reflectionObject->newInstance();
174
+		}
170 175
 	}
171 176
 
172 177
 	public static function getRoot()
Please login to merge, or discard this patch.
utility/URLDecode.class.inc.php 1 patch
Braces   +21 added lines, -14 removed lines patch added patch discarded remove patch
@@ -15,12 +15,14 @@  discard block
 block discarded – undo
15 15
 	static private function form_url_array($host, $uri)
16 16
 	{
17 17
 		$uri = substr($uri, 1);
18
-		if(strpos($uri, '?'))
19
-			$uri = substr($uri, 0, strpos($uri, '?'));
18
+		if(strpos($uri, '?')) {
19
+					$uri = substr($uri, 0, strpos($uri, '?'));
20
+		}
20 21
 		$uri_array = explode('/', $uri);
21 22
 		
22
-		if(!Loader::isLive())
23
-			$host = substr($host, strpos($host, '.') + 1);
23
+		if(!Loader::isLive()) {
24
+					$host = substr($host, strpos($host, '.') + 1);
25
+		}
24 26
 		
25 27
 		self::$array['host'] = $host;
26 28
 		
@@ -33,8 +35,9 @@  discard block
 block discarded – undo
33 35
 		self::$array['base'] = 'http://' . (!Loader::isLive() ? 'dev.' : '') . $host . '/';
34 36
 		self::$array['uri'] = '/' . implode('/', $uri_array);
35 37
 		
36
-		if(end($uri_array) == '')
37
-			$uri_array = array_slice($uri_array, 0, count($uri_array) - 1);
38
+		if(end($uri_array) == '') {
39
+					$uri_array = array_slice($uri_array, 0, count($uri_array) - 1);
40
+		}
38 41
 		self::$array['pieces'] = (array) $uri_array;
39 42
 	}
40 43
 
@@ -61,22 +64,26 @@  discard block
 block discarded – undo
61 64
 	static function getExtension()
62 65
 	{
63 66
 		$file = self::getPiece(-1);
64
-		if(substr($file, -1) == '/')
65
-			return false;
67
+		if(substr($file, -1) == '/') {
68
+					return false;
69
+		}
66 70
 		return substr($file, strrpos($file, '.') + 1);;
67 71
 	}
68 72
 
69 73
 	static function getPiece($piece = null)
70 74
 	{
71
-		if(!$piece)
72
-			return self::$array['pieces'];
75
+		if(!$piece) {
76
+					return self::$array['pieces'];
77
+		}
73 78
 		
74
-		if($piece == -1)
75
-			return end(self::$array['pieces']);
79
+		if($piece == -1) {
80
+					return end(self::$array['pieces']);
81
+		}
76 82
 		
77 83
 		$piece = $piece - 1;
78
-		if(array_key_exists($piece, self::$array['pieces']))
79
-			return self::$array['pieces'][$piece];
84
+		if(array_key_exists($piece, self::$array['pieces'])) {
85
+					return self::$array['pieces'][$piece];
86
+		}
80 87
 		return;
81 88
 	}
82 89
 
Please login to merge, or discard this patch.
utility/Cookie.class.inc.php 1 patch
Braces   +30 added lines, -21 removed lines patch added patch discarded remove patch
@@ -21,8 +21,9 @@  discard block
 block discarded – undo
21 21
 
22 22
 	public function setValue($value)
23 23
 	{
24
-		if(!$this->is_loaded)
25
-			$this->load();
24
+		if(!$this->is_loaded) {
25
+					$this->load();
26
+		}
26 27
 		
27 28
 		$this->value = $value;
28 29
 		return $this;
@@ -30,8 +31,9 @@  discard block
 block discarded – undo
30 31
 
31 32
 	public function getValue()
32 33
 	{
33
-		if(!$this->is_loaded)
34
-			$this->load();
34
+		if(!$this->is_loaded) {
35
+					$this->load();
36
+		}
35 37
 		return $this->value;
36 38
 	}
37 39
 
@@ -42,24 +44,26 @@  discard block
 block discarded – undo
42 44
 
43 45
 	public function exists()
44 46
 	{
45
-		if(!$this->is_loaded)
46
-			$this->load();
47
+		if(!$this->is_loaded) {
48
+					$this->load();
49
+		}
47 50
 		return $this->exists;
48 51
 	}
49 52
 
50 53
 	private final function load()
51 54
 	{
52 55
 		$name = $this->getName();
53
-		if(isset($_COOKIE[$name]))
54
-			$value = $_COOKIE[$name];
56
+		if(isset($_COOKIE[$name])) {
57
+					$value = $_COOKIE[$name];
58
+		}
55 59
 		
56 60
 		if(isset($value))
57 61
 		{
58 62
 			$this->value = $value;
59 63
 			$this->exists = true;
60
-		}
61
-		else
62
-			$this->exists = false;
64
+		} else {
65
+					$this->exists = false;
66
+		}
63 67
 		
64 68
 		$this->is_loaded = true;
65 69
 	}
@@ -84,24 +88,29 @@  discard block
 block discarded – undo
84 88
 	private final function check_values()
85 89
 	{
86 90
 		$name = $this->getName();
87
-		if(empty($name) || strlen($name) < 1)
88
-			return false;
91
+		if(empty($name) || strlen($name) < 1) {
92
+					return false;
93
+		}
89 94
 		
90 95
 		$value = $this->getValue();
91
-		if(!isset($value) || strlen($value) < 1)
92
-			return false;
96
+		if(!isset($value) || strlen($value) < 1) {
97
+					return false;
98
+		}
93 99
 		
94 100
 		$expiration = $this->getExpiration();
95
-		if(!isset($expiration) || !is_int($expiration))
96
-			return false;
101
+		if(!isset($expiration) || !is_int($expiration)) {
102
+					return false;
103
+		}
97 104
 		
98 105
 		$domain = $this->getDomain();
99
-		if(!isset($domain) || strlen($domain) < 1)
100
-			return false;
106
+		if(!isset($domain) || strlen($domain) < 1) {
107
+					return false;
108
+		}
101 109
 		
102 110
 		$path = $this->getPath();
103
-		if(!isset($path) || strlen($path) < 1)
104
-			return false;
111
+		if(!isset($path) || strlen($path) < 1) {
112
+					return false;
113
+		}
105 114
 		
106 115
 		return true;
107 116
 	}
Please login to merge, or discard this patch.
utility/ImageOld.class.inc.php 1 patch
Braces   +21 added lines, -17 removed lines patch added patch discarded remove patch
@@ -52,18 +52,20 @@  discard block
 block discarded – undo
52 52
 
53 53
 	public function setSize($size)
54 54
 	{
55
-		if($this->get_version() > 1)
56
-			$position = strrpos($this->file, '-v');
57
-		else
58
-			$position = strrpos($this->file, '.');
55
+		if($this->get_version() > 1) {
56
+					$position = strrpos($this->file, '-v');
57
+		} else {
58
+					$position = strrpos($this->file, '.');
59
+		}
59 60
 		
60 61
 		$this->file = substr($this->file, 0, $position) . '-s' . $size . substr($this->file, $position);
61 62
 	}
62 63
 
63 64
 	public function getDimensions()
64 65
 	{
65
-		if(!$this->isValid())
66
-			return false;
66
+		if(!$this->isValid()) {
67
+					return false;
68
+		}
67 69
 		$imageinfo = getimagesize($this->getInternalPath());
68 70
 		return array($imageinfo[0], $imageinfo[1]);
69 71
 	}
@@ -85,10 +87,11 @@  discard block
 block discarded – undo
85 87
 
86 88
 	private function get_image($image)
87 89
 	{
88
-		if(preg_match(self::$VERSION_PREG_MATCH, $image))
89
-			return preg_replace(self::$VERSION_PREG_MATCH, '', $image);
90
-		else
91
-			return $image;
90
+		if(preg_match(self::$VERSION_PREG_MATCH, $image)) {
91
+					return preg_replace(self::$VERSION_PREG_MATCH, '', $image);
92
+		} else {
93
+					return $image;
94
+		}
92 95
 	}
93 96
 
94 97
 	private function get_image_meta($image)
@@ -103,9 +106,9 @@  discard block
 block discarded – undo
103 106
 		{
104 107
 			$position = strrpos($image, '.');
105 108
 			return substr($image, 0, $position) . '-v' . $this->get_version() . substr($image, $position);
106
-		}
107
-		else
108
-			return $image;
109
+		} else {
110
+					return $image;
111
+		}
109 112
 	}
110 113
 
111 114
 	private $version;
@@ -118,10 +121,11 @@  discard block
 block discarded – undo
118 121
 			if(count($files) > 0)
119 122
 			{
120 123
 				preg_match(self::$VERSION_PREG_MATCH, $files[0], $matches);
121
-				if(count($matches))
122
-					$this->version = $matches[1];
123
-				else
124
-					$this->version = 1;
124
+				if(count($matches)) {
125
+									$this->version = $matches[1];
126
+				} else {
127
+									$this->version = 1;
128
+				}
125 129
 			}
126 130
 		}
127 131
 		return $this->version;
Please login to merge, or discard this patch.
utility/content/MarkupCodeContent.class.inc.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -10,8 +10,9 @@
 block discarded – undo
10 10
 	protected function execute($title = '')
11 11
 	{
12 12
 		preg_match_all(self::$MARKUP_DELIMITER, $this->content, $matches);
13
-		if(count($matches[1]) == 0)
14
-			return;
13
+		if(count($matches[1]) == 0) {
14
+					return;
15
+		}
15 16
 		
16 17
 		foreach($matches[3] as $key => $match)
17 18
 		{
Please login to merge, or discard this patch.
utility/content/FixInternalLinkContent.class.inc.php 1 patch
Braces   +17 added lines, -12 removed lines patch added patch discarded remove patch
@@ -14,10 +14,11 @@  discard block
 block discarded – undo
14 14
 		preg_match_all(self::$LINK_PLACEHOLDER_MATCH, $this->content, $matches);
15 15
 		foreach($matches[1] as $key => $match)
16 16
 		{
17
-			if(isset($matches[3][$key]))
18
-				$link_content = $this->get_link($match, $is_absolute, $matches[3][$key]);
19
-			else
20
-				$link_content = $this->get_link($match, $is_absolute);
17
+			if(isset($matches[3][$key])) {
18
+							$link_content = $this->get_link($match, $is_absolute, $matches[3][$key]);
19
+			} else {
20
+							$link_content = $this->get_link($match, $is_absolute);
21
+			}
21 22
 			$this->content = str_replace($matches[0][$key], $link_content, $this->content);
22 23
 		}
23 24
 		return;
@@ -35,14 +36,16 @@  discard block
 block discarded – undo
35 36
 				Loader::load('collector', 'blog/PostCollector');
36 37
 				$post = PostCollector::getPostByURI($uri);
37 38
 				
38
-				if($post === NULL)
39
-					return;
39
+				if($post === NULL) {
40
+									return;
41
+				}
40 42
 				
41 43
 				$link .= ($is_absolute) ? Loader::getRootURL('blog') : '/';
42 44
 				$link .= "{$post->category}/{$post->path}/";
43 45
 				
44
-				if($anchor == '')
45
-					$anchor = $post->title;
46
+				if($anchor == '') {
47
+									$anchor = $post->title;
48
+				}
46 49
 				
47 50
 				break;
48 51
 			case 'blog-tag' :
@@ -61,14 +64,16 @@  discard block
 block discarded – undo
61 64
 				Loader::load('collector', 'waterfall/LogCollector');
62 65
 				$log = LogCollector::getByAlias($uri);
63 66
 				
64
-				if($log === NULL)
65
-					return;
67
+				if($log === NULL) {
68
+									return;
69
+				}
66 70
 				
67 71
 				$link .= ($is_absolute) ? Loader::getRootURL('waterfalls') : '/';
68 72
 				$link .= "journal/{$log->alias}/";
69 73
 				
70
-				if($anchor == '')
71
-					$anchor = $log->title;
74
+				if($anchor == '') {
75
+									$anchor = $log->title;
76
+				}
72 77
 				
73 78
 				break;
74 79
 			case 'falls' :
Please login to merge, or discard this patch.