MysqlIntroductionRepository::__construct() - Code Metrics - Inspection of "Adds more levels to the domain namespacing" - jacobemerick/web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 34318d...75f992 )

by Jacob

created 2015-12-02 02:24 UTC

MysqlIntroductionRepository::__construct() A

↳ Parent: MysqlIntroductionRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

namespace Jacobemerick\Web\Domain\Blog\Introduction;

use Aura\Sql\ConnectionLocator;

class MysqlIntroductionRepository implements IntroductionRepositoryInterface
{

    /** @var  Aura\Sql\ConnectionLocator */
    protected $connections;

    /**
     * @param Aura\Sql\ConnectionLocator
     */
    public function __construct(ConnectionLocator $connections)
    {
        $this->connections = $connections;

    }

    /**
     * @param string $type
     * @param string $value
     *
     * @return array|false
     */
    public function findByType($type, $value = '')

    {
        $query = "
            SELECT `title`, `content`, `image`
            FROM `jpemeric_blog`.`introduction`
            WHERE `type` = :type AND `value` = :value
            LIMIT 1";
        $bindings = [
            'type'  => $type,
            'value' => $value,
        ];

        return $this
            ->connections
            ->getRead()
            ->fetchOne($query, $bindings);
    }
}


1		<?php
2
3		namespace Jacobemerick\Web\Domain\Blog\Introduction;
4
5		use Aura\Sql\ConnectionLocator;
6
7		class MysqlIntroductionRepository implements IntroductionRepositoryInterface
8		{
9
10		/** @var Aura\Sql\ConnectionLocator */
11		protected $connections;
12
13		/**
14		* @param Aura\Sql\ConnectionLocator
15		*/
16		public function __construct(ConnectionLocator $connections)
17		{
18		$this->connections = $connections;
		0 ignored issues – show Documentation Bug introduced 2015-12-02 02:27 UTC by Report Bug Copy Issue Report It seems like `$connections` of type `object<Aura\Sql\ConnectionLocator>` is incompatible with the declared type `object<Jacobemerick\Web\...\Sql\ConnectionLocator>` of property `$connections`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
19		}
20
21		/**
22		* @param string $type
23		* @param string $value
24		*
25		* @return array\|false
26		*/
27	View Code Duplication	public function findByType($type, $value = '')
		0 ignored issues – show Duplication introduced 2015-12-02 02:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		{
29		$query = "
30		SELECT `title`, `content`, `image`
31		FROM `jpemeric_blog`.`introduction`
32		WHERE `type` = :type AND `value` = :value
33		LIMIT 1";
34		$bindings = [
35		'type' => $type,
36		'value' => $value,
37		];
38
39		return $this
40		->connections
41		->getRead()
42		->fetchOne($query, $bindings);
43		}
44		}
45

jacobemerick / web

Push — master ( 34318d...75f992 )

MysqlIntroductionRepository::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like