Router - Code Metrics - Inspection of "Removes redundant bootstrap logging" - jacobemerick/web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 209cfa...3bc018 )

by Jacob

created 2016-02-01 02:02 UTC

Router A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	135
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Metric	Value
wmc	31
lcom	1
cbo	3
dl	0
loc	135
rs	9.8

11 Methods

Rating	Name	Size	Complexity
A	__construct()	1	1
A	instance()	6	1
D	get_router_name()	32	9
A	route()	10	1
	get_redirect_array()	1	?
	get_direct_array()	1	?
D	check_for_redirect()	40	10
A	check_for_special_redirect()	4	1
A	get_controller()	13	4
A	get_primary_folder()	7	2
A	requires_trailing_slash()	6	2

<?


Loader::load('utility', array(
	'Request',
	'URLDecode'));

abstract class Router
{

	public function __construct() {}

	public static function instance()
	{
		$router_name = self::get_router_name();
		$router = Loader::loadNew('router', $router_name);
		$router->route();
	}

	private static function get_router_name()
	{
		if(Request::isAJAX())
			return 'AJAXRouter';
		
		switch(URLDecode::getSite())
		{
			case 'ajax' :
				return 'AjaxRouter';
			break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'blog' :
				return 'BlogRouter';
			break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'home' :
				return 'HomeRouter';
			break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'lifestream' :
				return 'LifestreamRouter';
			break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'portfolio' :
				return 'PortfolioRouter';
			break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'site' :
				return 'SiteRouter';
			break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case 'waterfalls' :
				return 'WaterfallRouter';
			break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
		}
		
		Loader::loadNew('controller', '/Error404Controller')->activate();
	}

	protected function route()
	{
		$uri = URLDecode::getURI();
		
		$this->check_for_redirect($uri);
		
		$controller = $this->get_controller($uri);
		Loader::loadNew('controller', $controller)
			->activate();
	}

	abstract protected function get_redirect_array();
	abstract protected function get_direct_array();

	final protected function check_for_redirect($redirect_uri)
	{
		foreach($this->get_redirect_array() as $check)
		{
			$redirect_uri = preg_replace($check->pattern, $check->replace, $redirect_uri);
		}
		
		$redirect_uri = $this->check_for_special_redirect($redirect_uri);
		
		if($this->requires_trailing_slash() && substr($redirect_uri, -1) != '/')
			$redirect_uri .= '/';
		
        if (URLDecode::getHost() == 'waterfalls.jacobemerick.com') {
            $redirect_uri = 'http://' . (!Loader::isLive() ? 'dev' : 'www') . '.waterfallsofthekeweenaw.com' . $redirect_uri;
        }
        
		if($redirect_uri == URLDecode::getURI())
			return;
		
		$controller_check = $redirect_uri;
		if(substr($redirect_uri, 0, 4) == 'http')
			$controller_check = preg_replace('@^http://([a-z\.]+)@', '', $redirect_uri);
		
		$controller = $this->get_controller($controller_check);
		if($controller == '/Error404Controller')
		{
			Loader::loadNew('controller', '/Error404Controller')
				->activate();
			exit;

		}

		if(substr($redirect_uri, 0, 4) != 'http')
		{
			$redirect_uri = substr($redirect_uri, 1);
			$redirect_uri = URLDecode::getBase() . $redirect_uri;
		}
		
		Loader::loadNew('controller', '/Error301Controller', (array) $redirect_uri)
			->activate();
	}

	protected function check_for_special_redirect($uri)
	{
		return $uri;
	}

	final private function get_controller($uri)
	{
		foreach($this->get_direct_array() as $check)
		{
			if($uri == $check->match)
				return "{$this->get_primary_folder()}/{$check->controller}";
			
			if(preg_match("@^{$check->match}$@", $uri))
				return "{$this->get_primary_folder()}/{$check->controller}";
		}
		
		return '/Error404Controller';
	}

	final private function get_primary_folder()
	{
		if(Request::isAjax())
			return 'ajax';
		
		return URLDecode::getSite();
	}

	private function requires_trailing_slash()
	{
		return (
			URLDecode::getExtension() != 'json' &&
            strstr(URLDecode::getURI(), '#') === false);
	}

}


1			<?
			0 ignored issues – show Security Best Practice introduced 2015-11-28 18:19 UTC by Report Bug Copy Issue Report It is not recommend to use PHP's short opening tag `<?`, better use `<?php`, or `<?=` in case of outputting. Short opening tags are disabled in PHP’s default configuration. In such a case, all content of this file is output verbatim to the browser without being parsed, or executed. As a precaution to avoid these problems better use the long opening tag `<?php`. Loading history...
2
3			Loader::load('utility', array(
4			'Request',
5			'URLDecode'));
6
7			abstract class Router
8			{
9
10			public function __construct() {}
11
12			public static function instance()
13			{
14			$router_name = self::get_router_name();
15			$router = Loader::loadNew('router', $router_name);
16			$router->route();
17			}
18
19			private static function get_router_name()
20			{
21			if(Request::isAJAX())
22			return 'AJAXRouter';
23
24			switch(URLDecode::getSite())
25			{
26			case 'ajax' :
27			return 'AjaxRouter';
28			break;
			0 ignored issues – show Unused Code introduced 2016-01-01 18:48 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
29			case 'blog' :
30			return 'BlogRouter';
31			break;
			0 ignored issues – show Unused Code introduced 2016-01-01 18:48 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
32			case 'home' :
33			return 'HomeRouter';
34			break;
			0 ignored issues – show Unused Code introduced 2016-01-02 05:26 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
35			case 'lifestream' :
36			return 'LifestreamRouter';
37			break;
			0 ignored issues – show Unused Code introduced 2015-11-28 18:19 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
38			case 'portfolio' :
39			return 'PortfolioRouter';
40			break;
			0 ignored issues – show Unused Code introduced 2015-11-28 18:19 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
41			case 'site' :
42			return 'SiteRouter';
43			break;
			0 ignored issues – show Unused Code introduced 2015-11-28 18:19 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
44			case 'waterfalls' :
45			return 'WaterfallRouter';
46			break;
			0 ignored issues – show Unused Code introduced 2015-11-28 18:19 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
47			}
48
49			Loader::loadNew('controller', '/Error404Controller')->activate();
50			}
51
52			protected function route()
53			{
54			$uri = URLDecode::getURI();
55
56			$this->check_for_redirect($uri);
57
58			$controller = $this->get_controller($uri);
59			Loader::loadNew('controller', $controller)
60			->activate();
61			}
62
63			abstract protected function get_redirect_array();
64			abstract protected function get_direct_array();
65
66			final protected function check_for_redirect($redirect_uri)
67			{
68			foreach($this->get_redirect_array() as $check)
69			{
70			$redirect_uri = preg_replace($check->pattern, $check->replace, $redirect_uri);
71			}
72
73			$redirect_uri = $this->check_for_special_redirect($redirect_uri);
74
75			if($this->requires_trailing_slash() && substr($redirect_uri, -1) != '/')
76			$redirect_uri .= '/';
77
78			if (URLDecode::getHost() == 'waterfalls.jacobemerick.com') {
79			$redirect_uri = 'http://' . (!Loader::isLive() ? 'dev' : 'www') . '.waterfallsofthekeweenaw.com' . $redirect_uri;
80			}
81
82			if($redirect_uri == URLDecode::getURI())
83			return;
84
85			$controller_check = $redirect_uri;
86			if(substr($redirect_uri, 0, 4) == 'http')
87			$controller_check = preg_replace('@^http://([a-z\.]+)@', '', $redirect_uri);
88
89			$controller = $this->get_controller($controller_check);
90			if($controller == '/Error404Controller')
91			{
92			Loader::loadNew('controller', '/Error404Controller')
93			->activate();
94			exit;
			0 ignored issues – show Coding Style Compatibility introduced 2015-11-28 18:20 UTC by Report Bug Copy Issue Report The method `check_for_redirect()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
95			}
96
97			if(substr($redirect_uri, 0, 4) != 'http')
98			{
99			$redirect_uri = substr($redirect_uri, 1);
100			$redirect_uri = URLDecode::getBase() . $redirect_uri;
101			}
102
103			Loader::loadNew('controller', '/Error301Controller', (array) $redirect_uri)
104			->activate();
105			}
106
107			protected function check_for_special_redirect($uri)
108			{
109			return $uri;
110			}
111
112			final private function get_controller($uri)
113			{
114			foreach($this->get_direct_array() as $check)
115			{
116			if($uri == $check->match)
117			return "{$this->get_primary_folder()}/{$check->controller}";
118
119			if(preg_match("@^{$check->match}$@", $uri))
120			return "{$this->get_primary_folder()}/{$check->controller}";
121			}
122
123			return '/Error404Controller';
124			}
125
126			final private function get_primary_folder()
127			{
128			if(Request::isAjax())
129			return 'ajax';
130
131			return URLDecode::getSite();
132			}
133
134			private function requires_trailing_slash()
135			{
136			return (
137			URLDecode::getExtension() != 'json' &&
138			strstr(URLDecode::getURI(), '#') === false);
139			}
140
141			}
142

jacobemerick / web

Push — master ( 209cfa...3bc018 )

Router A

Complexity

Size/Duplication

Coupling/Cohesion

11 Methods

Duplication Side-by-Side

Filter issues like