Inspection of "Adds new stream db repositories and use them to re..." - jacobemerick/web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c330e2...cf0c7a )

by Jacob

created 2015-12-27 02:18 UTC

Status

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -4,10 +4,10 @@
 block discarded – undo
 
 interface PostRepositoryInterface
 {
-    public function getPostById($id);
-    public function getPostByFields($type, $type_id);
-    public function getPosts($limit = null, $offset = 0);
-    public function getPostsCount();
-    public function getPostsByType($type, $limit = null, $offset = 0);
-    public function getPostsByTypeCount($type);
+	public function getPostById($id);
+	public function getPostByFields($type, $type_id);
+	public function getPosts($limit = null, $offset = 0);
+	public function getPostsCount();
+	public function getPostsByType($type, $limit = null, $offset = 0);
+	public function getPostsByTypeCount($type);
 }

Please login to merge, or discard this patch.

src/Domain/Stream/Twitter/MysqlTwitterRepository.php 1 patch

Indentation +54 added lines, -54 removed lines patch added patch discarded remove patch

@@ -8,77 +8,77 @@
 block discarded – undo
 class MysqlTwitterRepository implements TwitterRepositoryInterface
 {
 
-    /** @var  ConnectionLocator */
-    protected $connections;
+	/** @var  ConnectionLocator */
+	protected $connections;
 
-    /**
-     * @param ConnectonLocator $connections
-     */
-    public function __construct(ConnectionLocator $connections)
-    {
-        $this->connections = $connections;
-    }
+	/**
+	 * @param ConnectonLocator $connections
+	 */
+	public function __construct(ConnectionLocator $connections)
+	{
+		$this->connections = $connections;
+	}
 
-    /**
-     * @param integer $id
-     *
-     * @return array|false
-     */
-    public function getTwitterById($id)
-    {
-        $query = "
+	/**
+	 * @param integer $id
+	 *
+	 * @return array|false
+	 */
+	public function getTwitterById($id)
+	{
+		$query = "
             SELECT *
             FROM `jpemeric_stream`.`twitter`
             WHERE `id` = :id
             LIMIT 1";
-        $bindings = [
-            'id' => $id,
-        ];
+		$bindings = [
+			'id' => $id,
+		];
 
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchOne($query, $bindings);
-    }
+		return $this
+			->connections
+			->getRead()
+			->fetchOne($query, $bindings);
+	}
 
-    /**
-     * @param DateTimeInterface $date
-     * @param string            $text
-     *
-     * @return array|false
-     */
-    public function getTwitterByFields(DateTimeInterface $date, $text)
-    {
-        $query = "
+	/**
+	 * @param DateTimeInterface $date
+	 * @param string            $text
+	 *
+	 * @return array|false
+	 */
+	public function getTwitterByFields(DateTimeInterface $date, $text)
+	{
+		$query = "
             SELECT *
             FROM `jpemeric_stream`.`twitter`
             WHERE `date` = :date AND `text` = :text
             LIMIT 1";
-        $bindings = [
-            'date' => $date->format('Y-m-d H:i:s'),
-            'text' => $text,
-        ];
+		$bindings = [
+			'date' => $date->format('Y-m-d H:i:s'),
+			'text' => $text,
+		];
 
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchOne($query, $bindings);
-    }
+		return $this
+			->connections
+			->getRead()
+			->fetchOne($query, $bindings);
+	}
 
-    /**
-     * @return array|false
-     */
-    public function getUnmappedTwitters()
-    {
-        $query = "
+	/**
+	 * @return array|false
+	 */
+	public function getUnmappedTwitters()
+	{
+		$query = "
             SELECT `id`, `date`
             FROM `jpemeric_stream`.`twitter`
             LEFT JOIN `jpemeric_stream`.`post`
             ON `post`.`type_id` = `twitter`.`id` AND `post`.`id` IS NULL";
 
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchAll($query);
-    }
+		return $this
+			->connections
+			->getRead()
+			->fetchAll($query);
+	}
 }

Please login to merge, or discard this patch.

src/Domain/Stream/Twitter/TwitterRepositoryInterface.php 1 patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -6,7 +6,7 @@
 block discarded – undo
 
 interface TwitterRepositoryInterface
 {
-    public function getTwitterById($id);
-    public function getTwitterByFields(DateTimeInterface $date, $text);
-    public function getUnmappedTwitters();
+	public function getTwitterById($id);
+	public function getTwitterByFields(DateTimeInterface $date, $text);
+	public function getUnmappedTwitters();
 }

Please login to merge, or discard this patch.

src/Domain/Stream/YouTube/MysqlYouTubeRepository.php 1 patch

Indentation +52 added lines, -52 removed lines patch added patch discarded remove patch

@@ -7,75 +7,75 @@
 block discarded – undo
 class MysqlYouTubeRepository implements YouTubeRepositoryInterface
 {
 
-    /** @var  ConnectionLocator */
-    protected $connections;
+	/** @var  ConnectionLocator */
+	protected $connections;
 
-    /**
-     * @param ConnectonLocator $connections
-     */
-    public function __construct(ConnectionLocator $connections)
-    {
-        $this->connections = $connections;
-    }
+	/**
+	 * @param ConnectonLocator $connections
+	 */
+	public function __construct(ConnectionLocator $connections)
+	{
+		$this->connections = $connections;
+	}
 
-    /**
-     * @param integer $id
-     *
-     * @return array|false
-     */
-    public function getYouTubeById($id)
-    {
-        $query = "
+	/**
+	 * @param integer $id
+	 *
+	 * @return array|false
+	 */
+	public function getYouTubeById($id)
+	{
+		$query = "
             SELECT *
             FROM `jpemeric_stream`.`youtube`
             WHERE `id` = :id
             LIMIT 1";
-        $bindings = [
-            'id' => $id,
-        ];
+		$bindings = [
+			'id' => $id,
+		];
 
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchOne($query, $bindings);
-    }
+		return $this
+			->connections
+			->getRead()
+			->fetchOne($query, $bindings);
+	}
 
-    /**
-     * @param string $title
-     *
-     * @return array|false
-     */
-    public function getYouTubeByVideoId($videoId)
-    {
-        $query = "
+	/**
+	 * @param string $title
+	 *
+	 * @return array|false
+	 */
+	public function getYouTubeByVideoId($videoId)
+	{
+		$query = "
             SELECT *
             FROM `jpemeric_stream`.`youtube`
             WHERE `video_id` = :video_id
             LIMIT 1";
-        $bindings = [
-            'video_id' => $videoId,
-        ];
+		$bindings = [
+			'video_id' => $videoId,
+		];
 
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchOne($query, $bindings);
-    }
+		return $this
+			->connections
+			->getRead()
+			->fetchOne($query, $bindings);
+	}
 
-    /**
-     * @return array|false
-     */
-    public function getUnmappedYouTubes()
-    {
-        $query = "
+	/**
+	 * @return array|false
+	 */
+	public function getUnmappedYouTubes()
+	{
+		$query = "
             SELECT `id`, `date`
             FROM `jpemeric_stream`.`youtube`
             LEFT JOIN `jpemeric_stream`.`post`
             ON `post`.`type_id` = `youtube`.`id` AND `post`.`id` IS NULL";
 
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchAll($query);
-    }
+		return $this
+			->connections
+			->getRead()
+			->fetchAll($query);
+	}
 }

Please login to merge, or discard this patch.

src/Domain/Stream/YouTube/YouTubeRepositoryInterface.php 1 patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -4,7 +4,7 @@
 block discarded – undo
 
 interface YouTubeRepositoryInterface
 {
-    public function getYouTubeById($id);
-    public function getYouTubeByVideoId($videoId);
-    public function getUnmappedYouTubes();
+	public function getYouTubeById($id);
+	public function getYouTubeByVideoId($videoId);
+	public function getUnmappedYouTubes();
 }

Please login to merge, or discard this patch.

		@@ -4,10 +4,10 @@
		block discarded – undo
4	4
5	5	interface PostRepositoryInterface
6	6	{
7		- public function getPostById($id);
8		- public function getPostByFields($type, $type_id);
9		- public function getPosts($limit = null, $offset = 0);
10		- public function getPostsCount();
11		- public function getPostsByType($type, $limit = null, $offset = 0);
12		- public function getPostsByTypeCount($type);
	7	+ public function getPostById($id);
	8	+ public function getPostByFields($type, $type_id);
	9	+ public function getPosts($limit = null, $offset = 0);
	10	+ public function getPostsCount();
	11	+ public function getPostsByType($type, $limit = null, $offset = 0);
	12	+ public function getPostsByTypeCount($type);
13	13	}

		@@ -8,77 +8,77 @@
		block discarded – undo
8	8	class MysqlTwitterRepository implements TwitterRepositoryInterface
9	9	{
10	10
11		- /** @var ConnectionLocator */
12		- protected $connections;
	11	+ /** @var ConnectionLocator */
	12	+ protected $connections;
13	13
14		- /**
15		- * @param ConnectonLocator $connections
16		- */
17		- public function __construct(ConnectionLocator $connections)
18		- {
19		- $this->connections = $connections;
20		- }
	14	+ /**
	15	+ * @param ConnectonLocator $connections
	16	+ */
	17	+ public function __construct(ConnectionLocator $connections)
	18	+ {
	19	+ $this->connections = $connections;
	20	+ }
21	21
22		- /**
23		- * @param integer $id
24		- *
25		- * @return array\|false
26		- */
27		- public function getTwitterById($id)
28		- {
29		- $query = "
	22	+ /**
	23	+ * @param integer $id
	24	+ *
	25	+ * @return array\|false
	26	+ */
	27	+ public function getTwitterById($id)
	28	+ {
	29	+ $query = "
30	30	SELECT *
31	31	FROM `jpemeric_stream`.`twitter`
32	32	WHERE `id` = :id
33	33	LIMIT 1";
34		- $bindings = [
35		- 'id' => $id,
36		- ];
	34	+ $bindings = [
	35	+ 'id' => $id,
	36	+ ];
37	37
38		- return $this
39		- ->connections
40		- ->getRead()
41		- ->fetchOne($query, $bindings);
42		- }
	38	+ return $this
	39	+ ->connections
	40	+ ->getRead()
	41	+ ->fetchOne($query, $bindings);
	42	+ }
43	43
44		- /**
45		- * @param DateTimeInterface $date
46		- * @param string $text
47		- *
48		- * @return array\|false
49		- */
50		- public function getTwitterByFields(DateTimeInterface $date, $text)
51		- {
52		- $query = "
	44	+ /**
	45	+ * @param DateTimeInterface $date
	46	+ * @param string $text
	47	+ *
	48	+ * @return array\|false
	49	+ */
	50	+ public function getTwitterByFields(DateTimeInterface $date, $text)
	51	+ {
	52	+ $query = "
53	53	SELECT *
54	54	FROM `jpemeric_stream`.`twitter`
55	55	WHERE `date` = :date AND `text` = :text
56	56	LIMIT 1";
57		- $bindings = [
58		- 'date' => $date->format('Y-m-d H:i:s'),
59		- 'text' => $text,
60		- ];
	57	+ $bindings = [
	58	+ 'date' => $date->format('Y-m-d H:i:s'),
	59	+ 'text' => $text,
	60	+ ];
61	61
62		- return $this
63		- ->connections
64		- ->getRead()
65		- ->fetchOne($query, $bindings);
66		- }
	62	+ return $this
	63	+ ->connections
	64	+ ->getRead()
	65	+ ->fetchOne($query, $bindings);
	66	+ }
67	67
68		- /**
69		- * @return array\|false
70		- */
71		- public function getUnmappedTwitters()
72		- {
73		- $query = "
	68	+ /**
	69	+ * @return array\|false
	70	+ */
	71	+ public function getUnmappedTwitters()
	72	+ {
	73	+ $query = "
74	74	SELECT `id`, `date`
75	75	FROM `jpemeric_stream`.`twitter`
76	76	LEFT JOIN `jpemeric_stream`.`post`
77	77	ON `post`.`type_id` = `twitter`.`id` AND `post`.`id` IS NULL";
78	78
79		- return $this
80		- ->connections
81		- ->getRead()
82		- ->fetchAll($query);
83		- }
	79	+ return $this
	80	+ ->connections
	81	+ ->getRead()
	82	+ ->fetchAll($query);
	83	+ }
84	84	}

		@@ -6,7 +6,7 @@
		block discarded – undo
6	6
7	7	interface TwitterRepositoryInterface
8	8	{
9		- public function getTwitterById($id);
10		- public function getTwitterByFields(DateTimeInterface $date, $text);
11		- public function getUnmappedTwitters();
	9	+ public function getTwitterById($id);
	10	+ public function getTwitterByFields(DateTimeInterface $date, $text);
	11	+ public function getUnmappedTwitters();
12	12	}

		@@ -7,75 +7,75 @@
		block discarded – undo
7	7	class MysqlYouTubeRepository implements YouTubeRepositoryInterface
8	8	{
9	9
10		- /** @var ConnectionLocator */
11		- protected $connections;
	10	+ /** @var ConnectionLocator */
	11	+ protected $connections;
12	12
13		- /**
14		- * @param ConnectonLocator $connections
15		- */
16		- public function __construct(ConnectionLocator $connections)
17		- {
18		- $this->connections = $connections;
19		- }
	13	+ /**
	14	+ * @param ConnectonLocator $connections
	15	+ */
	16	+ public function __construct(ConnectionLocator $connections)
	17	+ {
	18	+ $this->connections = $connections;
	19	+ }
20	20
21		- /**
22		- * @param integer $id
23		- *
24		- * @return array\|false
25		- */
26		- public function getYouTubeById($id)
27		- {
28		- $query = "
	21	+ /**
	22	+ * @param integer $id
	23	+ *
	24	+ * @return array\|false
	25	+ */
	26	+ public function getYouTubeById($id)
	27	+ {
	28	+ $query = "
29	29	SELECT *
30	30	FROM `jpemeric_stream`.`youtube`
31	31	WHERE `id` = :id
32	32	LIMIT 1";
33		- $bindings = [
34		- 'id' => $id,
35		- ];
	33	+ $bindings = [
	34	+ 'id' => $id,
	35	+ ];
36	36
37		- return $this
38		- ->connections
39		- ->getRead()
40		- ->fetchOne($query, $bindings);
41		- }
	37	+ return $this
	38	+ ->connections
	39	+ ->getRead()
	40	+ ->fetchOne($query, $bindings);
	41	+ }
42	42
43		- /**
44		- * @param string $title
45		- *
46		- * @return array\|false
47		- */
48		- public function getYouTubeByVideoId($videoId)
49		- {
50		- $query = "
	43	+ /**
	44	+ * @param string $title
	45	+ *
	46	+ * @return array\|false
	47	+ */
	48	+ public function getYouTubeByVideoId($videoId)
	49	+ {
	50	+ $query = "
51	51	SELECT *
52	52	FROM `jpemeric_stream`.`youtube`
53	53	WHERE `video_id` = :video_id
54	54	LIMIT 1";
55		- $bindings = [
56		- 'video_id' => $videoId,
57		- ];
	55	+ $bindings = [
	56	+ 'video_id' => $videoId,
	57	+ ];
58	58
59		- return $this
60		- ->connections
61		- ->getRead()
62		- ->fetchOne($query, $bindings);
63		- }
	59	+ return $this
	60	+ ->connections
	61	+ ->getRead()
	62	+ ->fetchOne($query, $bindings);
	63	+ }
64	64
65		- /**
66		- * @return array\|false
67		- */
68		- public function getUnmappedYouTubes()
69		- {
70		- $query = "
	65	+ /**
	66	+ * @return array\|false
	67	+ */
	68	+ public function getUnmappedYouTubes()
	69	+ {
	70	+ $query = "
71	71	SELECT `id`, `date`
72	72	FROM `jpemeric_stream`.`youtube`
73	73	LEFT JOIN `jpemeric_stream`.`post`
74	74	ON `post`.`type_id` = `youtube`.`id` AND `post`.`id` IS NULL";
75	75
76		- return $this
77		- ->connections
78		- ->getRead()
79		- ->fetchAll($query);
80		- }
	76	+ return $this
	77	+ ->connections
	78	+ ->getRead()
	79	+ ->fetchAll($query);
	80	+ }
81	81	}

		@@ -4,7 +4,7 @@
		block discarded – undo
4	4
5	5	interface YouTubeRepositoryInterface
6	6	{
7		- public function getYouTubeById($id);
8		- public function getYouTubeByVideoId($videoId);
9		- public function getUnmappedYouTubes();
	7	+ public function getYouTubeById($id);
	8	+ public function getYouTubeByVideoId($videoId);
	9	+ public function getUnmappedYouTubes();
10	10	}

jacobemerick / web

Push — master ( c330e2...cf0c7a )

Status

Category

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +54 added lines, -54 removed lines patch added patch discarded remove patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +52 added lines, -52 removed lines patch added patch discarded remove patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch