Particletree\Pqp\MySqlDatabase

Complexity

Total Complexity

18

Size/Duplication

Total Lines	98
Duplicated Lines	15.31 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	1	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	connect()	0	6	2
A	changeDatabase()	0	8	3
A	lazyLoadConnection()	0	4	2
A	query()	0	11	3
A	logQuery()	0	7	1
A	getTime()	0	7	1
A	getReadableTime()	15	15	4
A	__destruct()	0	3	1

<?php

/* - - - - - - - - - - - - - - - - - - - - -

 Title : PHP Quick Profiler MySQL Class
 Author : Created by Ryan Campbell
 URL : http://particletree.com/features/php-quick-profiler/

 Last Updated : April 22, 2009

 Description : A simple database wrapper that includes
 logging of queries.

- - - - - - - - - - - - - - - - - - - - - */

namespace Particletree\Pqp;

class MySqlDatabase {

	private $host;			
	private $user;		
	private $password;	
	private $database;	
	public $queryCount = 0;
	public $queries = array();
	public $conn;
	
	/*------------------------------------
	          CONFIG CONNECTION
	------------------------------------*/
	
	function __construct($host, $user, $password) {

It is generally recommended to explicitly declare the visibility for methods.

		$this->host = $host;
		$this->user = $user;
		$this->password = $password;
	}
	
	function connect($new = false) {

It is generally recommended to explicitly declare the visibility for methods.

		$this->conn = mysql_connect($this->host, $this->user, $this->password, $new);
		if(!$this->conn) {
			throw new Exception('We\'re working on a few connection issues.');
		}
	}
	
	function changeDatabase($database) {

It is generally recommended to explicitly declare the visibility for methods.

		$this->database = $database;
		if($this->conn) {
			if(!mysql_select_db($database, $this->conn)) {
				throw new CustomException('We\'re working on a few connection issues.');
			}
		}
	}
	
	function lazyLoadConnection() {

It is generally recommended to explicitly declare the visibility for methods.

		$this->connect(true);
		if($this->database) $this->changeDatabase($this->database);
	}
	
	/*-----------------------------------
	   				QUERY
	------------------------------------*/
	
	function query($sql) {

It is generally recommended to explicitly declare the visibility for methods.

		if(!$this->conn) $this->lazyLoadConnection();
		$start = $this->getTime();
		$rs = mysql_query($sql, $this->conn);
		$this->queryCount += 1;
		$this->logQuery($sql, $start);
		if(!$rs) {
			throw new Exception('Could not execute query.');
		}
		return $rs;
	}
	
	/*-----------------------------------
	          	DEBUGGING
	------------------------------------*/
	
	function logQuery($sql, $start) {

It is generally recommended to explicitly declare the visibility for methods.

		$query = array(
				'sql' => $sql,
				'time' => ($this->getTime() - $start)*1000
			);
		array_push($this->queries, $query);
	}
	
	function getTime() {

It is generally recommended to explicitly declare the visibility for methods.

		$time = microtime();
		$time = explode(' ', $time);
		$time = $time[1] + $time[0];
		$start = $time;
		return $start;
	}
	
	public function getReadableTime($time) {

This method seems to be duplicated in your project.

		$ret = $time;
		$formatter = 0;
		$formats = array('ms', 's', 'm');
		if($time >= 1000 && $time < 60000) {
			$formatter = 1;
			$ret = ($time / 1000);
		}
		if($time >= 60000) {
			$formatter = 2;
			$ret = ($time / 1000) / 60;
		}
		$ret = number_format($ret,3,'.','') . ' ' . $formats[$formatter];
		return $ret;
	}
	
	function __destruct()  {

It is generally recommended to explicitly declare the visibility for methods.

		@mysql_close($this->conn);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

	}
	
}

?>

It is not recommended to use PHP's closing tag ?> in files other than templates.