jacobemerick /
archangel
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Archangel often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Archangel, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 13 | class Archangel |
||
| 14 | { |
||
| 15 | |||
| 16 | /** @var string $subject */ |
||
| 17 | protected $subject; |
||
| 18 | |||
| 19 | /** @var array $to */ |
||
| 20 | protected $to = array(); |
||
| 21 | |||
| 22 | /** @var array $cc */ |
||
| 23 | protected $cc = array(); |
||
| 24 | |||
| 25 | /** @var array $bcc */ |
||
| 26 | protected $bcc = array(); |
||
| 27 | |||
| 28 | /** @var array $headers */ |
||
| 29 | protected $headers = array(); |
||
| 30 | |||
| 31 | /** @var string $plainMessage */ |
||
| 32 | protected $plainMessage; |
||
| 33 | |||
| 34 | /** @var string $htmlMessage */ |
||
| 35 | protected $htmlMessage; |
||
| 36 | |||
| 37 | /** @var array $attachments */ |
||
| 38 | protected $attachments = array(); |
||
| 39 | |||
| 40 | /** @var string MAILER_PATTERN */ |
||
| 41 | const MAILER_PATTERN = "PHP/%s"; |
||
| 42 | |||
| 43 | /** @var string LINE_BREAK */ |
||
| 44 | const LINE_BREAK = "\r\n"; |
||
| 45 | |||
| 46 | /** @var string BOUNDARY_PATTERN */ |
||
| 47 | const BOUNDARY_PATTERN = "PHP-mixed-%s"; |
||
| 48 | |||
| 49 | /** @var string BOUNDARY_SALT */ |
||
| 50 | const BOUNDARY_SALT = "Boundary Salt"; |
||
| 51 | |||
| 52 | /** @var string ALTERNATIVE_BOUNDARY_PATTERN */ |
||
| 53 | const ALTERNATIVE_BOUNDARY_PATTERN = "PHP-alternative-%s"; |
||
| 54 | |||
| 55 | /** @var string ALTERNATIVE_BOUNDARY_SALT */ |
||
| 56 | const ALTERNATIVE_BOUNDARY_SALT = "Alternative Boundary Salt"; |
||
| 57 | |||
| 58 | /** |
||
| 59 | * @param string $mailer |
||
| 60 | */ |
||
| 61 | public function __construct($mailer = null) |
||
| 68 | |||
| 69 | /** |
||
| 70 | * Setter method for adding recipients |
||
| 71 | * |
||
| 72 | * @param string $address email address for the recipient |
||
| 73 | * @param string $title name of the recipient (optional) |
||
| 74 | |||
| 75 | * @return object instantiated $this |
||
| 76 | */ |
||
| 77 | View Code Duplication | public function addTo($address, $title = '') |
|
| 86 | |||
| 87 | /** |
||
| 88 | * Setter method for adding cc recipients |
||
| 89 | * |
||
| 90 | * @param string $address email address for the cc recipient |
||
| 91 | * @param string $title name of the cc recipient (optional) |
||
| 92 | * |
||
| 93 | * @return object instantiated $this |
||
| 94 | */ |
||
| 95 | View Code Duplication | public function addCC($address, $title = '') |
|
| 104 | |||
| 105 | /** |
||
| 106 | * Setter method for adding bcc recipients |
||
| 107 | * |
||
| 108 | * @param string $addres email address for the bcc recipient |
||
| 109 | * @param string $title name of the bcc recipient (optional) |
||
| 110 | * |
||
| 111 | * @return object instantiated $this |
||
| 112 | */ |
||
| 113 | View Code Duplication | public function addBCC($address, $title = '') |
|
| 122 | |||
| 123 | /** |
||
| 124 | * Setter method for setting the single 'from' field |
||
| 125 | * |
||
| 126 | * @param string $address email address for the sender |
||
| 127 | * @param string $title name of the sender (optional) |
||
| 128 | * |
||
| 129 | * @return object instantiated $this |
||
| 130 | */ |
||
| 131 | View Code Duplication | public function setFrom($address, $title = '') |
|
| 140 | |||
| 141 | /** |
||
| 142 | * Setter method for setting the single 'reply-to' field |
||
| 143 | * |
||
| 144 | * @param string $address email address for the reply-to |
||
| 145 | * @param string $title name of the reply-to (optional) |
||
| 146 | * |
||
| 147 | * @return object instantiated $this |
||
| 148 | */ |
||
| 149 | View Code Duplication | public function setReplyTo($address, $title = '') |
|
| 158 | |||
| 159 | /** |
||
| 160 | * Setter method for setting a subject |
||
| 161 | * |
||
| 162 | * @param string $subject subject for the email |
||
| 163 | * |
||
| 164 | * @return object instantiated $this |
||
| 165 | */ |
||
| 166 | public function setSubject($subject) |
||
| 172 | |||
| 173 | /** |
||
| 174 | * Setter method for the plain text message |
||
| 175 | * |
||
| 176 | * @param string $message the plain-text message |
||
| 177 | * |
||
| 178 | * @return object instantiated $this |
||
| 179 | */ |
||
| 180 | public function setPlainMessage($message) |
||
| 186 | |||
| 187 | /** |
||
| 188 | * Setter method for the html message |
||
| 189 | * |
||
| 190 | * @param string $message the html message |
||
| 191 | * |
||
| 192 | * @return object instantiated $this |
||
| 193 | */ |
||
| 194 | public function setHTMLMessage($message) |
||
| 200 | |||
| 201 | /** |
||
| 202 | * Setter method for adding attachments |
||
| 203 | * |
||
| 204 | * @param string $path the full path of the attachment |
||
| 205 | * @param string $type mime type of the file |
||
| 206 | * @param string $title the title of the attachment (optional) |
||
| 207 | * |
||
| 208 | * @return object instantiated $this |
||
| 209 | */ |
||
| 210 | public function addAttachment($path, $type, $title = '') |
||
| 220 | |||
| 221 | /** |
||
| 222 | * The executing step, the actual sending of the email |
||
| 223 | * First checks to make sure the minimum fields are set (returns false if they are not) |
||
| 224 | * Second it attempts to send the mail with php's mail() (returns false if it fails) |
||
| 225 | * |
||
| 226 | * return boolean whether or not the email was valid & sent |
||
| 227 | */ |
||
| 228 | public function send() |
||
| 243 | |||
| 244 | /** |
||
| 245 | * Main instantiator for the class |
||
| 246 | * |
||
| 247 | * @return object instantiated $this |
||
| 248 | */ |
||
| 249 | public static function instance() |
||
| 253 | |||
| 254 | /** |
||
| 255 | * Private call to check the minimum required fields |
||
| 256 | * |
||
| 257 | * @return boolean whether or not the email meets the minimum required fields |
||
| 258 | */ |
||
| 259 | private function check_required_fields() |
||
| 269 | |||
| 270 | /** |
||
| 271 | * Private function to collect the recipients from to_array |
||
| 272 | * |
||
| 273 | * @return string comma-separated lit of recipients |
||
| 274 | */ |
||
| 275 | private function get_to() |
||
| 279 | |||
| 280 | /** |
||
| 281 | * Long, nasty creater of the actual message, with all the multipart logic you'd never want to see |
||
| 282 | * |
||
| 283 | * @return string email message |
||
| 284 | */ |
||
| 285 | private function get_message() |
||
| 354 | |||
| 355 | /** |
||
| 356 | * Private holder for the boundry logic |
||
| 357 | * Not called/created unless it's needed |
||
| 358 | * |
||
| 359 | * @return string boundary |
||
| 360 | */ |
||
| 361 | private $boundary; |
||
| 362 | private function get_boundary() |
||
| 368 | |||
| 369 | /** |
||
| 370 | * Private holder for the alternative boundry logic |
||
| 371 | * Not called/created unless it's needed |
||
| 372 | * |
||
| 373 | * @return string alternative boundary |
||
| 374 | */ |
||
| 375 | private $alternative_boundary; |
||
| 376 | private function get_alternative_boundary() |
||
| 382 | |||
| 383 | /** |
||
| 384 | * Fetcher for the additional headers needed for multipart emails |
||
| 385 | * |
||
| 386 | * @return string headers needed for multipart |
||
| 387 | */ |
||
| 388 | private function get_additional_headers() |
||
| 414 | |||
| 415 | /** |
||
| 416 | * File reader for attachments |
||
| 417 | * |
||
| 418 | * @return string binary representation of file, base64'd |
||
| 419 | */ |
||
| 420 | private function get_attachment_content($attachment) |
||
| 430 | } |
||
| 431 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.