db_sync_tool.remote.system

Complexity

Total Complexity

7

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Importance

Changes

0

2 Functions

Rating	Name	Duplication	Size	Complexity
A	run_ssh_command_by_client()	0	11	3
A	run_ssh_command()	0	18	4

#!/usr/bin/env python3

Missing module docstring

# -*- coding: utf-8 -*-

import sys
from db_sync_tool.utility import mode, output
from db_sync_tool.remote import client as remote_client


def run_ssh_command_by_client(client, command):

Either all return statements in a function should return an expression, or none of them should.

    """
    Running origin ssh command
    :param client: String
    :param command: String
    :return:
    """
    if client == mode.Client.ORIGIN:

Unnecessary "elif" after "return"

        return run_ssh_command(command, remote_client.ssh_client_origin)
    elif client == mode.Client.TARGET:
        return run_ssh_command(command, remote_client.ssh_client_target)


def run_ssh_command(command, ssh_client=remote_client.ssh_client_origin):
    """
    Running ssh command
    :param command: String
    :param ssh_client:
    :return:
    """
    stdin, stdout, stderr = ssh_client.exec_command(command)

The variable stdin seems to be unused.

    exit_status = stdout.channel.recv_exit_status()

    err = stderr.read().decode()

    if err and 0 != exit_status:

Comparison should be exit_status != 0

        sys.exit(output.message(output.Subject.ERROR, err, False))
    elif err:
        output.message(output.Subject.WARNING, err, True)

    return stdout

Final newline missing