db_sync_tool.recipes.drupal

Complexity

Total Complexity

3

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Importance

Changes

0

2 Functions

Rating	Name	Duplication	Size	Complexity
A	get_database_setting()	0	21	2
A	check_configuration()	0	18	1

#!/usr/bin/env python3

Missing module docstring

# -*- coding: utf-8 -*-

import json

The import json seems to be unused.

import os

The import os seems to be unused.

import sys

The import sys seems to be unused.

from subprocess import check_output

Unused check_output imported from subprocess

from db_sync_tool.utility import mode, system, helper, output

Unused output imported from db_sync_tool.utility

def check_configuration(client):
    """
    Checking Drupal database configuration
    :param client: String
    :return:
    """
    _os = helper.check_os(client).strip()
    _path = system.config[client]['path']

    _db_config = {
        'name': get_database_setting(client, 'database', _path, _os),
        'host': get_database_setting(client, 'host', _path, _os),
        'password': get_database_setting(client, 'password', _path, _os),
        'port': get_database_setting(client, 'port', _path, _os),
        'user': get_database_setting(client, 'username', _path, _os),
    }

    system.config[client]['db'] = _db_config


def get_database_setting(client, name, file, os):

os is re-defining a name which is already available in the outer-scope (previously defined on line 5).

Argument name "os" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

    """
    Parsing a single database variable from the settings.php file
    :param client: String
    :param name: String
    :param file: String
    :param os: String
    :return:
    """
    if os == 'Darwin':

Unnecessary "else" after "return"

        return mode.run_command(
            helper.get_command(client, 'perl') + ' -nle "print $& while m{(?<=\'' + name + '\' => ).*(?=,)}g" ' + file + '| head -n 1',

This line is too long as per the coding-style (135/100).

            client,
            True
        ).replace('"', '').replace('\'', '').replace('\n', '')
    else:
        return mode.run_command(
            helper.get_command(client, 'grep') + f' -Po "(?<=\'{name}\' => ).*(?=,)" {file}',
            client,
            True
        ).replace('"', '').replace('\'', '').replace('\n', '')

Trailing newlines