describe_model_mixin() - Code Metrics - Inspection of "Merge pull request #138 from jacebrowning/feature/..." - jacebrowning/yorm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( ae7ea2...7d38f7 )

by Jace

created 2017-01-22 02:35 UTC

describe_model_mixin() D

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	60
rs	4.9523
cc	9

8 Methods

Rating	Name	Size	Complexity
A	it_adds_a_new_method()	5	1
A	it_adds_a_find_method()	5	1
A	it_adds_a_save_method()	5	1
A	it_adds_a_match_method()	5	1
A	mixed_class()	8	1
A	mixed_instance()	3	1
A	it_adds_a_delete_method()	5	1
A	it_adds_a_load_method()	5	1

How to fix Long Method

# pylint: disable=unused-variable,expression-not-assigned

from unittest.mock import patch, call

import pytest
from expecter import expect
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

import yorm
from yorm.mixins import ModelMixin


def describe_model_mixin():

    @pytest.fixture
    def mixed_class():

        @yorm.sync("tmp/model.yml")
        class MyClass(ModelMixin):
            pass

        return MyClass

    @pytest.fixture
    def mixed_instance(mixed_class):
        return mixed_class()

    @patch('yorm.mixins.utilities')
    def it_adds_a_new_method(utilities, mixed_class):
        mixed_class.new('foobar', overwrite=True)

        expect(utilities.mock_calls) == [
            call.create(mixed_class, 'foobar', overwrite=True)
        ]

    @patch('yorm.mixins.utilities')
    def it_adds_a_find_method(utilities, mixed_class):
        mixed_class.find('foobar', create=True)

        expect(utilities.mock_calls) == [
            call.find(mixed_class, 'foobar', create=True)
        ]

    @patch('yorm.mixins.utilities')
    def it_adds_a_match_method(utilities, mixed_class):
        mixed_class.match(foo='bar')

        expect(utilities.mock_calls) == [
            call.match(mixed_class, foo='bar')
        ]

    @patch('yorm.mixins.utilities')
    def it_adds_a_load_method(utilities, mixed_instance):
        mixed_instance.load()

        expect(utilities.mock_calls) == [
            call.load(mixed_instance)
        ]

    @patch('yorm.mixins.utilities')
    def it_adds_a_save_method(utilities, mixed_instance):
        mixed_instance.save()

        expect(utilities.mock_calls) == [
            call.save(mixed_instance)
        ]

    @patch('yorm.mixins.utilities')
    def it_adds_a_delete_method(utilities, mixed_instance):
        mixed_instance.delete()

        expect(utilities.mock_calls) == [
            call.delete(mixed_instance)
        ]


1			# pylint: disable=unused-variable,expression-not-assigned
2
3			from unittest.mock import patch, call
4
5			import pytest
6			from expecter import expect
			0 ignored issues – show Configuration introduced 2017-01-22 02:27 UTC by Report Bug Copy Issue Report The import `expecter` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
7
8			import yorm
9			from yorm.mixins import ModelMixin
10
11
12			def describe_model_mixin():
13
14			@pytest.fixture
15			def mixed_class():
16
17			@yorm.sync("tmp/model.yml")
18			class MyClass(ModelMixin):
19			pass
20
21			return MyClass
22
23			@pytest.fixture
24			def mixed_instance(mixed_class):
25			return mixed_class()
26
27			@patch('yorm.mixins.utilities')
28			def it_adds_a_new_method(utilities, mixed_class):
29			mixed_class.new('foobar', overwrite=True)
30
31			expect(utilities.mock_calls) == [
32			call.create(mixed_class, 'foobar', overwrite=True)
33			]
34
35			@patch('yorm.mixins.utilities')
36			def it_adds_a_find_method(utilities, mixed_class):
37			mixed_class.find('foobar', create=True)
38
39			expect(utilities.mock_calls) == [
40			call.find(mixed_class, 'foobar', create=True)
41			]
42
43			@patch('yorm.mixins.utilities')
44			def it_adds_a_match_method(utilities, mixed_class):
45			mixed_class.match(foo='bar')
46
47			expect(utilities.mock_calls) == [
48			call.match(mixed_class, foo='bar')
49			]
50
51			@patch('yorm.mixins.utilities')
52			def it_adds_a_load_method(utilities, mixed_instance):
53			mixed_instance.load()
54
55			expect(utilities.mock_calls) == [
56			call.load(mixed_instance)
57			]
58
59			@patch('yorm.mixins.utilities')
60			def it_adds_a_save_method(utilities, mixed_instance):
61			mixed_instance.save()
62
63			expect(utilities.mock_calls) == [
64			call.save(mixed_instance)
65			]
66
67			@patch('yorm.mixins.utilities')
68			def it_adds_a_delete_method(utilities, mixed_instance):
69			mixed_instance.delete()
70
71			expect(utilities.mock_calls) == [
72			call.delete(mixed_instance)
73			]
74

jacebrowning / yorm

Push — develop ( ae7ea2...7d38f7 )

describe_model_mixin() D

Complexity

Size

Duplication

Importance

8 Methods

How to fix Long Method

Long Method

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files