TemplateStore - Code Metrics - Inspection of "Reformat templates automatically" - jacebrowning/memegen - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#177)

by Jace

created 2016-03-30 14:46 UTC

TemplateStore A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Metric	Value
dl	0
loc	24
ccs	16
cts	16
cp	1
rs	10
wmc	8

3 Methods

Rating	Name	Size	Complexity
A	filter()	5	2
A	read()	7	3
A	__init__()	8	3

import os

import yorm
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from yorm.types import String, List
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

from ..domain import Template


@yorm.attr(name=String)
@yorm.attr(link=String)
@yorm.attr(default=List.of_type(String))
@yorm.attr(aliases=List.of_type(String))
@yorm.attr(regexes=List.of_type(String))
@yorm.sync("{self.root}/{self.key}/config.yml")
class TemplateModel:
    """Persistence model for templates."""

    def __init__(self, key, root):
        self.key = key
        self.root = root
        self.name = ""
        self.default = []
        self.link = ""
        self.aliases = []
        self.regexes = []

    @property
    def domain(self):
        return Template(
            key=self.key,
            name=self.name,
            lines=self.default if any(self.default) else [],
            aliases=self.aliases,
            patterns=self.regexes,
            link=self.link,
            root=self.root,
        )


class TemplateStore:

    def __init__(self, root):
        self.root = root
        self._items = {}
        for key in os.listdir(self.root):
            if key[0] not in ('.', '_'):
                model = TemplateModel(key, self.root)
                yorm.update_file(model)
                self._items[key] = model

    def read(self, key):
        try:
            model = self._items[key]
        except KeyError:
            return None
        else:
            return model.domain

    def filter(self, **_):
        templates = []
        for model in self._items.values():
            templates.append(model.domain)
        return templates


Pull Request — master (#177)

TemplateStore A

Complexity

Size/Duplication

Test Coverage

3 Methods

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1	1	import os
2
3	1	import yorm
		0 ignored issues – show Configuration introduced 2015-11-29 01:37 UTC by Report Bug Copy Issue Report The import `yorm` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
4		from yorm.types import String, List
		0 ignored issues – show Configuration introduced 2016-03-30 14:55 UTC by Report Bug Copy Issue Report The import `yorm.types` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
5	1
6		from ..domain import Template
7
8	1
9	1	@yorm.attr(name=String)
10	1	@yorm.attr(link=String)
11		@yorm.attr(default=List.of_type(String))
12		@yorm.attr(aliases=List.of_type(String))
13	1	@yorm.attr(regexes=List.of_type(String))
14	1	@yorm.sync("{self.root}/{self.key}/config.yml")
15	1	class TemplateModel:
16	1	"""Persistence model for templates."""
17	1
18	1	def __init__(self, key, root):
19	1	self.key = key
20		self.root = root
21		self.name = ""
22		self.default = []
23	1	self.link = ""
24	1	self.aliases = []
25	1	self.regexes = []
26
27	1	@property
28		def domain(self):
29		return Template(
30	1	key=self.key,
31		name=self.name,
32		lines=self.default if any(self.default) else [],
33		aliases=self.aliases,
34		patterns=self.regexes,
35		link=self.link,
36		root=self.root,
37		)
38
39
40		class TemplateStore:
41	1
42	1	def __init__(self, root):
43		self.root = root
44	1	self._items = {}
45	1	for key in os.listdir(self.root):
46	1	if key[0] not in ('.', '_'):
47	1	model = TemplateModel(key, self.root)
48		yorm.update_file(model)
49		self._items[key] = model
50	1
51		def read(self, key):
52	1	try:
53	1	model = self._items[key]
54	1	except KeyError:
55		return None
56	1	else:
57		return model.domain
58	1
59	1	def filter(self, **_):
60	1	templates = []
61	1	for model in self._items.values():
62		templates.append(model.domain)
63		return templates
64

jacebrowning / memegen

Pull Request — master (#177)

TemplateStore A

Complexity

Size/Duplication

Test Coverage

3 Methods

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files

2. Missing init.py files