Cache.add() - Code Metrics - Inspection of "Disable caching of profanity" - jacebrowning/memegen - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#247)

by Jace

created 2016-09-28 03:08 UTC

Cache.add() B

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	7.5412

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	5
c	2
b	0
f	0
dl	0
loc	18
ccs	8
cts	15
cp	0.5333
crap	7.5412
rs	8.5454

import logging

import yorm
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from yorm.types import List, Object
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
import profanityfilter
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3


log = logging.getLogger(__name__)


@yorm.attr(items=List.of_type(Object))
@yorm.sync("data/images/cache.yml")
class Cache:

    SIZE = 9

    def __init__(self):
        self.items = []

    def add(self, **kwargs):
        if kwargs in self.items:
            log.debug("Already cached: %s", kwargs)
            return
        if kwargs['key'] == 'custom':
            log.debug("Skipped caching of custom: %s", kwargs)
            return
        if profanityfilter.is_profane(kwargs['path']):
            log.debug("Skipped caching of profanity: %s", kwargs)
            return

        log.info("Caching: %s", kwargs)

        self.items.insert(0, kwargs)
        while len(self.items) > self.SIZE:
            self.items.pop()

        yorm.save(self)

    def get(self, index):
        log.info("Getting cache index: %s", index)

        try:
            data = self.items[index]
        except IndexError:
            data = {}

        log.info("Retrieved cache: %s", data)

        return data


Pull Request — master (#247)

Cache.add() B

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1	1	import logging
2
3	1	import yorm
		0 ignored issues – show Configuration introduced 2016-09-02 04:19 UTC by Report Bug Copy Issue Report The import `yorm` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
4	1	from yorm.types import List, Object
		0 ignored issues – show Configuration introduced 2016-09-02 04:19 UTC by Report Bug Copy Issue Report The import `yorm.types` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
5	1	import profanityfilter
		0 ignored issues – show Configuration introduced 2016-09-28 03:11 UTC by Report Bug Copy Issue Report The import `profanityfilter` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
6
7
8	1	log = logging.getLogger(__name__)
9
10
11	1	@yorm.attr(items=List.of_type(Object))
12	1	@yorm.sync("data/images/cache.yml")
13		class Cache:
14
15	1	SIZE = 9
16
17	1	def __init__(self):
18	1	self.items = []
19
20	1	def add(self, **kwargs):
21	1	if kwargs in self.items:
22		log.debug("Already cached: %s", kwargs)
23		return
24	1	if kwargs['key'] == 'custom':
25		log.debug("Skipped caching of custom: %s", kwargs)
26		return
27	1	if profanityfilter.is_profane(kwargs['path']):
28		log.debug("Skipped caching of profanity: %s", kwargs)
29		return
30
31	1	log.info("Caching: %s", kwargs)
32
33	1	self.items.insert(0, kwargs)
34	1	while len(self.items) > self.SIZE:
35		self.items.pop()
36
37	1	yorm.save(self)
38
39	1	def get(self, index):
40	1	log.info("Getting cache index: %s", index)
41
42	1	try:
43	1	data = self.items[index]
44	1	except IndexError:
45	1	data = {}
46
47	1	log.info("Retrieved cache: %s", data)
48
49		return data
50

jacebrowning / memegen

Pull Request — master (#247)

Cache.add() B

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files

2. Missing init.py files

2. Missing init.py files