tests.describe_gdm() - Code Metrics - Inspection of "Add 'edit' command" - jacebrowning/gdm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#103)

by Jace

created 2016-02-27 03:58 UTC

tests.describe_gdm() B

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	6
dl	0
loc	22
rs	7.7857

3 Methods

Rating	Name	Size	Complexity
A	tests.it_exits_when_no_config_found()	5	2
A	tests.it_launches_the_config()	5	1
A	tests.describe_edit()	13	4

# pylint: disable=unused-variable,expression-not-assigned
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

from unittest.mock import patch, call

import pytest
from expecter import expect
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

from gdm import cli


def describe_gdm():
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

    @pytest.fixture
    def config(tmpdir):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        tmpdir.chdir()
        path = str(tmpdir.join("gdm.yml"))
        open(path, 'w').close()
        return path

    def describe_edit():
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

        @patch('gdm.system.launch')
        def it_launches_the_config(launch, config):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
            cli.main(['edit'])

            expect(launch.mock_calls) == [call(config), call().__bool__()]

        def it_exits_when_no_config_found(tmpdir):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
            tmpdir.chdir()

            with expect.raises(SystemExit):
                cli.main(['edit'])


Pull Request — develop (#103)

tests.describe_gdm() B

Complexity

Size

Duplication

3 Methods

1. Missing Dependencies

2. Missing init.py files

1			# pylint: disable=unused-variable,expression-not-assigned
			0 ignored issues – show Coding Style introduced 2015-12-22 22:45 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2
3			from unittest.mock import patch, call
4
5			import pytest
6			from expecter import expect
			0 ignored issues – show Configuration introduced 2016-02-27 03:58 UTC by Report Bug Copy Issue Report The import `expecter` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
7
8			from gdm import cli
9
10
11			def describe_gdm():
			0 ignored issues – show Coding Style introduced 2016-02-27 03:58 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
12
13			@pytest.fixture
14			def config(tmpdir):
			0 ignored issues – show Coding Style introduced 2016-02-27 03:58 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
15			tmpdir.chdir()
16			path = str(tmpdir.join("gdm.yml"))
17			open(path, 'w').close()
18			return path
19
20			def describe_edit():
			0 ignored issues – show Coding Style introduced 2016-02-27 03:58 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
21
22			@patch('gdm.system.launch')
23			def it_launches_the_config(launch, config):
			0 ignored issues – show Coding Style introduced 2016-02-27 03:58 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
24			cli.main(['edit'])
25
26			expect(launch.mock_calls) == [call(config), call().__bool__()]
27
28			def it_exits_when_no_config_found(tmpdir):
			0 ignored issues – show Coding Style introduced 2016-02-27 03:58 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
29			tmpdir.chdir()
30
31			with expect.raises(SystemExit):
32			cli.main(['edit'])
33

jacebrowning / gdm

Pull Request — develop (#103)

tests.describe_gdm() B

Complexity

Size

Duplication

3 Methods

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files