describe_match() - Code Metrics - Inspection of "Cache API calls locally" - jacebrowning/coverage-space-cli - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#18)

by Jace

created 2016-08-22 21:14 UTC

describe_match() A

↳ Parent: describe_cache()

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
c	1
b	0
f	0
dl	0
loc	17
rs	9.2

# pylint: disable=missing-docstring,unused-variable,unused-argument,expression-not-assigned,singleton-comparison


import pytest
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from expecter import expect
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

from coveragespace.cache import Cache


def describe_cache():

    # pylint: disable=protected-access

    @pytest.fixture
    def cache():
        return Cache()

    def describe_load():

        def it_loads_previous_results(cache):
            cache._data['value'] = "saved"
            cache._store()

            expect(Cache.load()._data['value']) == "saved"

    def describe_match():

        def it_hits_with_existing_data(cache):
            cache._data['abc'] = 123

            expect(cache.match('abc', 123)) == True

        def it_misses_with_no_data(cache):
            cache._data.pop('abc', None)

            expect(cache.match('abc', 123)) == False

        def it_caches_requests(cache):
            cache._data.pop('abc', None)
            cache.match('abc', 123)

            expect(cache.match('abc', 123)) == True


Pull Request — develop (#18)

describe_match() A

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1			# pylint: disable=missing-docstring,unused-variable,unused-argument,expression-not-assigned,singleton-comparison
			0 ignored issues – show introduced 2016-08-22 21:20 UTC by Report Bug Copy Issue Report Bad option value 'singleton-comparison' Loading history...
2
3			import pytest
			0 ignored issues – show Configuration introduced 2016-08-22 21:20 UTC by Report Bug Copy Issue Report The import `pytest` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
4			from expecter import expect
			0 ignored issues – show Configuration introduced 2016-08-22 21:20 UTC by Report Bug Copy Issue Report The import `expecter` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
5
6			from coveragespace.cache import Cache
7
8
9			def describe_cache():
10
11			# pylint: disable=protected-access
12
13			@pytest.fixture
14			def cache():
15			return Cache()
16
17			def describe_load():
18
19			def it_loads_previous_results(cache):
20			cache._data['value'] = "saved"
21			cache._store()
22
23			expect(Cache.load()._data['value']) == "saved"
24
25			def describe_match():
26
27			def it_hits_with_existing_data(cache):
28			cache._data['abc'] = 123
29
30			expect(cache.match('abc', 123)) == True
31
32			def it_misses_with_no_data(cache):
33			cache._data.pop('abc', None)
34
35			expect(cache.match('abc', 123)) == False
36
37			def it_caches_requests(cache):
38			cache._data.pop('abc', None)
39			cache.match('abc', 123)
40
41			expect(cache.match('abc', 123)) == True
42

jacebrowning / coverage-space-cli

Pull Request — develop (#18)

describe_match() A

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files

2. Missing init.py files