FixedWaitTimeToRetry::isAvailable() - Code Metrics - Inspection of "Implement basic strategy to retry" - j-velasco/php-circuit-breaker - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 072d04...55dded )

by Jorge

created 2018-03-03 07:28 UTC

FixedWaitTimeToRetry::isAvailable() A

↳ Parent: FixedWaitTimeToRetry

Complexity

Conditions	4
Paths	6

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	4

Importance

Changes

Metric	Value
cc	4
eloc	9
nc	6
nop	1
dl	0
loc	15
ccs	9
cts	9
cp	1
crap	4
rs	9.2
c	0
b	0
f	0

<?php

namespace JVelasco\CircuitBreaker\AvailabilityStrategy;

use JVelasco\CircuitBreaker\AvailabilityStrategy;
use JVelasco\CircuitBreaker\StorageException;

final class FixedWaitTimeToRetry implements AvailabilityStrategy
{
    private $storage;
    private $maxFailures;
    private $waitTime;

    public function __construct(Storage $storage, int $maxFailures, int $waitTime)
    {
        $this->storage = $storage;
        $this->maxFailures = $maxFailures;
        $this->waitTime = $waitTime;
    }
    public function isAvailable(string $serviceName): bool
    {
        try {
            if ($this->storage->numberOfFailures($serviceName) < $this->maxFailures) {
                return true;
            }

            $lastRetry = $this->getLastTryTime();
            if (time() - $lastRetry > $this->waitTime) {
                return true;
            }

            return false;
        } catch (StorageException $ex) {
            return true;
        }
    }

    public function getId(): string
    {
        return "fixed_time_to_retry";
    }

    private function getLastTryTime(): int
    {
        $lastTryTimestamp = $this->storage->getStrategyData($this, "last_try");
        return $lastTryTimestamp ? $lastTryTimestamp : time();

    }
}


1		<?php
2
3		namespace JVelasco\CircuitBreaker\AvailabilityStrategy;
4
5		use JVelasco\CircuitBreaker\AvailabilityStrategy;
6		use JVelasco\CircuitBreaker\StorageException;
7
8		final class FixedWaitTimeToRetry implements AvailabilityStrategy
9		{
10		private $storage;
11		private $maxFailures;
12		private $waitTime;
13
14	4	public function __construct(Storage $storage, int $maxFailures, int $waitTime)
15		{
16	4	$this->storage = $storage;
17	4	$this->maxFailures = $maxFailures;
18	4	$this->waitTime = $waitTime;
19	4	}
20	4	public function isAvailable(string $serviceName): bool
21		{
22		try {
23	4	if ($this->storage->numberOfFailures($serviceName) < $this->maxFailures) {
24	1	return true;
25		}
26
27	2	$lastRetry = $this->getLastTryTime();
28	2	if (time() - $lastRetry > $this->waitTime) {
29	1	return true;
30		}
31
32	1	return false;
33	1	} catch (StorageException $ex) {
34	1	return true;
35		}
36		}
37
38		public function getId(): string
39		{
40		return "fixed_time_to_retry";
41		}
42
43	2	private function getLastTryTime(): int
44		{
45	2	$lastTryTimestamp = $this->storage->getStrategyData($this, "last_try");
46	2	return $lastTryTimestamp ? $lastTryTimestamp : time();
		0 ignored issues – show Bug Best Practice introduced 2018-03-03 07:30 UTC by Report Bug Copy Issue Report The expression `return $lastTryTimestamp...stTryTimestamp : time()` could return the type `string` which is incompatible with the type-hinted return `integer`. Consider adding an additional type-check to rule them out. Loading history...
47		}
48		}
49

j-velasco / php-circuit-breaker

Push — master ( 072d04...55dded )

FixedWaitTimeToRetry::isAvailable() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like