JVelasco\CircuitBreaker\AvailabilityStrategy\FixedWaitTimeToRetry

Complexity

Total Complexity

8

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Test Coverage

Coverage

89.47%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getId()	0	3	1
A	isAvailable()	0	15	4
A	getLastTryTime()	0	4	2
A	__construct()	0	5	1

<?php

namespace JVelasco\CircuitBreaker\AvailabilityStrategy;

use JVelasco\CircuitBreaker\AvailabilityStrategy;
use JVelasco\CircuitBreaker\StorageException;

final class FixedWaitTimeToRetry implements AvailabilityStrategy
{
    private $storage;
    private $maxFailures;
    private $waitTime;

    public function __construct(Storage $storage, int $maxFailures, int $waitTime)
    {
        $this->storage = $storage;
        $this->maxFailures = $maxFailures;
        $this->waitTime = $waitTime;
    }
    public function isAvailable(string $serviceName): bool
    {
        try {
            if ($this->storage->numberOfFailures($serviceName) < $this->maxFailures) {
                return true;
            }

            $lastRetry = $this->getLastTryTime();
            if (time() - $lastRetry > $this->waitTime) {
                return true;
            }

            return false;
        } catch (StorageException $ex) {
            return true;
        }
    }

    public function getId(): string
    {
        return "fixed_time_to_retry";
    }

    private function getLastTryTime(): int
    {
        $lastTryTimestamp = $this->storage->getStrategyData($this, "last_try");
        return $lastTryTimestamp ? $lastTryTimestamp : time();

The expression return $lastTryTimestamp ? $lastTryTimestamp : time() could return the type string which is incompatible with the type-hinted return integer. Consider adding an additional type-check to rule them out.

    }
}