FixedWaitTimeToRetry::now() - Code Metrics - Inspection of "Implement counter reset" - j-velasco/php-circuit-breaker - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 50c06c...19d06a )

by Jorge

created 2018-03-03 13:38 UTC

FixedWaitTimeToRetry::now() A

↳ Parent: FixedWaitTimeToRetry

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0
ccs	2
cts	2
cp	1
crap	1

<?php

namespace JVelasco\CircuitBreaker\AvailabilityStrategy;

use JVelasco\CircuitBreaker\AvailabilityStrategy;
use JVelasco\CircuitBreaker\StorageException;

final class FixedWaitTimeToRetry implements AvailabilityStrategy
{
    private $storage;
    private $maxFailures;
    private $waitTime;

    public function __construct(Storage $storage, int $maxFailures, int $waitTime)
    {
        $this->storage = $storage;
        $this->maxFailures = $maxFailures;
        $this->waitTime = $waitTime;
    }

    public function isAvailable(string $serviceName): bool
    {
        try {
            if ($this->storage->numberOfFailures($serviceName) < $this->maxFailures) {
                return true;
            }

            $lastRetry = $this->getLastTryTime();
            if ($this->now() - $lastRetry > $this->waitTime) {
                $this->storage->resetFailuresCounter($serviceName);
                return true;
            }

            return false;
        } catch (StorageException $ex) {
            return true;
        }
    }

    public function getId(): string
    {
        return "fixed_time_to_retry";
    }

    private function getLastTryTime(): int
    {
        $lastTryTimestamp = $this->storage->getStrategyData($this, "last_try");
        return $lastTryTimestamp ? $lastTryTimestamp : $this->now();

    }

    private function now(): int
    {
        return floor(microtime(true) * 1000);

    }
}


1		<?php
2
3		namespace JVelasco\CircuitBreaker\AvailabilityStrategy;
4
5		use JVelasco\CircuitBreaker\AvailabilityStrategy;
6		use JVelasco\CircuitBreaker\StorageException;
7
8		final class FixedWaitTimeToRetry implements AvailabilityStrategy
9		{
10		private $storage;
11		private $maxFailures;
12		private $waitTime;
13
14	5	public function __construct(Storage $storage, int $maxFailures, int $waitTime)
15		{
16	5	$this->storage = $storage;
17	5	$this->maxFailures = $maxFailures;
18	5	$this->waitTime = $waitTime;
19	5	}
20
21	5	public function isAvailable(string $serviceName): bool
22		{
23		try {
24	5	if ($this->storage->numberOfFailures($serviceName) < $this->maxFailures) {
25	2	return true;
26		}
27
28	3	$lastRetry = $this->getLastTryTime();
29	3	if ($this->now() - $lastRetry > $this->waitTime) {
30	1	$this->storage->resetFailuresCounter($serviceName);
31	1	return true;
32		}
33
34	2	return false;
35	1	} catch (StorageException $ex) {
36	1	return true;
37		}
38		}
39
40	1	public function getId(): string
41		{
42	1	return "fixed_time_to_retry";
43		}
44
45	3	private function getLastTryTime(): int
46		{
47	3	$lastTryTimestamp = $this->storage->getStrategyData($this, "last_try");
48	3	return $lastTryTimestamp ? $lastTryTimestamp : $this->now();
		0 ignored issues – show Bug Best Practice introduced 2018-03-03 13:40 UTC by Report Bug Copy Issue Report The expression `return $lastTryTimestamp...imestamp : $this->now()` could return the type `string` which is incompatible with the type-hinted return `integer`. Consider adding an additional type-check to rule them out. Loading history...
49		}
50
51	3	private function now(): int
52		{
53	3	return floor(microtime(true) * 1000);
		0 ignored issues – show Bug Best Practice introduced 2018-03-03 13:40 UTC by Report Bug Copy Issue Report The expression `return floor(microtime(true) * 1000)` returns the type `double` which is incompatible with the type-hinted return `integer`. Loading history...
54		}
55		}
56

j-velasco / php-circuit-breaker

Push — master ( 50c06c...19d06a )

FixedWaitTimeToRetry::now() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like