WeatherController::indexActionGet() - Code Metrics - Inspection of "Removed one 'if-section' from controllers to get b..." - j-lindb73/weather - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( b79556...5cf45d )

by Johan

created 2020-12-02 08:42 UTC

WeatherController::indexActionGet() A

↳ Parent: WeatherController

Complexity

Conditions	5
Paths	4

Size

Total Lines	63
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	34
CRAP Score	5.0133

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	37
c	1
b	0
f	0
nc	4
nop	0
dl	0
loc	63
ccs	34
cts	37
cp	0.9189
crap	5.0133
rs	9.0168

How to fix Long Method

<?php

namespace Lefty\Weather;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;

// use Anax\Route\Exception\ForbiddenException;
// use Anax\Route\Exception\NotFoundException;
// use Anax\Route\Exception\InternalErrorException;

/**
 * A sample controller to show how a controller class can be implemented.
 * The controller will be injected with $di if implementing the interface
 * ContainerInjectableInterface, like this sample class does.
 * The controller is mounted on a particular route and can then handle all
 * requests for that mount point.
 *
 * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
class WeatherController implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;


    /**
     * @var string $db a sample member variable that gets initialised
     */
    private $db = "not active";



    /**
     * The initialize method is optional and will always be called before the
     * target method/action. This is a convienient method where you could
     * setup internal properties that are commonly used by several methods.
     *
     * @return void
     */
    public function initialize(): void
    {
        // Use to initialise member variables.
        $this->db = "active";
    }


    /**
    * This is the index method action, it handles:
    * ANY METHOD mountpoint
    * ANY METHOD mountpoint/
    * ANY METHOD mountpoint/index
    *
    * @return object
    */
    public function indexActionGet(): object
    {
        $request     = $this->di->get("request");
        $iptocheck = $request->getGet("ip") ?? "";

        $weatherInfo = [];

        $weatherInfoHist = [];



        // Prepare page
        $page = $this->di->get("page");
        $page->add("weather/index");
        $title = "Weather | ramverk1";

        // Validate IP
        $ipAddress = new WeatherIpValidation($iptocheck);
        $data = $ipAddress->answer();

        if (empty($iptocheck)) {
            return $page->render([
                "title" => $title,
            ]);
        } elseif (!$ipAddress->isValid()) {
            $page->add("weather/notvalidIP", $data);
            return $page->render([
                "title" => $title,
            ]);
        }
        // Get IP location
        $geoLocation = new WeatherGeoLocation($iptocheck);
        $geoLocation = /** @scrutinizer ignore-call */ new WeatherGeoLocation($iptocheck);
        $geoLocation->setDI($this->di);
        $geoLocation->setAPI("ipstack");
        $geoLocation->checkGeoLocation($iptocheck);
        $locationInfo = $geoLocation->getGeoLocation();


        // Get Weather information Forecast
        $weatherRequest = new WeatherRequest();
        $weatherRequest->setDI($this->di);
        $weatherRequest->setAPI("openweathermap");
        $weatherRequest->checkWeather($geoLocation);
        $weatherInfo = (array)$weatherRequest->getWeather();
        
        // Get Weather information Historical Data
        
        $weatherInfoHist = array("weatherInfoHistorical" => $weatherRequest->checkWeatherMulti($geoLocation));
        $weatherInfo = array_merge($weatherInfo, $weatherInfoHist);
        
        // Merge location data with ip data
        $data = array_merge($data, (array)$locationInfo);


        if ($ipAddress->isValid() && $geoLocation->geoLocationOK()) {
            $page->add("weather/validIP", $data);

            $weatherInfo = array_merge($weatherInfo, (array)$weatherInfoHist);
            $page->add("weather/weather", $weatherInfo);
        } else {
            $page->add("weather/notvalidWeather", $data);
        }

        return $page->render([
            "title" => $title,
        ]);
    }

    /**
    * This is the index method action, it handles:
    * ANY METHOD mountpoint
    * ANY METHOD mountpoint/
    * ANY METHOD mountpoint/index
    *
    * @return object
    */
    public function indexActionPost(): object
    {
        $request     = $this->di->get("request");
        $iptocheck = $request->getPost("ip") ?? "";

        $weatherInfo = [];

        $weatherInfoHist = [];



        // Prepare page
        $page = $this->di->get("page");
        $page->add("weather/index");
        $title = "Weather | ramverk1";

        // Validate IP
        $ipAddress = new WeatherIpValidation($iptocheck);
        $data = $ipAddress->answer();

        if (empty($iptocheck)) {
            return $page->render([
                "title" => $title,
            ]);
        } elseif (!$ipAddress->isValid()) {
            $page->add("weather/notvalidIP", $data);
            return $page->render([
                "title" => $title,
            ]);
        }
        // Get IP location
        $geoLocation = new WeatherGeoLocation($iptocheck);
        $geoLocation = /** @scrutinizer ignore-call */ new WeatherGeoLocation($iptocheck);
        $geoLocation->setDI($this->di);
        $geoLocation->setAPI("ipstack");
        $geoLocation->checkGeoLocation($iptocheck);
        $locationInfo = $geoLocation->getGeoLocation();


        // Get Weather information Forecast
        $weatherRequest = new WeatherRequest();
        $weatherRequest->setDI($this->di);
        $weatherRequest->setAPI("openweathermap");
        $weatherRequest->checkWeather($geoLocation);
        $weatherInfo = (array)$weatherRequest->getWeather();
        
        // Get Weather information Historical Data
        
        $weatherInfoHist = array("weatherInfoHistorical" => $weatherRequest->checkWeatherMulti($geoLocation));
        $weatherInfo = array_merge($weatherInfo, $weatherInfoHist);
        
        // Merge location data with ip data
        $data = array_merge($data, (array)$locationInfo);


        if ($ipAddress->isValid() && $geoLocation->geoLocationOK()) {
            $page->add("weather/validIP", $data);

            $weatherInfo = array_merge($weatherInfo, (array)$weatherInfoHist);
            $page->add("weather/weather", $weatherInfo);
        } else {
            $page->add("weather/notvalidWeather", $data);
        }

        return $page->render([
            "title" => $title,
        ]);
    }
}


j-lindb73 / weather

Push — main ( b79556...5cf45d )

WeatherController::indexActionGet() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like