Issues in ivycat-ajax-testimonials.php - All Issues - Inspection of "Code formatting" - ivycat/ivycat-ajax-testimonials - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — development ( 4ee6a1...22da9f )

by Eric

created 2017-12-01 23:08 UTC

ivycat-ajax-testimonials.php (39 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * @package     IvyCat AJAX Testimonials
 * @author      Eric Amundson <[email protected]>
 * @copyright   2017 IvyCat, Inc.
 * @license     GPL-2.0+
 *
 * @wordpress-plugin
 * Plugin Name: IvyCat AJAX Testimonials
 * Plugin URI: https://ivycat.com/wordpress/wordpress-plugins/ivycat-ajax-testimonials/
 * Description: Simply add dynamic testimonials to your site.
 * Author: IvyCat, Inc.
 * Author URI: https://ivycat.com
 * Version: 1.5.2
 * Text Domain: ivycat-ajax-testimonials
 * Domain Path: /languages
 * License:     GPL-2.0+
 * License URI: http://www.gnu.org/licenses/gpl-2.0.txt
 */

if ( ! defined( 'ICTESTI_DIR' ) ) {
	define( 'ICTESTI_DIR', plugin_dir_path( __FILE__ ) );
}
if ( ! defined( 'ICTESTI_URL' ) ) {
	define( 'ICTESTI_URL', plugin_dir_url( __FILE__ ) );
}

// Load the class for displaying testimonials_in_page
if ( ! class_exists( 'ICTestimonialPosts' ) ) {
	require_once( 'lib/IvyCatTestimonialsPosts.php' );
}

$GLOBALS['ivycat_testimonials'] = new IvyCatTestimonials();
add_action( 'plugins_loaded', array( $GLOBALS['ivycat_testimonials'], 'start' ) );
load_plugin_textdomain( 'ivycat-ajax-testimonials', false, dirname( plugin_basename( __FILE__ ) ) . '/languages' );

class IvyCatTestimonials {

	public $more_tag;
	public $num_words;

	public function start() {
		add_action( 'init', array( $this, 'init' ) );
		add_action( 'widgets_init', array( $this, 'register_widgets' ) );
	}

	public function init() {
		$labels = array(
			'name'               => _x( 'Testimonials', 'post format general name', 'ivycat-ajax-testimonials' ),
			'singular_name'      => _x( 'Testimonial', 'post format singular name', 'ivycat-ajax-testimonials' ),
			'add_new'            => _x( 'Add New', 'testimonials', 'ivycat-ajax-testimonials' ),
			'add_new_item'       => __( 'Add New Testimonial', 'ivycat-ajax-testimonials' ),
			'edit_item'          => __( 'Edit Testimonial', 'ivycat-ajax-testimonials' ),
			'new_item'           => __( 'New Testimonial', 'ivycat-ajax-testimonials' ),
			'view_item'          => __( 'View Testimonial', 'ivycat-ajax-testimonials' ),
			'search_items'       => __( 'Search Testimonials', 'ivycat-ajax-testimonials' ),
			'not_found'          => __( 'No testimonials found.', 'ivycat-ajax-testimonials' ),
			'not_found_in_trash' => __( 'No testimonials found in Trash.', 'ivycat-ajax-testimonials' ),
			'all_items'          => __( 'All Testimonials', 'ivycat-ajax-testimonials' ),
			'menu_name'          => __( 'Testimonials', 'ivycat-ajax-testimonials' )
		);

		$args = apply_filters( 'ic_testimonials_post_type_args', array(
			'labels'               => $labels,
			'public'               => true,
			'publicly_queryable'   => true,
			'show_ui'              => true,
			'query_var'            => true,
			'register_meta_box_cb' => array( $this, 'register_testimonial_meta_boxes' ),
			'rewrite'              => true,
			'capability_type'      => 'post',
			'hierarchical'         => false,
			'menu_position'        => 4,
			'supports'             => array( 'title', 'editor', 'excerpt', 'thumbnail' )
		) );

		register_post_type( 'testimonials', $args );

		$tax_labels = array(
			'name'                       => _x( 'Testimonial Groups', 'taxonomy general name', 'ivycat-ajax-testimonials' ),
			'singular_name'              => _x( 'Testimonial Group', 'taxonomy singular name', 'ivycat-ajax-testimonials' ),
			'search_items'               => __( 'Search Testimonial Groups', 'ivycat-ajax-testimonials' ),
			'popular_items'              => __( 'Popular Testimonial Groups', 'ivycat-ajax-testimonials' ),
			'all_items'                  => __( 'All Testimonial Groups', 'ivycat-ajax-testimonials' ),
			'parent_item'                => __( 'Parent Testimonial Groups', 'ivycat-ajax-testimonials' ),
			'parent_item_colon'          => __( 'Parent Testimonial Group:', 'ivycat-ajax-testimonials' ),
			'edit_item'                  => __( 'Edit Testimonial Group', 'ivycat-ajax-testimonials' ),
			'view_item'                  => __( 'View Testimonial Group', 'ivycat-ajax-testimonials' ),
			'update_item'                => __( 'Update Testimonial Group', 'ivycat-ajax-testimonials' ),
			'add_new_item'               => __( 'Add New Testimonial Group', 'ivycat-ajax-testimonials' ),
			'new_item_name'              => __( 'New Testimonial Group Name', 'ivycat-ajax-testimonials' ),
			'separate_items_with_commas' => __( 'Separate testimonial groups with commas', 'ivycat-ajax-testimonials' ),
			'add_or_remove_items'        => __( 'Add or remove testimonial groups', 'ivycat-ajax-testimonials' ),
			'choose_from_most_used'      => __( 'Choose from most used testimonial groups', 'ivycat-ajax-testimonials' )
		);

		$tax_args = apply_filters( 'ic_testimonials_register_tax_args', array(
			'hierarchical'      => true,
			'labels'            => $tax_labels,
			'rewrite'           => true,
			'show_admin_column' => true,
		) );

		register_taxonomy( 'testimonial-group', 'testimonials', $tax_args );

		add_action( 'wp_ajax_nopriv_get-testimonials', array( $this, 'more_testimonials' ) );
		add_action( 'wp_ajax_get-testimonials', array( $this, 'more_testimonials' ) );
		add_action( 'save_post', array( $this, 'save_testimonial_metadata' ), 10, 2 );
		add_filter( 'post_updated_messages', array( $this, 'testimonial_update_messages' ) );

		add_shortcode( 'ic_do_testimonials', array( $this, 'do_testimonials' ) );

		wp_register_script( 'ict-ajax-scripts', ICTESTI_URL . 'assets/ivycat-testimonials-scripts.js', array(
			'jquery',
			'jquery-migrate'

		) );
	}

	public function register_widgets() {
		require_once( ICTESTI_DIR . 'lib/IvyCatTestimonialsWidget.php' );
		register_widget( 'IvyCatTestimonialsWidget' );
	}

	public function testimonial_update_messages( $messages ) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		global $post;
function myFunction($a, $b) {
    // Do something
}

		$messages['testimonials'] = array(
			0  => '', // Unused. Messages start at index 1.
			1  => sprintf( __( 'Testimonial updated. <a href="%s">View Testimonial</a>', 'ivycat-ajax-testimonials' ), esc_url( get_permalink( $post->ID ) ) ),
			2  => __( 'Custom field updated.', 'ivycat-ajax-testimonials' ),
			3  => __( 'Custom field deleted.', 'ivycat-ajax-testimonials' ),
			4  => __( 'Testimonial updated.', 'ivycat-ajax-testimonials' ),
			/* translators: %s: date and time of the revision */
			5  => isset( $_GET['revision'] ) ? sprintf( __( 'Testimonial restored to revision from %s', 'ivycat-ajax-testimonials' ), wp_post_revision_title( (int) $_GET['revision'], false ) ) : false,

			6  => sprintf( __( 'Testimonial published. <a href="%s">View Testimonial</a>', 'ivycat-ajax-testimonials' ), esc_url( get_permalink( $post->ID ) ) ),
			7  => __( 'Testimonial saved.', 'ivycat-ajax-testimonials' ),
			8  => sprintf( __( 'Testimonial submitted. <a target="_blank" href="%s">Preview Testimonial</a>', 'ivycat-ajax-testimonials' ), esc_url( add_query_arg( 'preview', 'true', get_permalink( $post->ID ) ) ) ),
			9  => sprintf( __( 'Testimonial scheduled for: <strong>%1$s</strong>. <a target="_blank" href="%2$s">Preview Testimonial</a>', 'ivycat-ajax-testimonials' ),
				// translators: Publish box date format, see http://php.net/date
				date_i18n( __( 'M j, Y @ G:i', 'ivycat-ajax-testimonials' ), strtotime( $post->post_date ) ), esc_url( get_permalink( $post->ID ) ) ),

			10 => sprintf( __( 'Testimonial draft updated. <a target="_blank" href="%s">Preview Testimonial</a>', 'ivycat-ajax-testimonials' ), esc_url( add_query_arg( 'preview', 'true', get_permalink( $post->ID ) ) ) ),
		);

		return apply_filters( 'ic_testimonials_update_messages', $messages );
	}

	public function register_testimonial_meta_boxes() {
		add_meta_box(
			'Testimonialinfo-meta',
			__( 'Testimonial Data', 'ivycat-ajax-testimonials' ),
			array( $this, 'testimonial_metabox' ),
			'testimonials',
			'side',
			'high'
		);
	}

	public function testimonial_metabox( $post ) {
		$testimonial_order = get_post_meta( $post->ID, 'ivycat_testimonial_order', true );
		wp_nonce_field( 'save-testimonial-order_' . $post->ID, 'ivycat_testimonial_order_nonce' );
		?>
        <p>
            <label for="test-order"><?php _e( 'Order:', 'ivycat-ajax-testimonials' ); ?></label>
            <input id="test-order" type="text" name="testimonial_order"
                   value="<?php echo absint( $testimonial_order ); ?>"/>
        </p>
		<?php
		do_action( 'ic_testimonials_testimonial_metabox', $post );
	}

	public function save_testimonial_metadata( $post_id, $post ) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		if ( ! isset( $_POST['ivycat_testimonial_order_nonce'] ) || ! wp_verify_nonce( $_POST['ivycat_testimonial_order_nonce'], 'save-testimonial-order_' . $post_id ) ) {

			return;
		}
		do_action( 'ic_testimonials_save_metadata', $post_id, $post );
		update_post_meta( $post_id, 'ivycat_testimonial_order', $_POST['testimonial_order'] );

	}

	public function do_testimonials( $args, $content = null ) {

		// fix for camel case previous verions
		if ( isset( $args['fadein'] ) ) {
			$args['fade_in'] = $args['fadein'];
		}
		if ( isset( $args['fadeout'] ) ) {
			$args['fade_out'] = $args['fadeout'];
		}
		$atts = wp_parse_args( $args, array(
			'quantity'          => 3,
			'title'             => false,
			'link_testimonials' => false,
			'group'             => false,
			'num_words'         => false,
			'more_tag'          => false,
			'ajax_on'           => 'yes',
			'all_title'         => false,
			'all_url'           => false,
			'fade_in'           => 500,
			'fade_out'          => 300,
			'speed'             => 8000,
			'display'           => 'single'

		) );
		extract( apply_filters( 'ic_testimonials_args', $atts ) );

		$testimonials    = apply_filters(
			'ic_testimonials_data',
			$this->get_testimonials( 1, $group, $num_words, $more_tag, $ajax_on, $link_testimonials )
		);
		$this->more_tag  = $atts['more_tag'];
		$this->num_words = $atts['num_words'];

		if ( count( $testimonials ) == 0 ) {

			return '';
		}
		// check for display option set to list
		if ( 'list' == $display ) :
			// turn off ajax
			$ajax_on = 'no';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
			// pagination
			$atts['paginate'] = true;
			// if user set a number of posts to show pass it on
			if ( '3' != $atts['quantity'] ) :
				$atts['showposts'] = $atts['quantity'];
			endif;

			// if more tag is set add the filter
			if (false !== $more_tag ) :

				add_filter( 'excerpt_more', array( $this, 'ivycat_custom_excerpt_more' ) );
			endif;

			// if num words is set add the filter
			if ( false !==  $num_words ) :

				add_filter( 'excerpt_length', array( $this, 'ivycat_custom_excerpt_length' ), 999 );
			endif;

			// call the class
			$new_output = new ICTestimonialPosts( $atts );

			// display loop in our page/post
			return $new_output->output_testimonials();
		endif;

		if ( 'yes' == $ajax_on ):
			wp_enqueue_script( 'ict-ajax-scripts' );
			wp_localize_script( 'ict-ajax-scripts', 'ICTaconn',
				apply_filters( 'ICTaconn-variables', array(
					'ajaxurl'           => admin_url( 'admin-ajax.php' ),
					'themeurl'          => get_bloginfo( 'stylesheet_directory' ) . '/',
					'pluginurl'         => ICTESTI_URL,
					'ict_quantity'      => $quantity,
					'ict_group'         => $group,
					'num_words'         => $num_words,
					'more_tag'          => $more_tag,
					'all_title'         => $all_title,
					'all_url'           => $all_url,
					'fade_in'           => $fade_in,
					'fade_out'          => $fade_out,
					'speed'             => $speed,
					'link_testimonials' => $link_testimonials,
				) )
			);
		endif;
		$testimonial_id = ( 'yes' == $ajax_on ) ? 'ivycat-testimonial' : 'ivycat-testimonial-static';
		$contents       = '<div id="' . $testimonial_id . '">';
		$contents       .= ( $title ) ? '<h3>' . $title . '</h3>' : '';
		$contents       .= '<blockquote class="testimonial-content">
			<div class="ict-content">' . $testimonials[0]['testimonial_content'] . '</div>
			<footer>
				<cite>';
		$contents       .= ( $link_testimonials )
			? '<a href="' . $testimonials[0]['testimonial_link'] . '">' . $testimonials[0]['testimonial_title'] . '</a>'
			: $testimonials[0]['testimonial_title'];
		$contents       .= '</cite>
			</footer>';
		$contents       .= ( strlen( $all_url ) > 1 ) ? '<p><a href="' . $all_url . '">' . $all_title . '</a></p>' : '';
		$contents       .= '</blockquote>';
		$contents       .= '</div>';

		return apply_filters( 'ic_testimonials_contents', $contents );
	}

	public function more_testimonials() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		$quantity     = absint( $_POST['ict_quantity'] );

		$group        = $_POST['ict_group'];

		$num_words    = absint( $_POST['num_words'] );

		$more_tag     = $_POST['more_tag'];

		$testimonials = $this->get_testimonials( $quantity, $group, $num_words, $more_tag, 'yes', $_POST['link_testimonials'] );

		if ( $testimonials ) {
			echo json_encode( $testimonials );
		}
		wp_die();
	}

	public function get_testimonials( $quantity, $group, $num_words, $more_tag, $ajax_on, $link_testimonials ) {
		$args = array(
			'post_type'      => 'testimonials',
			'orderby'        => ( 'yes' == $ajax_on ) ? 'meta_value_num' : 'rand',
			'meta_key'       => 'ivycat_testimonial_order',

			'order'          => 'ASC',
			'posts_per_page' => $quantity,
		);

		if ( $group ) {
			$args['tax_query'] = array(

				array(
					'taxonomy' => 'testimonial-group',
					'field'    => is_numeric( $group ) ? 'id' : 'slug',
					'terms'    => $group

				)

			);
		}

		$more             = ( $more_tag ) ? $more_tag : 'Read More';
		$testimonials     = get_posts( $args );
		$testimonial_data = array();
		do_action( 'ica_pre_loop_testimonials', $testimonials );
		if ( $testimonials ) {
			foreach ( $testimonials as $row ) {

				$post_more    = ( $more_tag ) ? ' <a class="ict-rm-link" href="' . home_url( '/testimonials/' . $row->post_name . '/' ) . '">' . $more . '</a>' : '';
				$post_content = ( $num_words ) ?
					wp_trim_words( $row->post_content, $num_words, $post_more )
					: $row->post_content;

				$testimonial_data[] = array(
					'testimonial_id'      => $row->ID,
					'testimonial_title'   => $row->post_title,
					'testimonial_link'    => ( $link_testimonials ) ? get_permalink( $row->ID ) : false,
					'testimonial_content' => ( strlen( $row->post_excerpt ) > 1 )
						? $row->post_excerpt
						: apply_filters( 'the_content', $post_content )
				);
			}
		}

		return apply_filters( 'ic_testimonials_data_array', $testimonial_data );
	}

	public function ivycat_custom_excerpt_more( $more ) {

		$more_tag = $this->more_tag;

		return ' <a class="read-more" href="' . get_permalink( get_the_ID() ) . '">' . $more_tag . '</a>';
	}

	public function ivycat_custom_excerpt_length( $length ) {

		$num_words = $this->num_words;

		return $num_words;
	}
}


Push — development ( 4ee6a1...22da9f )

ivycat-ajax-testimonials.php (39 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2017-07-09 22:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 22 and the first side effect is on line 30. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			* @package IvyCat AJAX Testimonials
4			* @author Eric Amundson <[email protected]>
5			* @copyright 2017 IvyCat, Inc.
6			* @license GPL-2.0+
7			*
8			* @wordpress-plugin
9			* Plugin Name: IvyCat AJAX Testimonials
10			* Plugin URI: https://ivycat.com/wordpress/wordpress-plugins/ivycat-ajax-testimonials/
11			* Description: Simply add dynamic testimonials to your site.
12			* Author: IvyCat, Inc.
13			* Author URI: https://ivycat.com
14			* Version: 1.5.2
15			* Text Domain: ivycat-ajax-testimonials
16			* Domain Path: /languages
17			* License: GPL-2.0+
18			* License URI: http://www.gnu.org/licenses/gpl-2.0.txt
19			*/
20
21			if ( ! defined( 'ICTESTI_DIR' ) ) {
22			define( 'ICTESTI_DIR', plugin_dir_path( __FILE__ ) );
23			}
24			if ( ! defined( 'ICTESTI_URL' ) ) {
25			define( 'ICTESTI_URL', plugin_dir_url( __FILE__ ) );
26			}
27
28			// Load the class for displaying testimonials_in_page
29			if ( ! class_exists( 'ICTestimonialPosts' ) ) {
30			require_once( 'lib/IvyCatTestimonialsPosts.php' );
31			}
32
33			$GLOBALS['ivycat_testimonials'] = new IvyCatTestimonials();
34			add_action( 'plugins_loaded', array( $GLOBALS['ivycat_testimonials'], 'start' ) );
35			load_plugin_textdomain( 'ivycat-ajax-testimonials', false, dirname( plugin_basename( __FILE__ ) ) . '/languages' );
36
37			class IvyCatTestimonials {
38
39			public $more_tag;

ivycat / ivycat-ajax-testimonials

Push — development ( 4ee6a1...22da9f )

ivycat-ajax-testimonials.php (39 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like