TimeProfilerSubscriber

Complexity

Total Complexity

5

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	3
Bugs	1	Features	2

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getSubscribedEvents()	0	7	1
A	start()	0	4	1
A	stop()	0	4	1
A	getProfiledTimestamp()	0	7	2

<?php
use ivol\EventDispatcher\AfterExecuteEvent;
use ivol\EventDispatcher\BeforeExecuteEvent;
use ivol\ExecParams;
use ivol\ExecutionWrapper;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;

class ExecutionWrapperIntegrationTest extends PHPUnit_Framework_TestCase

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public function testExecuteSubscriber()
    {
        $sut = new ExecutionWrapper();
        $profiler = new TimeProfilerSubscriber();
        $sut->getEventDispatcher()->addSubscriber($profiler);

        $result = $sut->exec('echo %s', array("'123'"));

$result is not used, you could remove the assignment.

        $this->assertTrue($profiler->getProfiledTimestamp() > 0);
    }

}

class TimeProfilerSubscriber implements EventSubscriberInterface

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /** @var float  */
    private $startTime = -1;
    /** @var float  */
    private $profiledTime = -1;
    
    /**
     * Returns an array of event names this subscriber wants to listen to.
     *
     * The array keys are event names and the value can be:
     *
     *  * The method name to call (priority defaults to 0)
     *  * An array composed of the method name to call and the priority
     *  * An array of arrays composed of the method names to call and respective
     *    priorities, or 0 if unset
     *
     * For instance:
     *
     *  * array('eventName' => 'methodName')
     *  * array('eventName' => array('methodName', $priority))
     *  * array('eventName' => array(array('methodName1', $priority), array('methodName2')))
     *
     * @return array The event names to listen to
     */
    public static function getSubscribedEvents()
    {
        return array(
            BeforeExecuteEvent::EVENT_NAME => 'start',
            AfterExecuteEvent::EVENT_NAME => 'stop'
        );
    }

    public function start(BeforeExecuteEvent $event)

The parameter $event is not used and could be removed.

    {
        $this->startTime = microtime(true);
    }

    public function stop(AfterExecuteEvent $event)

The parameter $event is not used and could be removed.

    {
        $this->profiledTime = microtime(true) - $this->startTime;
    }

    public function getProfiledTimestamp()
    {
        if ($this->profiledTime < 0) {
            throw new RuntimeException('Profiling not started yet');
        }
        return $this->profiledTime;
    }
}