ExecutionWrapperTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	3
Bugs	1	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	4	1
A	testExecuteReturnsResult()	0	7	1
A	testExecuteEscapesDataByDefault()	0	8	1
A	testExecuteDoesntEscapesCmdWithConfig()	0	8	1
A	testExecuteNotifyBeforeAndAfterExecute()	0	15	1

<?php

use Composer\EventDispatcher\Event;
use ivol\Config\ConfigurationFactory;
use ivol\EventDispatcher\AfterExecuteEvent;
use ivol\EventDispatcher\BeforeExecuteEvent;
use ivol\ExecParams;
use ivol\ExecutionWrapper;
use ivol\Result;

class ExecutionWrapperTest extends PHPUnit_Framework_TestCase

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /** @var ExecutionWrapper */
    private $sut;

    protected function setUp()
    {
        $this->sut = new ExecutionWrapper();
    }

    public function testExecuteReturnsResult()
    {
        $result = $this->sut->exec('echo %s', array('123'));

        $this->assertEquals(0, $result->getReturnCode());
        $this->assertEquals('123', $result->getOutput());
    }

    public function testExecuteEscapesDataByDefault()
    {
        $this->sut = new ExecutionWrapper();
        $result = $this->sut->exec('echo ? %s', array("'"));

        $this->assertEquals(0, $result->getReturnCode());
        $this->assertEquals("? \'", $result->getOutput());
    }

    public function testExecuteDoesntEscapesCmdWithConfig()
    {
        $this->sut = new ExecutionWrapper(['escape_shell_cmd' => false]);
        $result = $this->sut->exec('echo ? %s', array("'"));

        $this->assertEquals(0, $result->getReturnCode());
        $this->assertEquals("? '", $result->getOutput());
    }

    public function testExecuteNotifyBeforeAndAfterExecute()
    {
        $eventListener = new TestListener();
        $this->sut->getEventDispatcher()->addListener(BeforeExecuteEvent::EVENT_NAME, array($eventListener, 'before'));
        $this->sut->getEventDispatcher()->addListener(AfterExecuteEvent::EVENT_NAME, array($eventListener, 'after'));

        $this->sut->exec('echo %s', array('123'));

        $actualEvents = $eventListener->getEvents();
        $this->assertCount(2, $actualEvents);
        $this->assertInstanceOf('ivol\EventDispatcher\BeforeExecuteEvent', $actualEvents[0]);
        $this->assertEquals(new ExecParams('echo %s', array('123')), $actualEvents[0]->getParams());
        $this->assertInstanceOf('ivol\EventDispatcher\AfterExecuteEvent', $actualEvents[1]);
        $this->assertEquals(new Result(0 , array('123')), $actualEvents[1]->getResult());

Space found before comma in function call

    }
}

class TestListener

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var Event[]
     */
    private $events = array();

    public function before(BeforeExecuteEvent $event) {
        $this->events[] = $event;
    }

    public function after(AfterExecuteEvent $event) {
        $this->events[] = $event;
    }

    /**
     * @return \Composer\EventDispatcher\Event[]
     */
    public function getEvents()
    {
        return $this->events;
    }
}