Issues in ContentControllerTest.php (master) - Issues in master - ivoaz/content-editable-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (31)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Tests/Controller/ContentControllerTest.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the Ivoaz ContentEditable bundle.
 *
 * (c) Ivo Azirjans <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Ivoaz\Bundle\ContentEditableBundle\Tests\Controller;

use Ivoaz\Bundle\ContentEditableBundle\Controller\ContentController;
use Ivoaz\Bundle\ContentEditableBundle\Model\Content;
use Ivoaz\Bundle\ContentEditableBundle\Form\Model\Batch;
use Ivoaz\Bundle\ContentEditableBundle\Form\Model\BatchContent;
use Ivoaz\Bundle\ContentEditableBundle\Form\Model\Content as FormContent;
use Ivoaz\Bundle\ContentEditableBundle\Manager\ContentManagerInterface;
use Symfony\Component\Form\FormError;
use Symfony\Component\Form\FormFactoryInterface;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
use Symfony\Component\Validator\ConstraintViolation;

class ContentControllerTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var ContentManagerInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    private $manager;

    /**
     * @var FormFactoryInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    private $formFactory;

    /**
     * @var FormInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    private $form;

    /**
     * @var AuthorizationCheckerInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    private $authorizationChecker;

    /**
     * @var ContentController
     */
    private $controller;

    public function setUp()
    {
        $this->manager = $this->getMock(ContentManagerInterface::class);

        $this->form = $this->getMock(FormInterface::class);

        $this->formFactory = $this->getMock(FormFactoryInterface::class);

        $this->formFactory->method('create')
            ->willReturn($this->form);
        $this->authorizationChecker = $this->getMock(AuthorizationCheckerInterface::class);


        $this->controller = new ContentController($this->manager, $this->formFactory, $this->authorizationChecker);
    }

    public function testUpdateActionReturnsErrorWhenContentNotFound()
    {
        $this->setAuthorized(true);

        $this->manager->method('find')
            ->with(1)
            ->willReturn(null);

        $request = new Request([], [], ['id' => 1]);
        $response = $this->controller->updateAction($request);

        $expectedResponse = new JsonResponse(
            ['errors' => [['title' => sprintf('Content with id "1" was not found.')]]],
            400
        );

        $this->assertEquals($expectedResponse, $response);
    }

    public function testUpdateActionReturnsFormErrors()
    {
        $this->setAuthorized(true);

        $content = new Content();

        $this->manager->method('find')
            ->with(1)
            ->willReturn($content);

        $this->form->method('isValid')
            ->willReturn(false);

        $this->form->method('getErrors')
            ->with(true, true)
            ->willReturn($this->getMultipleErrors());

        $request = new Request([], [], ['id' => 1]);
        $response = $this->controller->updateAction($request);

        $this->assertEquals($this->getMultipleErrorResponse(), $response);
    }

    public function testUpdateActionUpdatesContent()
    {
        $this->setAuthorized(true);

        $content = new Content();

        $this->manager->method('find')
            ->with(1)
            ->willReturn($content);

        $this->form->method('isValid')
            ->willReturn(true);

        $this->form->method('getData')
            ->willReturn(new FormContent());

        $this->manager->expects($this->once())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('update')
            ->with($content);

        $request = new Request([], [], ['id' => 1]);
        $response = $this->controller->updateAction($request);

        $expectedResponse = new JsonResponse(null, JsonResponse::HTTP_NO_CONTENT);

        $this->assertEquals($expectedResponse, $response);
    }

    public function testBatchUpdateActionReturnsErrorWhenContentNotFound()
    {
        $this->setAuthorized(true);

        $this->form->method('isValid')
            ->willReturn(true);

        $this->form->method('getData')
            ->willReturn($this->getBatch());

        $this->manager->method('find')
            ->willReturn(null);

        $response = $this->controller->batchUpdateAction(new Request());

        $expectedResponse = new JsonResponse(
            [
                'errors' => [
                    ['title' => 'Content with id "1" was not found.'],
                    ['title' => 'Content with id "2" was not found.'],
                ],
            ],
            400
        );

        $this->assertEquals($expectedResponse, $response);
    }

    public function testBatchUpdateActionReturnsFormErrors()
    {
        $this->setAuthorized(true);

        $this->form->method('isValid')
            ->willReturn(false);

        $this->form->method('getErrors')
            ->with(true, true)
            ->willReturn($this->getMultipleErrors());

        $response = $this->controller->batchUpdateAction(new Request());

        $this->assertEquals($this->getMultipleErrorResponse(), $response);
    }

    public function testBatchUpdateActionUpdatesContent()
    {
        $this->setAuthorized(true);

        $content1 = new Content();
        $content2 = new Content();

        $this->manager->method('find')
            ->will($this->returnValueMap([[1, $content1], [2, $content2]]));

        $this->form->method('isValid')
            ->willReturn(true);

        $this->form->method('getData')
            ->willReturn($this->getBatch());

        $this->manager->expects($this->exactly(2))
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('update')
            ->withConsecutive([$content1], [$content2]);

        $response = $this->controller->batchUpdateAction(new Request());

        $expectedResponse = new JsonResponse(null, JsonResponse::HTTP_NO_CONTENT);

        $this->assertEquals($expectedResponse, $response);
    }

    /**
     * @dataProvider getActionIsForbiddenTestData
     *
     * @param string $method
     */
    public function testActionIsForbidden($method)
    {
        $this->setAuthorized(false);

        $response = call_user_func([$this->controller, $method], new Request());
        $expectedResponse = new JsonResponse(null, JsonResponse::HTTP_FORBIDDEN);

        $this->assertEquals($expectedResponse, $response, sprintf('Action "%s" should be forbidden.', $method));
    }

    /**
     * @return array
     */
    public function getActionIsForbiddenTestData()
    {
        return [['updateAction'], ['batchUpdateAction']];
    }

    /**
     * @param bool $authorized
     */
    private function setAuthorized($authorized)
    {
        $this->authorizationChecker->method('isGranted')
            ->with('ROLE_ADMIN')
            ->willReturn($authorized);
    }

    /**
     * @return Batch
     */
    private function getBatch()
    {
        $batch = new Batch();
        $batch->contents[] = new BatchContent();
        $batch->contents[] = new BatchContent();
        $batch->contents[0]->id = 1;
        $batch->contents[1]->id = 2;
        $batch->contents[0]->text = 'Text 1';
        $batch->contents[1]->text = 'Text 2';

        return $batch;
    }

    /**
     * @return array
     */
    private function getMultipleErrors()
    {
        $errors = [
            new FormError(
                'Test error1',
                null,
                [],
                null,
                new ConstraintViolation('', '', [], null, 'field1', null)
            ),
            new FormError(
                'Test error2',
                null,
                [],
                null,
                new ConstraintViolation('', '', [], null, 'field2', null)
            ),
        ];

        return $errors;
    }

    /**
     * @return JsonResponse
     */
    private function getMultipleErrorResponse()
    {
        $response = new JsonResponse(
            [
                'errors' => [
                    ['field' => 'field1', 'title' => 'Test error1'],
                    ['field' => 'field2', 'title' => 'Test error2'],
                ],
            ],
            400
        );

        return $response;
    }
}


Issues (31)

Security Analysis not enabled

Tests/Controller/ContentControllerTest.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

1			<?php
2
3			/*
4			* This file is part of the Ivoaz ContentEditable bundle.
5			*
6			* (c) Ivo Azirjans <[email protected]>
7			*
8			* This source file is subject to the MIT license that is bundled
9			* with this source code in the file LICENSE.
10			*/
11
12			namespace Ivoaz\Bundle\ContentEditableBundle\Tests\Controller;
13
14			use Ivoaz\Bundle\ContentEditableBundle\Controller\ContentController;
15			use Ivoaz\Bundle\ContentEditableBundle\Model\Content;
16			use Ivoaz\Bundle\ContentEditableBundle\Form\Model\Batch;
17			use Ivoaz\Bundle\ContentEditableBundle\Form\Model\BatchContent;
18			use Ivoaz\Bundle\ContentEditableBundle\Form\Model\Content as FormContent;
19			use Ivoaz\Bundle\ContentEditableBundle\Manager\ContentManagerInterface;
20			use Symfony\Component\Form\FormError;
21			use Symfony\Component\Form\FormFactoryInterface;
22			use Symfony\Component\Form\FormInterface;
23			use Symfony\Component\HttpFoundation\JsonResponse;
24			use Symfony\Component\HttpFoundation\Request;
25			use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
26			use Symfony\Component\Validator\ConstraintViolation;
27
28			class ContentControllerTest extends \PHPUnit_Framework_TestCase
29			{
30			/**
31			* @var ContentManagerInterface\|\PHPUnit_Framework_MockObject_MockObject
32			*/
33			private $manager;
34
35			/**
36			* @var FormFactoryInterface\|\PHPUnit_Framework_MockObject_MockObject
37			*/
38			private $formFactory;
39
40			/**
41			* @var FormInterface\|\PHPUnit_Framework_MockObject_MockObject
42			*/
43			private $form;
44
45			/**
46			* @var AuthorizationCheckerInterface\|\PHPUnit_Framework_MockObject_MockObject
47			*/
48			private $authorizationChecker;
49
50			/**
51			* @var ContentController
52			*/
53			private $controller;
54
55			public function setUp()
56			{
57			$this->manager = $this->getMock(ContentManagerInterface::class);
			0 ignored issues – show Deprecated Code introduced 2016-09-30 13:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
58			$this->form = $this->getMock(FormInterface::class);
			0 ignored issues – show Deprecated Code introduced 2016-09-30 13:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
59			$this->formFactory = $this->getMock(FormFactoryInterface::class);
			0 ignored issues – show Deprecated Code introduced 2016-09-30 13:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
60			$this->formFactory->method('create')
61			->willReturn($this->form);
62			$this->authorizationChecker = $this->getMock(AuthorizationCheckerInterface::class);
			0 ignored issues – show Deprecated Code introduced 2016-09-30 13:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
63
64			$this->controller = new ContentController($this->manager, $this->formFactory, $this->authorizationChecker);
65			}
66
67			public function testUpdateActionReturnsErrorWhenContentNotFound()
68			{
69			$this->setAuthorized(true);
70
71			$this->manager->method('find')
72			->with(1)
73			->willReturn(null);
74
75			$request = new Request([], [], ['id' => 1]);
76			$response = $this->controller->updateAction($request);
77
78			$expectedResponse = new JsonResponse(
79			['errors' => [['title' => sprintf('Content with id "1" was not found.')]]],
80			400
81			);
82
83			$this->assertEquals($expectedResponse, $response);
84			}
85
86			public function testUpdateActionReturnsFormErrors()
87			{
88			$this->setAuthorized(true);
89
90			$content = new Content();
91
92			$this->manager->method('find')
93			->with(1)
94			->willReturn($content);
95
96			$this->form->method('isValid')
97			->willReturn(false);
98
99			$this->form->method('getErrors')
100			->with(true, true)
101			->willReturn($this->getMultipleErrors());
102
103			$request = new Request([], [], ['id' => 1]);
104			$response = $this->controller->updateAction($request);
105
106			$this->assertEquals($this->getMultipleErrorResponse(), $response);
107			}
108
109			public function testUpdateActionUpdatesContent()
110			{
111			$this->setAuthorized(true);
112
113			$content = new Content();
114
115			$this->manager->method('find')
116			->with(1)
117			->willReturn($content);
118
119			$this->form->method('isValid')
120			->willReturn(true);
121
122			$this->form->method('getData')
123			->willReturn(new FormContent());
124
125			$this->manager->expects($this->once())
			0 ignored issues – show Bug introduced 2016-09-30 13:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Ivoaz\Bundle\ContentEdit...ContentManagerInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
126			->method('update')
127			->with($content);
128
129			$request = new Request([], [], ['id' => 1]);
130			$response = $this->controller->updateAction($request);
131
132			$expectedResponse = new JsonResponse(null, JsonResponse::HTTP_NO_CONTENT);
133
134			$this->assertEquals($expectedResponse, $response);
135			}
136
137			public function testBatchUpdateActionReturnsErrorWhenContentNotFound()
138			{
139			$this->setAuthorized(true);
140
141			$this->form->method('isValid')
142			->willReturn(true);
143
144			$this->form->method('getData')
145			->willReturn($this->getBatch());
146
147			$this->manager->method('find')
148			->willReturn(null);
149
150			$response = $this->controller->batchUpdateAction(new Request());
151
152			$expectedResponse = new JsonResponse(
153			[
154			'errors' => [
155			['title' => 'Content with id "1" was not found.'],
156			['title' => 'Content with id "2" was not found.'],
157			],
158			],
159			400
160			);
161
162			$this->assertEquals($expectedResponse, $response);
163			}
164
165			public function testBatchUpdateActionReturnsFormErrors()
166			{
167			$this->setAuthorized(true);
168
169			$this->form->method('isValid')
170			->willReturn(false);
171
172			$this->form->method('getErrors')
173			->with(true, true)
174			->willReturn($this->getMultipleErrors());
175
176			$response = $this->controller->batchUpdateAction(new Request());
177
178			$this->assertEquals($this->getMultipleErrorResponse(), $response);
179			}
180
181			public function testBatchUpdateActionUpdatesContent()
182			{
183			$this->setAuthorized(true);
184
185			$content1 = new Content();
186			$content2 = new Content();
187
188			$this->manager->method('find')
189			->will($this->returnValueMap([[1, $content1], [2, $content2]]));
190
191			$this->form->method('isValid')
192			->willReturn(true);
193
194			$this->form->method('getData')
195			->willReturn($this->getBatch());
196
197			$this->manager->expects($this->exactly(2))
			0 ignored issues – show Bug introduced 2016-09-30 13:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Ivoaz\Bundle\ContentEdit...ContentManagerInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
198			->method('update')
199			->withConsecutive([$content1], [$content2]);
200
201			$response = $this->controller->batchUpdateAction(new Request());
202
203			$expectedResponse = new JsonResponse(null, JsonResponse::HTTP_NO_CONTENT);
204
205			$this->assertEquals($expectedResponse, $response);
206			}
207
208			/**
209			* @dataProvider getActionIsForbiddenTestData
210			*
211			* @param string $method
212			*/
213			public function testActionIsForbidden($method)
214			{
215			$this->setAuthorized(false);
216
217			$response = call_user_func([$this->controller, $method], new Request());
218			$expectedResponse = new JsonResponse(null, JsonResponse::HTTP_FORBIDDEN);
219
220			$this->assertEquals($expectedResponse, $response, sprintf('Action "%s" should be forbidden.', $method));
221			}
222
223			/**
224			* @return array
225			*/
226			public function getActionIsForbiddenTestData()
227			{
228			return [['updateAction'], ['batchUpdateAction']];
229			}
230
231			/**
232			* @param bool $authorized
233			*/
234			private function setAuthorized($authorized)
235			{
236			$this->authorizationChecker->method('isGranted')
237			->with('ROLE_ADMIN')
238			->willReturn($authorized);
239			}
240
241			/**
242			* @return Batch
243			*/
244			private function getBatch()
245			{
246			$batch = new Batch();
247			$batch->contents[] = new BatchContent();
248			$batch->contents[] = new BatchContent();
249			$batch->contents[0]->id = 1;
250			$batch->contents[1]->id = 2;
251			$batch->contents[0]->text = 'Text 1';
252			$batch->contents[1]->text = 'Text 2';
253
254			return $batch;
255			}
256
257			/**
258			* @return array
259			*/
260			private function getMultipleErrors()
261			{
262			$errors = [
263			new FormError(
264			'Test error1',
265			null,
266			[],
267			null,
268			new ConstraintViolation('', '', [], null, 'field1', null)
269			),
270			new FormError(
271			'Test error2',
272			null,
273			[],
274			null,
275			new ConstraintViolation('', '', [], null, 'field2', null)
276			),
277			];
278
279			return $errors;
280			}
281
282			/**
283			* @return JsonResponse
284			*/
285			private function getMultipleErrorResponse()
286			{
287			$response = new JsonResponse(
288			[
289			'errors' => [
290			['field' => 'field1', 'title' => 'Test error1'],
291			['field' => 'field2', 'title' => 'Test error2'],
292			],
293			],
294			400
295			);
296
297			return $response;
298			}
299			}
300

ivoaz / content-editable-bundle

Issues (31)

Security Analysis not enabled

Tests/Controller/ContentControllerTest.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like