Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
14 | View Code Duplication | class SitemapArticle extends Article implements Basic |
|
|
|||
15 | { |
||
16 | /** |
||
17 | * Handle materials by selecting batch of elements. |
||
18 | * Increase this value and got more handling speed but more memory usage. |
||
19 | * |
||
20 | * @var int |
||
21 | */ |
||
22 | public $sitemapBatchSize = 10; |
||
23 | |||
24 | /** |
||
25 | * @inheritdoc |
||
26 | */ |
||
27 | public function getSitemapItems($lang = null) |
||
31 | |||
32 | /** |
||
33 | * @inheritdoc |
||
34 | */ |
||
35 | public function getSitemapItemsQuery($lang = null) |
||
43 | |||
44 | /** |
||
45 | * @inheritdoc |
||
46 | */ |
||
47 | public function getSitemapLoc($lang = null) |
||
51 | |||
52 | /** |
||
53 | * @inheritdoc |
||
54 | */ |
||
55 | public function getSitemapLastmod($lang = null) |
||
61 | |||
62 | /** |
||
63 | * @inheritdoc |
||
64 | */ |
||
65 | public function getSitemapChangefreq($lang = null) |
||
69 | |||
70 | /** |
||
71 | * @inheritdoc |
||
72 | */ |
||
73 | public function getSitemapPriority($lang = null) |
||
77 | } |
||
78 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.