app\controllers\admin\BaseUserController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	6	1
A	getSearchModelName()	0	3	1
A	getAdditionFields()	0	10	3
A	getModelName()	0	3	1

<?php

namespace app\controllers\admin;

use Yii;
use yii\base\InvalidConfigException;
use app\components\UserValidateComponent;
use app\interfaces\UserValidateComponentInterface;
use app\traits\AccessTrait;
use app\models\Position;
use Itstructure\AdminModule\controllers\CommonAdminController;

/**
 * Class BaseUserController
 * BaseUserController implements the CRUD actions for identityClass.
 *
 * @property UserValidateComponentInterface|UserValidateComponent $validateComponent Validate component.
 *
 * @package app\controllers\admin
 */
class BaseUserController extends CommonAdminController
{
    use AccessTrait;

The trait app\traits\AccessTrait requires the property $user which is not provided by app\controllers\admin\BaseUserController.

    /**
     * Initialize.
     * Set validateComponent and additionFields.
     */
    public function init()
    {
        $this->validateComponent = Yii::$app->get('user-validate');

It seems like Yii::app->get('user-validate') can also be of type mixed. However, the property $validateComponent is declared as type app\components\UserValidateComponent|app\interfaces\UserValidateComponentInterface. Maybe add an additional type check?

        $this->validateComponent->changeRoles = $this->checkAccessToSetRoles();

        parent::init();
    }

    /**
     * Returns addition fields.
     *
     * @throws InvalidConfigException
     *
     * @return array
     */
    protected function getAdditionFields(): array
    {
        $additionFields = [];

        if ($this->action->id == 'create' || $this->action->id == 'update') {
            $additionFields['roles'] = $this->validateComponent->getAuthManager()->getRoles();
            $additionFields['positions'] = Position::getPositions();
        }

        return $additionFields;
    }

    /**
     * Returns identityClass model name.
     *
     * @return string
     */
    protected function getModelName():string
    {
        return \Yii::$app->user->identityClass;
    }

    /**
     * Returns identityClass Search model name.
     *
     * @return string
     */
    protected function getSearchModelName():string
    {
        return \Yii::$app->user->identityClass . 'Search';
    }
}