app\controllers\ArticleController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	actionView()	0	19	2
A	behaviors()	0	17	1

<?php

namespace app\controllers;

use yii\web\NotFoundHttpException;
use yii\filters\{AccessControl, VerbFilter};
use yii\helpers\ArrayHelper;
use Itstructure\MFUploader\models\OwnerMediafile;
use app\models\Article;

/**
 * Class ArticleController
 *
 * @package app\controllers
 */
class ArticleController extends BaseController
{
    /**
     * @return array
     */
    public function behaviors()
    {
        return ArrayHelper::merge(parent::behaviors(), [
            'access' => [
                'class' => AccessControl::class,
                'rules' => [
                    [
                        'allow' => true,
                        'actions' => ['view'],
                        'roles' => ['?', '@'],
                    ],
                ],
            ],
            'verbs' => [
                'class' => VerbFilter::class,
                'actions' => [
                    'view' => ['get'],
                ],
            ],
        ]);
    }

    /**
     * Displays article page.
     *
     * @return string
     *
     * @throws NotFoundHttpException
     */
    public function actionView($alias)
    {
        $model = Article::find()->where([
            'alias' => $alias
        ])->andWhere([
            'active' => 1
        ])->one();

        if (null === $model) {
            throw new NotFoundHttpException('Article not fount with alias = '.$alias.'.');
        }

        $this->setMetaParams($model);

It seems like $model can also be of type array; however, parameter $model of app\controllers\BaseController::setMetaParams() does only seem to accept null|yii\db\ActiveRecord, maybe add an additional type check?

        $images = OwnerMediafile::getImageFiles(Article::tableName(), $model->id);

It seems like $model->id can also be of type null; however, parameter $ownerId of Itstructure\MFUploader\models\OwnerMediafile::getImageFiles() does only seem to accept integer, maybe add an additional type check?

        return $this->render('view', [
            'model' => $model,
            'images' => $images
        ]);
    }
}