itstructure / yii2-template-multilanguage

traits/AdminBeforeActionTrait.php

<?php

namespace app\traits;

use Yii;
use yii\helpers\ArrayHelper;
use app\helpers\BaseHelper;
use Itstructure\AdminModule\models\Language;
use Itstructure\AdminModule\components\AdminView;

/**
 * Class AdminBeforeActionTrait
 *
 * @property AdminView $view
 * @property string $shortLanguage
 * @property Language[] $languages
 *
 * @package app\traits
 */
trait AdminBeforeActionTrait
{
    /**
     * @var array
     */
    private $neighborControllers = [
        'profiles' => 'roles',
        'roles' => 'permissions',
    ];

    /**
     * @param \yii\base\Action $action
     *
     * @return bool
     */
    public function beforeAction($action)
    {
        $this->view->mainMenuConfig = require __DIR__ . '/../config/admin/main-menu.php';

        $this->view->homeUrl = '/' . $this->shortLanguage . '/admin';

        $this->view->signOutLink = '/' . $this->shortLanguage . '/logout';

        $this->view->profileLink = '/' . $this->shortLanguage . '/admin/users/view?id='.Yii::$app->getUser()->id;

        Yii::$app->getUser()->loginUrl = '/' . $this->shortLanguage . '/login';

        $this->urlPrefix = '/' . $this->shortLanguage . '/' . $this->module->id . '/' . $action->controller->id . '/';

The property urlPrefix does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        if (array_key_exists($action->controller->id, $this->neighborControllers)) {
            $this->urlPrefixNeighbor = '/' . $this->shortLanguage . '/' . $this->module->id . '/' .

The property urlPrefixNeighbor does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                $this->neighborControllers[$action->controller->id] . '/';
        }

        $this->view->userBody = ArrayHelper::map($this->languages, 'name', function ($item) {
            /* @var Language $item */
            return BaseHelper::getSwitchLanguageLink($item->getShortName(), Yii::$app->request);

It seems like Yii::app->request can also be of type yii\console\Request; however, parameter $request of app\helpers\BaseHelper::getSwitchLanguageLink() does only seem to accept yii\web\Request, maybe add an additional type check?

        });

        return parent::beforeAction($action);
    }
}