itstructure / yii2-template-multilanguage

controllers/ContactController.php

<?php

namespace app\controllers;

use Yii;
use yii\filters\{AccessControl, VerbFilter};
use yii\helpers\ArrayHelper;
use yii\web\NotFoundHttpException;
use app\models\{Contact, Feedback};

/**
 * Class ContactController
 *
 * @package app\controllers
 */
class ContactController extends BaseController
{
    /**
     * @return array
     */
    public function behaviors()
    {
        return ArrayHelper::merge(parent::behaviors(), [
            'access' => [
                'class' => AccessControl::class,
                'rules' => [
                    [
                        'allow' => true,
                        'actions' => ['index', 'captcha'],
                        'roles' => ['?', '@'],
                    ],
                ],
            ],
            'verbs' => [
                'class' => VerbFilter::class,
                'actions' => [
                    'index' => ['get', 'post'],
                    'captcha' => ['get'],
                ],
            ],
        ]);
    }

    public function actions()
    {
        return ArrayHelper::merge(parent::actions(), [
            'captcha' => [
                'class' => 'yii\captcha\CaptchaAction',
                'fixedVerifyCode' => YII_ENV_TEST ? 'testme' : null,
            ],
        ]);
    }

    /**
     * Displays contacts page.
     *
     * @return string
     *
     * @throws NotFoundHttpException
     */
    public function actionIndex()
    {
        $feedback = new Feedback();
        $feedback->setScenario(Feedback::SCENARIO_CONTACT);

        if ($feedback->load(Yii::$app->request->post()) && $feedback->contact(Yii::$app->params['adminEmail'])) {

It seems like Yii::app->request->post() can also be of type object; however, parameter $data of yii\base\Model::load() does only seem to accept array, maybe add an additional type check?

            Yii::$app->session->setFlash('contactFormSubmitted');

The method setFlash() does not exist on null.

            return $this->refresh();

The expression return $this->refresh() returns the type yii\web\Response which is incompatible with the documented return type string.

        }

        $model = Contact::getDefaultContacts();

        if (null === $model) {
            throw new NotFoundHttpException('Contacts not fount.');
        }

        $this->setMetaParams($model);

It seems like $model can also be of type array; however, parameter $model of app\controllers\BaseController::setMetaParams() does only seem to accept null|yii\db\ActiveRecord, maybe add an additional type check?

        return $this->render('index', [
            'model' => $model,
            'feedback' => $feedback
        ]);
    }
}