Category::rules() - Code Metrics - Inspection of "Upgrate packages for dashboard" - itstructure/yii2-template-multilanguage - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ad0383...5c48c0 )

by Andrey

created 2021-04-16 16:43 UTC

Category::rules() A

↳ Parent: Category

Complexity

Conditions	4
Paths	2

Size

Total Lines	55
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	29
c	1
b	0
f	0
nc	2
nop	0
dl	0
loc	55
rs	9.456

How to fix Long Method

<?php

namespace app\models;

use Yii;
use Itstructure\MultiLevelMenu\MenuWidget;
use Itstructure\AdminModule\models\{MultilanguageTrait, Language, ActiveRecord};
use Itstructure\AdminModule\interfaces\ModelInterface;

/**
 * This is the model class for table "categories".
 *
 * @property int $id
 * @property string $created_at
 * @property string $updated_at
 * @property int $parentId
 * @property string $icon
 * @property string $alias
 * @property int $active
 *
 * @property CategoryLanguage[] $categoriesLanguages
 * @property Language[] $languages
 *
 * @package app\models
 */
class Category extends ActiveRecord
{
    use MultilanguageTrait;


    /**
     * @inheritdoc
     */
    public static function tableName()
    {
        return 'categories';
    }

    /**
     * @inheritdoc
     */
    public function rules()
    {
        return [
            [
                [
                    'created_at',
                    'updated_at',
                ],
                'safe',
            ],
            [
                [
                    'active',
                ],
                'required',
            ],
            [
                [
                    'parentId',
                    'active'
                ],
                'integer',
            ],
            [
                [
                    'icon',
                    'alias',
                ],
                'string',
                'max' => 128,
            ],
            [
                'parentId',
                'filter',
                'filter' => function ($value) {
                    if (empty($value)) {
                        return null;
                    } else {
                        return MenuWidget::checkNewParentId($this, $value) ? $value : $this->getOldAttribute('parentId');
                    }
                }
            ],
            [
                'alias',
                'filter',
                'filter' => function ($value) {
                    return preg_replace( '/[^a-z0-9_]+/', '-', strtolower(trim($value)));
                }
            ],
            [
                'alias',
                'unique',
                'skipOnError'     => true,
                'targetClass'     => static::class,
                'filter' => $this->getScenario() == ModelInterface::SCENARIO_UPDATE ? 'id != '.$this->id : ''
            ],
        ];
    }

    /**
     * @return array
     */
    public function attributes(): array
    {
        return [
            'id',
            'parentId',
            'icon',
            'alias',
            'active',
            'created_at',
            'updated_at',
        ];
    }

    /**
     * @inheritdoc
     */
    public function attributeLabels()
    {
        return [
            'id' => 'ID',
            'parentId' => Yii::t('app', 'Parent object'),
            'icon' => Yii::t('app', 'Icon'),
            'active' => Yii::t('app', 'Active status'),
            'alias' => Yii::t('app', 'URL Alias'),
            'created_at' => Yii::t('app', 'Created date'),
            'updated_at' => Yii::t('app', 'Updated date'),
        ];
    }

    /**
     * Reassigning child objects to their new parent after delete the main model record.
     */
    public function afterDelete()
    {
        MenuWidget::afterDeleteMainModel($this);

        parent::afterDelete();
    }

    /**
     * @return array|\yii\db\ActiveRecord[]
     */
    public static function getMenu()
    {
        return static::find()->select([
            'id', 'parentId'
        ])->all();
    }

    /**
     * @return array|\yii\db\ActiveRecord[]
     */
    public static function getActiveMenu()
    {
        return static::find()->select([
            'id', 'parentId', 'alias'
        ])->where([
            'active' => 1
        ])->all();
    }

    /**
     * @return \yii\db\ActiveQuery
     */
    public function getCategoriesLanguages()
    {
        return $this->hasMany(CategoryLanguage::class, [
            'categories_id' => 'id'
        ]);
    }

    /**
     * @return \yii\db\ActiveQuery
     */
    public function getLanguages()
    {
        return $this->hasMany(Language::class, [
            'id' => 'language_id'
        ])->viaTable('categories_language', [
            'categories_id' => 'id'
        ]);
    }
}


1			<?php
2
3			namespace app\models;
4
5			use Yii;
6			use Itstructure\MultiLevelMenu\MenuWidget;
7			use Itstructure\AdminModule\models\{MultilanguageTrait, Language, ActiveRecord};
8			use Itstructure\AdminModule\interfaces\ModelInterface;
9
10			/**
11			* This is the model class for table "categories".
12			*
13			* @property int $id
14			* @property string $created_at
15			* @property string $updated_at
16			* @property int $parentId
17			* @property string $icon
18			* @property string $alias
19			* @property int $active
20			*
21			* @property CategoryLanguage[] $categoriesLanguages
22			* @property Language[] $languages
23			*
24			* @package app\models
25			*/
26			class Category extends ActiveRecord
27			{
28			use MultilanguageTrait;
			0 ignored issues – show introduced 2020-08-03 05:51 UTC by Report Bug Copy Issue Report The trait `Itstructure\AdminModule\models\MultilanguageTrait` requires some properties which are not provided by `app\models\Category`: `$language`, `$shortName` Loading history...
29
30			/**
31			* @inheritdoc
32			*/
33			public static function tableName()
34			{
35			return 'categories';
36			}
37
38			/**
39			* @inheritdoc
40			*/
41			public function rules()
42			{
43			return [
44			[
45			[
46			'created_at',
47			'updated_at',
48			],
49			'safe',
50			],
51			[
52			[
53			'active',
54			],
55			'required',
56			],
57			[
58			[
59			'parentId',
60			'active'
61			],
62			'integer',
63			],
64			[
65			[
66			'icon',
67			'alias',
68			],
69			'string',
70			'max' => 128,
71			],
72			[
73			'parentId',
74			'filter',
75			'filter' => function ($value) {
76			if (empty($value)) {
77			return null;
78			} else {
79			return MenuWidget::checkNewParentId($this, $value) ? $value : $this->getOldAttribute('parentId');
80			}
81			}
82			],
83			[
84			'alias',
85			'filter',
86			'filter' => function ($value) {
87			return preg_replace( '/[^a-z0-9_]+/', '-', strtolower(trim($value)));
88			}
89			],
90			[
91			'alias',
92			'unique',
93			'skipOnError' => true,
94			'targetClass' => static::class,
95			'filter' => $this->getScenario() == ModelInterface::SCENARIO_UPDATE ? 'id != '.$this->id : ''
96			],
97			];
98			}
99
100			/**
101			* @return array
102			*/
103			public function attributes(): array
104			{
105			return [
106			'id',
107			'parentId',
108			'icon',
109			'alias',
110			'active',
111			'created_at',
112			'updated_at',
113			];
114			}
115
116			/**
117			* @inheritdoc
118			*/
119			public function attributeLabels()
120			{
121			return [
122			'id' => 'ID',
123			'parentId' => Yii::t('app', 'Parent object'),
124			'icon' => Yii::t('app', 'Icon'),
125			'active' => Yii::t('app', 'Active status'),
126			'alias' => Yii::t('app', 'URL Alias'),
127			'created_at' => Yii::t('app', 'Created date'),
128			'updated_at' => Yii::t('app', 'Updated date'),
129			];
130			}
131
132			/**
133			* Reassigning child objects to their new parent after delete the main model record.
134			*/
135			public function afterDelete()
136			{
137			MenuWidget::afterDeleteMainModel($this);
138
139			parent::afterDelete();
140			}
141
142			/**
143			* @return array\|\yii\db\ActiveRecord[]
144			*/
145			public static function getMenu()
146			{
147			return static::find()->select([
148			'id', 'parentId'
149			])->all();
150			}
151
152			/**
153			* @return array\|\yii\db\ActiveRecord[]
154			*/
155			public static function getActiveMenu()
156			{
157			return static::find()->select([
158			'id', 'parentId', 'alias'
159			])->where([
160			'active' => 1
161			])->all();
162			}
163
164			/**
165			* @return \yii\db\ActiveQuery
166			*/
167			public function getCategoriesLanguages()
168			{
169			return $this->hasMany(CategoryLanguage::class, [
170			'categories_id' => 'id'
171			]);
172			}
173
174			/**
175			* @return \yii\db\ActiveQuery
176			*/
177			public function getLanguages()
178			{
179			return $this->hasMany(Language::class, [
180			'id' => 'language_id'
181			])->viaTable('categories_language', [
182			'categories_id' => 'id'
183			]);
184			}
185			}
186

itstructure / yii2-template-multilanguage

Push — master ( ad0383...5c48c0 )

Category::rules() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like