Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
16 | class SiteController extends BaseController |
||
17 | { |
||
18 | /** |
||
19 | * @inheritdoc |
||
20 | */ |
||
21 | public function behaviors() |
||
41 | |||
42 | /** |
||
43 | * @inheritdoc |
||
44 | */ |
||
45 | View Code Duplication | public function actions() |
|
54 | |||
55 | /** |
||
56 | * Login action. |
||
57 | * |
||
58 | * @return Response|string |
||
59 | */ |
||
60 | public function actionLogin() |
||
76 | |||
77 | /** |
||
78 | * Register action. |
||
79 | * |
||
80 | * @return Response|string |
||
81 | */ |
||
82 | public function actionReg() |
||
110 | |||
111 | /** |
||
112 | * Logout action. |
||
113 | * |
||
114 | * @return Response |
||
115 | */ |
||
116 | public function actionLogout() |
||
122 | } |
||
123 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.