Itstructure\RbacModule\models\Permission

Complexity

Total Complexity

12

Size/Duplication

Total Lines	143
Duplicated Lines	100 %

Coupling/Cohesion

Components	2
Dependencies	3

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	attributeLabels()	8	8	1
A	rules()	14	14	1
A	getCurrentChildren()	6	6	1
A	getNewChildren()	4	4	2
A	createItem()	4	4	1
A	createChild()	4	4	1
A	getOldName()	4	4	2
A	getItem()	4	4	1
A	setItemForInstance()	5	5	1
A	setChildrenForInstance()	5	5	1

<?php

namespace Itstructure\RbacModule\models;

use yii\helpers\ArrayHelper;
use yii\rbac\{Item, Permission as BasePermission, ManagerInterface};
use Itstructure\RbacModule\interfaces\ModelInterface;
use Itstructure\RbacModule\Module;

/**
 * Class Permission
 *
 * @property BasePermission $permission
 * @property array $permissions
 * @property ManagerInterface $authManager
 *
 * @package Itstructure\RbacModule\models
 */
class Permission extends Rbac implements ModelInterface

This class seems to be duplicated in your project.

{
    /**
     * Permission object.
     *
     * @var BasePermission
     */
    public $permission;

    /**
     * Child permissions.
     *
     * @var array
     */
    public $permissions = [];

    /**
     * Validate rules.
     *
     * @return array
     */
    public function rules()
    {
        return ArrayHelper::merge(
            parent::rules(),
            [
                [
                    [
                        'permissions',
                    ],
                    'safe',
                ],
            ]
        );
    }

    /**
     * @inheritdoc
     */
    public function attributeLabels()
    {
        return [
            'name' => Module::t('permissions', 'Name'),
            'description' => Module::t('permissions', 'Description'),
            'permissions' => Module::t('permissions', 'Permissions'),
        ];
    }

    /**
     * Get current child permissions assigned to current permission.
     *
     * @return \yii\rbac\Permission[]
     */
    protected function getCurrentChildren(): array
    {
        $permissions = $this->authManager->getChildren($this->getOldName());

        return array_keys($permissions);
    }

    /**
     * Get new child items.
     *
     * @return array
     */
    protected function getNewChildren(): array
    {
        return empty($this->permissions) ? [] : $this->permissions;
    }

    /**
     * Create new Permission.
     *
     * @param string $name
     *
     * @return Item
     */
    protected function createItem(string $name): Item
    {
        return $this->authManager->createPermission($name);
    }

    /**
     * Create self child permission.
     *
     * @param string $name
     *
     * @return Item
     */
    protected function createChild(string $name): Item
    {
        return $this->authManager->createPermission($name);
    }

    /**
     * Returns old name in current object, which is set before new value.
     *
     * @return mixed
     */
    protected function getOldName()
    {
        return null === $this->permission ? null : $this->permission->name;
    }

    /**
     * Returns Permission object.
     *
     * @param string $key
     *
     * @return Item|null
     */
    protected function getItem(string $key)
    {
        return $this->authManager->getPermission($key);
    }

    /**
     * Set permission field for child instance of Rbac - Permission.
     *
     * @param Rbac $instance
     * @param Item      $item
     *
     * @return Rbac
     */
    protected function setItemForInstance(Rbac $instance, Item $item): Rbac
    {
        $instance->permission = $item;

The property permission does not exist on object<Itstructure\RbacModule\models\Rbac>. Since you implemented __set, maybe consider adding a @property annotation.

        return $instance;
    }

    /**
     * Set children permissions for instance of Role.
     *
     * @param Rbac $instance
     *
     * @return Rbac
     */
    protected function setChildrenForInstance(Rbac $instance): Rbac
    {
        $instance->permissions = $instance->getCurrentChildren();

The property permissions does not exist on object<Itstructure\RbacModule\models\Rbac>. Since you implemented __set, maybe consider adding a @property annotation.

        return $instance;
    }
}