RbacValidateComponent - Code Metrics - Inspection of "Upgrade copyright year" - itstructure/yii2-rbac-module - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3f24f8...42984c )

by Andrey

created 2021-02-23 05:41 UTC

RbacValidateComponent A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	27
Duplicated Lines	18.52 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	2
lcom	1
cbo	2
dl	5
loc	27
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	setModel()	5	15	2

How to fix Duplicated Code

<?php

namespace Itstructure\RbacModule\components;

use yii\base\{Model, InvalidConfigException};
use Itstructure\RbacModule\{
    interfaces\ModelInterface,
    interfaces\ValidateComponentInterface
};

/**
 * Class RbacValidateComponent
 * Component class for RBAC.
 *
 * @package Itstructure\RbacModule\components
 */
class RbacValidateComponent extends BaseValidateComponent implements ValidateComponentInterface
{
    /**
     * Sets Rbac model.
     *
     * @param Model $model
     *
     * @throws InvalidConfigException
     *
     * @return ModelInterface
     */
    public function setModel(Model $model): ModelInterface
    {
        if (!($model instanceof ModelInterface)) {


            $modelClass = (new\ReflectionClass($model));

            throw new InvalidConfigException($modelClass->getNamespaceName() .
                '\\' . $modelClass->getShortName().' class  must be implemented from 
                Itstructure\RbacModule\interfaces\ModelInterface.');
        }

        $model->setAuthManager($this->authManager);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $model;
    }
}


1		<?php
2
3		namespace Itstructure\RbacModule\components;
4
5		use yii\base\{Model, InvalidConfigException};
6		use Itstructure\RbacModule\{
7		interfaces\ModelInterface,
8		interfaces\ValidateComponentInterface
9		};
10
11		/**
12		* Class RbacValidateComponent
13		* Component class for RBAC.
14		*
15		* @package Itstructure\RbacModule\components
16		*/
17		class RbacValidateComponent extends BaseValidateComponent implements ValidateComponentInterface
18		{
19		/**
20		* Sets Rbac model.
21		*
22		* @param Model $model
23		*
24		* @throws InvalidConfigException
25		*
26		* @return ModelInterface
27		*/
28		public function setModel(Model $model): ModelInterface
29		{
30	View Code Duplication	if (!($model instanceof ModelInterface)) {
		0 ignored issues – show Duplication introduced 2018-08-01 08:12 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31
32		$modelClass = (new\ReflectionClass($model));
33
34		throw new InvalidConfigException($modelClass->getNamespaceName() .
35		'\\' . $modelClass->getShortName().' class must be implemented from
36		Itstructure\RbacModule\interfaces\ModelInterface.');
37		}
38
39		$model->setAuthManager($this->authManager);
		0 ignored issues – show Documentation introduced 2018-08-01 08:12 UTC by Report Bug Copy Issue Report The property `$authManager` is declared private in `Itstructure\RbacModule\c...s\BaseValidateComponent`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
40
41		return $model;
42		}
43		}
44

itstructure / yii2-rbac-module

Push — master ( 3f24f8...42984c )

RbacValidateComponent A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like