Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | View Code Duplication | class PermissionController extends BaseController |
|
|
|||
14 | { |
||
15 | /** |
||
16 | * Initialize. |
||
17 | * Set viewPath and validateComponent. |
||
18 | */ |
||
19 | public function init() |
||
27 | |||
28 | /** |
||
29 | * Returns Permission model name. |
||
30 | * |
||
31 | * @return string |
||
32 | */ |
||
33 | protected function getModelName():string |
||
37 | |||
38 | /** |
||
39 | * Returns PermissionSearch model name. |
||
40 | * |
||
41 | * @return string|null |
||
42 | */ |
||
43 | protected function getSearchModelName():string |
||
47 | |||
48 | /** |
||
49 | * Returns new object of search main model. |
||
50 | * |
||
51 | * @return mixed |
||
52 | */ |
||
53 | protected function getNewSearchModel() |
||
57 | } |
||
58 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.