Itstructure\MFUploader\controllers\album\AlbumController

Complexity

Total Complexity

26

Size/Duplication

Total Lines	325
Duplicated Lines	13.54 %

Coupling/Cohesion

Components	1
Dependencies	13

Importance

Changes

0

16 Methods

Rating	Name	Duplication	Size	Complexity
A	beforeAction()	0	7	1
	getModelName()	0	1	?
	getAlbumType()	0	1	?
A	init()	0	8	1
A	behaviors()	20	20	1
A	setModel()	0	4	1
A	getModel()	0	4	1
A	getView()	0	8	2
A	actionIndex()	0	15	1
A	actionView()	0	18	1
A	actionCreate()	0	16	3
A	actionUpdate()	0	35	5
A	actionDelete()	0	12	2
A	findModel()	24	25	4
A	getNewModel()	0	5	1
A	setModelByConditions()	0	6	2

<?php

namespace Itstructure\MFUploader\controllers\album;

use Yii;
use yii\helpers\ArrayHelper;
use yii\data\Pagination;
use yii\base\UnknownMethodException;
use yii\web\{Controller, BadRequestHttpException, NotFoundHttpException};
use yii\filters\{VerbFilter, AccessControl};
use Itstructure\MFUploader\Module;
use Itstructure\MFUploader\models\album\{Album, AlbumSearch};
use Itstructure\MFUploader\traits\MediaFilesTrait;

/**
 * AlbumController implements the CRUD actions for Album model.
 */

/**
 * AlbumController implements the CRUD actions for Album model.
 *
 * @property Album $model Model object record.
 * @property Module $module
 * @property string $urlPrefix Url prefix for redirect and view links.
 * @property string $urlPrefixNeighbor Url prefix for redirect and view links of neighbor entity.
 *
 * @package Itstructure\MFUploader\controllers\album
 *
 * @author Andrey Girnik <girnikandrey@gmail.com>
 */
abstract class AlbumController extends Controller
{
    use MediaFilesTrait;

    /**
     * Url prefix for redirect and view links.
     *
     * @var string
     */
    protected $urlPrefix = '';

    /**
     * Url prefix for redirect and view links of neighbor entity.
     *
     * @var string
     */
    protected $urlPrefixNeighbor = '';

    /**
     * Model object record.
     *
     * @var Album
     */
    private $model;

    /**
     * Returns the name of the base model.
     *
     * @return string
     */
    abstract protected function getModelName():string;

    /**
     * Returns the type of album.
     *
     * @return string
     */
    abstract protected function getAlbumType():string;

    /**
     * Initializer.
     */
    public function init()
    {
        $this->view->params['user'] = \Yii::$app->user->identity;

        $this->viewPath = '@'.Module::MODULE_NAME.'/views/albums';

        parent::init();
    }

    /**
     * @param \yii\base\Action $action
     *
     * @return bool
     */
    public function beforeAction($action)
    {
        $this->view->params['urlPrefix']         = $this->urlPrefix;
        $this->view->params['urlPrefixNeighbor'] = $this->urlPrefixNeighbor;

        return parent::beforeAction($action);
    }

    /**
     * {@inheritdoc}
     */
    public function behaviors()

This method seems to be duplicated in your project.

    {
        return [
            'access' => [
                'class' => AccessControl::class,
                'rules' => [
                    [
                        'allow' => true,
                        'roles' => $this->module->accessRoles,
                    ],
                ],
            ],
            'verbs' => [
                'class' => VerbFilter::class,
                'actions' => [
                    'delete' => ['POST'],
                ],
            ],
        ];
    }

    /**
     * Set model.
     *
     * @param Album $model
     */
    public function setModel(Album $model): void
    {
        $this->model = $model;

It seems like $model of type object<Itstructure\MFUploader\models\album\Album> is incompatible with the declared type object<Album> of property $model.

    }

    /**
     * Returns model.
     *
     * @return Album
     */
    public function getModel(): Album
    {
        return $this->model;
    }

    /**
     * Give ability of configure view to the module class.
     *
     * @return \yii\base\View|\yii\web\View
     */
    public function getView()
    {
        if (method_exists($this->module, 'getView')) {
            return $this->module->getView();
        }

        return parent::getView();
    }

    /**
     * Lists all Album models.
     *
     * @return mixed
     */
    public function actionIndex()
    {
        $searchModel = new AlbumSearch();
        $searchParams = ArrayHelper::merge(Yii::$app->request->queryParams, [
            $searchModel->formName() => [
                'type' => $this->getAlbumType()
            ]
        ]);
        $dataProvider = $searchModel->search($searchParams);

        return $this->render('index', [
            'searchModel' => $searchModel,
            'dataProvider' => $dataProvider,
        ]);
    }

    /**
     * Displays a single Album model.
     *
     * @param integer $id
     *
     * @throws NotFoundHttpException if the model cannot be found
     *
     * @return mixed
     */
    public function actionView($id)
    {
        $model = $this->findModel($id);

        $mediafilesQuery = $model->getMediaFilesQuery($model->getFileType($model->type));
        $pages = new Pagination([
            'defaultPageSize' => 6,
            'totalCount' => $mediafilesQuery->count()
        ]);

        return $this->render('view', [
            'model' => $model,
            'mediafiles' => $mediafilesQuery->offset($pages->offset)
                ->limit($pages->limit)
                ->all(),
            'pages' => $pages,
        ]);
    }

    /**
     * Creates a new Album model.
     * If creation is successful, the browser will be redirected to the 'view' page.
     *
     * @return mixed
     */
    public function actionCreate()
    {
        $this->setModelByConditions();

        if ($this->model->load(Yii::$app->request->post()) && $this->model->save()) {
            return $this->redirect([
                $this->urlPrefix.'view',
                'id' => $this->model->id
            ]);
        }

        return $this->render('create', [
            'model' => $this->model,
            'albumType' => $this->getAlbumType(),
        ]);
    }

    /**
     * Updates an existing Album model.
     * If update is successful, the browser will be redirected to the 'view' page.
     *
     * @param integer $id
     *
     * @throws NotFoundHttpException if the model cannot be found
     *
     * @return mixed
     */
    public function actionUpdate($id)
    {
        $this->setModelByConditions($id);

        $post = Yii::$app->request->post();
        if ($this->model->load($post) && $this->model->save()) {
            if (isset($post['delete']) && is_array($post)) {
                $this->deleteMediafileEntry($post['delete'], $this->module);
            }

            return $this->redirect([
                $this->urlPrefix.'view',
                'id' => $this->model->id
            ]);
        }

        $mediafilesQuery = $this->model->getMediaFilesQuery($this->model->getFileType($this->model->type));
        $pages = new Pagination([
            'defaultPageSize' => 6,
            'totalCount' => $mediafilesQuery->count()
        ]);

        return $this->render('update', [
            'model' => $this->model,
            'mediafiles' => $mediafilesQuery->offset($pages->offset)
                ->limit($pages->limit)
                ->all(),
            'pages' => $pages,
            'albumType' => $this->model->type,
            'ownerParams' => [
                'owner' => $this->model->type,
                'ownerId' => $this->model->primaryKey,
            ]
        ]);
    }

    /**
     * Deletes an existing Album model.
     * If deletion is successful, the browser will be redirected to the 'index' page.
     *
     * @param integer $id
     *
     * @throws NotFoundHttpException if the model cannot be found
     * @throws BadRequestHttpException
     *
     * @return mixed
     */
    public function actionDelete($id)
    {
        $model = $this->findModel($id);

        $this->deleteMediafiles($model->type, $model->id, $this->module);

        if (false !== $model->delete()) {
            return $this->redirect([$this->urlPrefix.'index']);
        }

        throw new BadRequestHttpException('Record is not deleted.');
    }

    /**
     * Finds the Album model based on its primary key value.
     *
     * @param $key
     *
     * @throws BadRequestHttpException
     * @throws NotFoundHttpException
     *
     * @return Album
     */
    protected function findModel($key): Album

This method seems to be duplicated in your project.

    {
        if (null === $key) {
            throw new BadRequestHttpException('Key parameter is not defined in findModel method.');
        }

        $modelObject = $this->getNewModel();

        if (!method_exists($modelObject, 'findOne')) {
            $class = (new\ReflectionClass($modelObject));
            throw new UnknownMethodException('Method findOne does not exists in ' . $class->getNamespaceName() . '\\' .
                $class->getShortName().' class.');
        }

        $result = call_user_func([
            $modelObject,
            'findOne',
        ], $key);

        if ($result !== null) {
            return $result;
        }

        throw new NotFoundHttpException('The requested page does not exist.');
    }

    /**
     * Returns new object of main Album model.
     *
     * @return Album
     */
    protected function getNewModel(): Album
    {
        $modelName = $this->getModelName();
        return new $modelName;
    }

    /**
     * Returns an intermediate model for working with the main.
     *
     * @param int|string|null $key
     *
     * @return void
     */
    protected function setModelByConditions($key = null): void
    {
        $model = null === $key ? $this->getNewModel() : $this->findModel($key);

        $this->setModel($model);
    }
}