Itstructure\AdminModule\controllers\LanguageController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getModelName()	0	3	1
A	actionSetDefault()	0	11	3
A	getSearchModelName()	0	3	1
A	init()	0	7	1

<?php

namespace Itstructure\AdminModule\controllers;

use yii\web\NotFoundHttpException;
use Itstructure\AdminModule\models\{Language, LanguageSearch};

/**
 * Class LanguageController
 * LanguageController implements the CRUD actions for Language model.
 *
 * @package Itstructure\AdminModule\controllers
 *
 * @author Andrey Girnik <girnikandrey@gmail.com>
 */
class LanguageController extends CommonAdminController
{
    /**
     * Initialize.
     */
    public function init()
    {
        $this->viewPath = '@admin/views/language';

        $this->setEditingScenarios = true;

        parent::init();
    }

    /**
     * Set language as default.
     *
     * @param $languageId
     *
     * @return \yii\web\Response
     *
     * @throws NotFoundHttpException
     */
    public function actionSetDefault($languageId)
    {
        $language = Language::findOne($languageId);
        if (null === $language) {
            throw  new NotFoundHttpException('Language with id ' . $languageId . ' does not exist');
        }

        $language->default = $language->default == 0 ? 1 : 0;

It seems like you are loosely comparing $language->default of type mixed|null to 0; this is ambiguous as not only 0 == 0 is true, but null == 0 is true, too. Consider using a strict comparison ===.

        $language->save();

        return $this->redirect('index');
    }

    /**
     * Returns Language model name.
     *
     * @return string
     */
    protected function getModelName():string
    {
        return Language::class;
    }

    /**
     * Returns LanguageSearch model name.
     *
     * @return string
     */
    protected function getSearchModelName():string
    {
        return LanguageSearch::class;
    }
}