RoleSeeder::run() - Code Metrics - Inspection of "Add comments for 2.x version, which is for Laravel..." - itstructure/laravel-rbac - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f8f0f3...173874 )

by Andrey

created 2020-09-09 14:03 UTC

RoleSeeder::run() A

↳ Parent: RoleSeeder

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	54
rs	9.0036
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

use Illuminate\Database\Seeder;
use Itstructure\LaRbac\Models\{Role, Permission};

/**
 * Class RoleSeeder
 *
 * @author Andrey Girnik <[email protected]>
 */
class RoleSeeder extends Seeder
{
    /**
     * Run the database seeds.
     * @return void
     */
    public function run()
    {
        $totalPermissionId   = Permission::where('slug', Permission::ADMINISTRATE_PERMISSION)->firstOrFail()->id;
        $viewPermissionId    = Permission::where('slug', Permission::VIEW_RECORD_PERMISSION)->firstOrFail()->id;
        $createPermissionId  = Permission::where('slug', Permission::CREATE_RECORD_PERMISSION)->firstOrFail()->id;
        $updatePermissionId  = Permission::where('slug', Permission::UPDATE_RECORD_PERMISSION)->firstOrFail()->id;
        $deletePermissionId  = Permission::where('slug', Permission::DELETE_RECORD_PERMISSION)->firstOrFail()->id;
        $publishPermissionId = Permission::where('slug', Permission::PUBLISH_RECORD_PERMISSION)->firstOrFail()->id;

        $this->createRecord(
            Role::ADMIN_ROLE,
            'Administrator',
            [
                $totalPermissionId,
                $viewPermissionId,
                $createPermissionId,
                $updatePermissionId,
                $deletePermissionId,
                $publishPermissionId
            ]
        );

        $this->createRecord(
            Role::MANAGER_ROLE,
            'Content manager',
            [
                $viewPermissionId,
                $createPermissionId,
                $updatePermissionId,
                $deletePermissionId,
                $publishPermissionId
            ]
        );

        $this->createRecord(
            Role::EDITOR_ROLE,
            'Record editor',
            [
                $viewPermissionId,
                $createPermissionId,
                $updatePermissionId,
                $deletePermissionId,
                $publishPermissionId
            ]
        );

        $this->createRecord(
            Role::USER_ROLE,
            'Simple user',
            [
                $viewPermissionId
            ]
        );
    }

    /**
     * Create role record in database.
     * @param string $slug
     * @param string $description
     * @param array $permissions
     * @return void
     */
    private function createRecord(string $slug, string $description, array $permissions): void
    {
        Role::create([
            'name' => ucfirst($slug),
            'slug' => $slug,
            'description' => $description,
        ])->permissions()
            ->attach($permissions);
    }
}


1			<?php
2
3			use Illuminate\Database\Seeder;
4			use Itstructure\LaRbac\Models\{Role, Permission};
5
6			/**
7			* Class RoleSeeder
8			*
9			* @author Andrey Girnik <[email protected]>
10			*/
11			class RoleSeeder extends Seeder
12			{
13			/**
14			* Run the database seeds.
15			* @return void
16			*/
17			public function run()
18			{
19			$totalPermissionId = Permission::where('slug', Permission::ADMINISTRATE_PERMISSION)->firstOrFail()->id;
20			$viewPermissionId = Permission::where('slug', Permission::VIEW_RECORD_PERMISSION)->firstOrFail()->id;
21			$createPermissionId = Permission::where('slug', Permission::CREATE_RECORD_PERMISSION)->firstOrFail()->id;
22			$updatePermissionId = Permission::where('slug', Permission::UPDATE_RECORD_PERMISSION)->firstOrFail()->id;
23			$deletePermissionId = Permission::where('slug', Permission::DELETE_RECORD_PERMISSION)->firstOrFail()->id;
24			$publishPermissionId = Permission::where('slug', Permission::PUBLISH_RECORD_PERMISSION)->firstOrFail()->id;
25
26			$this->createRecord(
27			Role::ADMIN_ROLE,
28			'Administrator',
29			[
30			$totalPermissionId,
31			$viewPermissionId,
32			$createPermissionId,
33			$updatePermissionId,
34			$deletePermissionId,
35			$publishPermissionId
36			]
37			);
38
39			$this->createRecord(
40			Role::MANAGER_ROLE,
41			'Content manager',
42			[
43			$viewPermissionId,
44			$createPermissionId,
45			$updatePermissionId,
46			$deletePermissionId,
47			$publishPermissionId
48			]
49			);
50
51			$this->createRecord(
52			Role::EDITOR_ROLE,
53			'Record editor',
54			[
55			$viewPermissionId,
56			$createPermissionId,
57			$updatePermissionId,
58			$deletePermissionId,
59			$publishPermissionId
60			]
61			);
62
63			$this->createRecord(
64			Role::USER_ROLE,
65			'Simple user',
66			[
67			$viewPermissionId
68			]
69			);
70			}
71
72			/**
73			* Create role record in database.
74			* @param string $slug
75			* @param string $description
76			* @param array $permissions
77			* @return void
78			*/
79			private function createRecord(string $slug, string $description, array $permissions): void
80			{
81			Role::create([
82			'name' => ucfirst($slug),
83			'slug' => $slug,
84			'description' => $description,
85			])->permissions()
86			->attach($permissions);
87			}
88			}
89

itstructure / laravel-rbac

Push — master ( f8f0f3...173874 )

RoleSeeder::run() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like