Conditions | 1 |
Paths | 1 |
Total Lines | 54 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
18 | public function run() |
||
19 | { |
||
20 | $totalPermissionId = Permission::where('slug', Permission::ADMINISTRATE_PERMISSION)->firstOrFail()->id; |
||
21 | $viewPermissionId = Permission::where('slug', Permission::VIEW_RECORD_PERMISSION)->firstOrFail()->id; |
||
22 | $createPermissionId = Permission::where('slug', Permission::CREATE_RECORD_PERMISSION)->firstOrFail()->id; |
||
23 | $updatePermissionId = Permission::where('slug', Permission::UPDATE_RECORD_PERMISSION)->firstOrFail()->id; |
||
24 | $deletePermissionId = Permission::where('slug', Permission::DELETE_RECORD_PERMISSION)->firstOrFail()->id; |
||
25 | $publishPermissionId = Permission::where('slug', Permission::PUBLISH_RECORD_PERMISSION)->firstOrFail()->id; |
||
26 | |||
27 | $this->createRecord( |
||
28 | Role::ADMIN_ROLE, |
||
29 | 'Administrator', |
||
30 | [ |
||
31 | $totalPermissionId, |
||
32 | $viewPermissionId, |
||
33 | $createPermissionId, |
||
34 | $updatePermissionId, |
||
35 | $deletePermissionId, |
||
36 | $publishPermissionId |
||
37 | ] |
||
38 | ); |
||
39 | |||
40 | $this->createRecord( |
||
41 | Role::MANAGER_ROLE, |
||
42 | 'Content manager', |
||
43 | [ |
||
44 | $viewPermissionId, |
||
45 | $createPermissionId, |
||
46 | $updatePermissionId, |
||
47 | $deletePermissionId, |
||
48 | $publishPermissionId |
||
49 | ] |
||
50 | ); |
||
51 | |||
52 | $this->createRecord( |
||
53 | Role::EDITOR_ROLE, |
||
54 | 'Record editor', |
||
55 | [ |
||
56 | $viewPermissionId, |
||
57 | $createPermissionId, |
||
58 | $updatePermissionId, |
||
59 | $deletePermissionId, |
||
60 | $publishPermissionId |
||
61 | ] |
||
62 | ); |
||
63 | |||
64 | $this->createRecord( |
||
65 | Role::USER_ROLE, |
||
66 | 'Simple user', |
||
67 | [ |
||
68 | $viewPermissionId |
||
69 | ] |
||
70 | ); |
||
71 | } |
||
72 | |||
90 |