UpdateRole::messages() - Code Metrics - Inspection of "Total package reconstruction" - itstructure/laravel-rbac - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a77c04...464b27 )

by Andrey

created 2020-07-12 10:56 UTC

UpdateRole::messages() A

↳ Parent: UpdateRole

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	11
Ratio	100 %

Importance

Changes

Metric	Value
dl	11
loc	11
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Itstructure\LaRbac\Http\Requests;

use Illuminate\Validation\Rule;
use Illuminate\Foundation\Http\FormRequest;

/**
 * Class UpdateRole
 *
 * @package Itstructure\LaRbac\Http\Requests
 *
 * @author Andrey Girnik <[email protected]>
 */
class UpdateRole extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return !empty(config('rbac.routesMainPermission')) ? $this->user()->can(config('rbac.routesMainPermission')) : true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()

    {
        $id = $this->route('role')->id;
        return [
            'name' => [
                'required',
                'string',
                'regex:/^[\w\s\-]+$/',
                'min:3',
                'max:191',
                Rule::unique('roles')->where('id', '<>', $id),

            ],
            'description' => [
                'required',
                'string',
                'min:3',
                'max:191',
                Rule::unique('roles')->where('id', '<>', $id),

            ],
            'permissions' => 'required|array',
        ];
    }

    /**
     * Get the error messages for the defined validation rules.
     *
     * @return array
     */
    public function messages()

    {
        return [
            'required' => __('rbac::validation.required'),
            'string' => __('rbac::validation.string'),
            'regex' => __('rbac::validation.regex'),
            'min' => __('rbac::validation.min'),
            'max' => __('rbac::validation.max'),
            'unique' => __('rbac::validation.unique'),
        ];
    }

    /**
     * Get custom attributes for validator errors.
     *
     * @return array
     */
    public function attributes()

    {
        return [
            'name' => __('rbac::main.name'),
            'description' => __('rbac::main.description'),
            'permissions' => __('rbac::permissions.permissions'),
        ];
    }
}


1		<?php
2
3		namespace Itstructure\LaRbac\Http\Requests;
4
5		use Illuminate\Validation\Rule;
6		use Illuminate\Foundation\Http\FormRequest;
7
8		/**
9		* Class UpdateRole
10		*
11		* @package Itstructure\LaRbac\Http\Requests
12		*
13		* @author Andrey Girnik <[email protected]>
14		*/
15		class UpdateRole extends FormRequest
16		{
17		/**
18		* Determine if the user is authorized to make this request.
19		*
20		* @return bool
21		*/
22		public function authorize()
23		{
24		return !empty(config('rbac.routesMainPermission')) ? $this->user()->can(config('rbac.routesMainPermission')) : true;
25		}
26
27		/**
28		* Get the validation rules that apply to the request.
29		*
30		* @return array
31		*/
32	View Code Duplication	public function rules()
		0 ignored issues – show Duplication introduced 2020-07-12 11:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		{
34		$id = $this->route('role')->id;
35		return [
36		'name' => [
37		'required',
38		'string',
39		'regex:/^[\w\s\-]+$/',
40		'min:3',
41		'max:191',
42		Rule::unique('roles')->where('id', '<>', $id),
		0 ignored issues – show Unused Code introduced 2018-07-22 03:57 UTC by Report Bug Copy Issue Report The call to `Unique::where()` has too many arguments starting with `$id`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
43		],
44		'description' => [
45		'required',
46		'string',
47		'min:3',
48		'max:191',
49		Rule::unique('roles')->where('id', '<>', $id),
		0 ignored issues – show Unused Code introduced 2018-07-22 03:57 UTC by Report Bug Copy Issue Report The call to `Unique::where()` has too many arguments starting with `$id`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
50		],
51		'permissions' => 'required\|array',
52		];
53		}
54
55		/**
56		* Get the error messages for the defined validation rules.
57		*
58		* @return array
59		*/
60	View Code Duplication	public function messages()
		0 ignored issues – show Duplication introduced 2020-07-12 11:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
61		{
62		return [
63		'required' => __('rbac::validation.required'),
64		'string' => __('rbac::validation.string'),
65		'regex' => __('rbac::validation.regex'),
66		'min' => __('rbac::validation.min'),
67		'max' => __('rbac::validation.max'),
68		'unique' => __('rbac::validation.unique'),
69		];
70		}
71
72		/**
73		* Get custom attributes for validator errors.
74		*
75		* @return array
76		*/
77	View Code Duplication	public function attributes()
		0 ignored issues – show Duplication introduced 2020-07-12 11:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		{
79		return [
80		'name' => __('rbac::main.name'),
81		'description' => __('rbac::main.description'),
82		'permissions' => __('rbac::permissions.permissions'),
83		];
84		}
85		}
86

itstructure / laravel-rbac

Push — master ( a77c04...464b27 )

UpdateRole::messages() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like