itstructure / laravel-media-file-uploader

src/Traits/HasCompositePrimaryKey.php

<?php

namespace Itstructure\MFU\Traits;

use Illuminate\Database\Eloquent\Builder;

trait HasCompositePrimaryKey
{
    /**
     * @param Builder $query
     * @return Builder
     */
    protected function setKeysForSaveQuery($query)
    {
        $keys = $this->getKeyName();

It seems like getKeyName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if(!is_array($keys)){
            return parent::setKeysForSaveQuery($query);
        }

        foreach($keys as $keyName){
            $query->where($keyName, '=', $this->getKeyForSaveQuery($keyName));
        }

        return $query;
    }

    /**
     * @param null $keyName

Are you sure the doc-type for parameter $keyName is correct as it would always require null to be passed?

     * @return mixed
     */
    protected function getKeyForSaveQuery($keyName = null)
    {
        if(is_null($keyName)){

The condition is_null($keyName) is always true.

            $keyName = $this->getKeyName();
        }

        if (isset($this->original[$keyName])) {
            return $this->original[$keyName];
        }

        return $this->getAttribute($keyName);

It seems like getAttribute() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}