itstructure / laravel-media-file-uploader

src/Services/Uploader.php

<?php

namespace Itstructure\MFU\Services;

use Exception;
use Illuminate\Http\UploadedFile;
use Illuminate\Support\MessageBag;
use Itstructure\MFU\Processors\{
    BaseProcessor, SaveProcessor, UploadProcessor, UpdateProcessor, DeleteProcessor
};
use Itstructure\MFU\Models\Mediafile;

/**
 * Class Uploader
 * @package Itstructure\MFU\Services
 * @author Andrey Girnik <girnikandrey@gmail.com>
 */
class Uploader
{
    /**
     * @var array
     */
    private $config;

    /**
     * @var SaveProcessor|BaseProcessor
     */
    private $processor;

    /**
     * @param array $config
     * @return Uploader
     */
    public static function getInstance(array $config = []): self
    {
        return new static($config);
    }

    /**
     * @param array $data
     * @param UploadedFile $file
     * @throws Exception
     * @return bool
     */
    public function upload(array $data, UploadedFile $file = null): bool
    {
        $this->processor = UploadProcessor::getInstance($this->config)
            ->setMediafileModel(new Mediafile())
            ->setData($data)
            ->setFile($file);

        return $this->save();
    }

    /**
     * @param int $id
     * @param array $data
     * @param UploadedFile|null $file
     * @throws Exception
     * @return bool
     */
    public function update(int $id, array $data, UploadedFile $file = null): bool
    {
        $this->processor = UpdateProcessor::getInstance($this->config)
            ->setMediafileModel(Mediafile::find($id))

It seems like Itstructure\MFU\Models\Mediafile::find($id) can also be of type null; however, parameter $model of Itstructure\MFU\Processors\BaseProcessor::setMediafileModel() does only seem to accept Itstructure\MFU\Models\Mediafile, maybe add an additional type check?

            ->setData($data)
            ->setFile($file);

        return $this->save();
    }

    /**
     * @param int $id
     * @throws Exception
     * @return bool
     */
    public function delete(int $id): bool
    {
        $this->processor = DeleteProcessor::getInstance()
            ->setMediafileModel(Mediafile::find($id));

It seems like Itstructure\MFU\Models\Mediafile::find($id) can also be of type null; however, parameter $model of Itstructure\MFU\Processors\BaseProcessor::setMediafileModel() does only seem to accept Itstructure\MFU\Models\Mediafile, maybe add an additional type check?

        return $this->processor->run();
    }

    /**
     * @return bool
     */
    public function hasErrors(): bool
    {
        return !is_null($this->processor->getErrors());
    }

    /**
     * @return MessageBag|null
     */
    public function getErrors(): ?MessageBag
    {
        return $this->processor->getErrors();
    }

    /**
     * @return int
     */
    public function getId(): int
    {
        return $this->processor->getId();
    }

    /**
     * @param string|null $key
     * @return array
     */
    public function getConfig(string $key = null)
    {
        return !empty($key) ? $this->config[$key] : $this->config;
    }

    /**
     * UploadService constructor.
     * @param array $config
     */
    private function __construct(array $config = [])
    {
        $this->config = $config;
    }

    /**
     * @return bool
     */
    private function save(): bool
    {
        if (!$this->processor->run()) {
            return false;
        }

        if ($this->processor->getMediafileModel()->isImage()) {
            $this->processor->createThumbs();

The method createThumbs() does not exist on Itstructure\MFU\Processors\BaseProcessor. It seems like you code against a sub-type of Itstructure\MFU\Processors\BaseProcessor such as Itstructure\MFU\Processors\SaveProcessor.

        }

        return true;
    }
}