itstructure / laravel-grid-view

src/Columns/CheckboxColumn.php

<?php

namespace Itstructure\GridView\Columns;

use Itstructure\GridView\Filters\StubFilter;
use Itstructure\GridView\Traits\Configurable;

/**
 * Class CheckboxColumn.
 * @package Itstructure\GridView\Columns
 */
class CheckboxColumn extends BaseColumn
{
    use Configurable;

    /**
     * @var string
     */
    protected $field;

    /**
     * @var bool|callable
     */
    protected $display = true;

    /**
     * ActionColumn constructor.
     * @param array $config
     */
    public function __construct(array $config)
    {
        $this->loadConfig($config);

        $this->filter = new StubFilter();
    }

    /**
     * @return string
     */
    public function getLabel(): string
    {
        return $this->label ?? trans('grid_view::grid.deletion');

The expression return $this->label ?? trans('grid_view::grid.deletion') could return the type array which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }

    /**
     * @param $row
     * @return mixed
     */
    public function getValue($row)
    {
        return $row->{$this->attribute} ?? '';
    }

    /**
     * @param $row
     * @return array|string
     */
    public function render($row)
    {
        if ($this->display === false) {
            return view('grid_view::columns.checkbox-stub')->render();
        }

        if (is_callable($this->display) && !call_user_func($this->display, $row)) {

It seems like $this->display can also be of type true; however, parameter $callback of call_user_func() does only seem to accept callable, maybe add an additional type check?

            return view('grid_view::columns.checkbox-stub')->render();
        }

        return view('grid_view::columns.checkbox', [
            'field' => $this->field,
            'value' => $this->getValue($row),
        ])->render();
    }
}