itsjavi\Flatdown\Markdown\MarkdownFileParser

Complexity

Total Complexity

21

Size/Duplication

Total Lines	117
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	parse()	0	14	3
D	parseMetadata()	0	36	10
A	parseTitle()	0	12	2
B	createFlavoredParser()	0	25	6

<?php

namespace itsjavi\Flatdown\Markdown;

use cebe\markdown\GithubMarkdown;
use cebe\markdown\Markdown;
use cebe\markdown\MarkdownExtra;
use Symfony\Component\Yaml\Yaml;

class MarkdownFileParser
{
    /**
     * Parses the given Markdown file
     *
     * @param string $filename
     * @param array $options
     *
     * @return MarkdownFile
     */
    public function parse($filename, array $options)
    {
        $file = new MarkdownFile($filename);

        $content = $file->load()->content;

        $file->metadata = $this->parseMetadata($content, $options);

It seems like $this->parseMetadata($content, $options) can also be of type array or object<stdClass>. However, the property $metadata is declared as type string. Maybe add an additional type check?

        $file->html     = trim($this->createFlavoredParser($options)->parse($content));
        $parsedTitle    = $this->parseTitle($file->html);
        $file->title    = (isset($file->metadata['title']) && strlen($file->metadata['title']))
            ? $file->metadata['title'] : $parsedTitle;

        return $file;
    }

    /**
     * @param string $content
     * @param array $options
     *
     * @return array
     */
    private function parseMetadata(&$content, array $options)
    {
        $metadataLines = [];
        $contentLines  = explode("\n", $content);
        $delimiter     = isset($options['metadataDelimiter']) ? $options['metadataDelimiter'] : '---';
        $indentation   = isset($options['metadataIndentation']) ? $options['metadataIndentation'] : 4;

        if (empty($contentLines) || ($contentLines[0] !== $delimiter)) {
            return [];
        }

        array_shift($contentLines);

        $line = 0;
        while (isset($contentLines[$line]) && ($contentLines[$line] != $delimiter)) {
            $metadataLines[] = $indentation ?
                preg_replace('/^(\s{' . $indentation . '})/', '', $contentLines[$line]) :
                $contentLines[$line];
            $line++;
        }

        if ($contentLines[$line] == $delimiter) {
            $line++;
        }

        $content = [];

        for ($i = $line; $i < count($contentLines); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $content[] = $contentLines[$i];
        }

        $content  = implode("\n", $content);
        $metadata = implode("\n", $metadataLines);

        return Yaml::parse($metadata);
    }

    /**
     * @param string $html
     *
     * @return string
     */
    private function parseTitle(&$html)
    {
        $parts = explode('</h1>', $html, 2);

        if (count($parts) != 2) {
            return '';
        }
        $title = preg_replace('/(.*)(\<h1.*\>)(.*)/', '$3', $parts[0]);
        $html  = preg_replace('/(.*)(\<h1.*)/', '$1', $parts[0]) . $parts[1];

        return $title;
    }

    /**
     * @param array $options
     *
     * @return Markdown
     */
    private function createFlavoredParser(array $options)
    {
        $parser = null;

$parser is not used, you could remove the assignment.

        $flavor = isset($options['flavor']) ? $options['flavor'] : 'extra';

        switch ($flavor) {
            case 'default':
                $parser = new Markdown();
                break;
            case 'extra':
                $parser = new MarkdownExtra();
                break;
            case 'github':
                $parser = new GithubMarkdown();
                break;
            default:
                throw new \InvalidArgumentException('Flavor not supported: ' . $flavor);
        }

        foreach ($options as $optName => $optValue) {
            $parser->$optName = $optValue;
        }

        return $parser;
    }
}