| Total Complexity | 49 |
| Total Lines | 246 |
| Duplicated Lines | 0 % |
| Changes | 7 | ||
| Bugs | 0 | Features | 1 |
Complex classes like Log often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Log, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 12 | class Log implements LoggerInterface { |
||
| 13 | |||
| 14 | private $channel; |
||
| 15 | private $minDebugLevel; |
||
| 16 | |||
| 17 | /** |
||
| 18 | * @param false $channel |
||
| 19 | */ |
||
| 20 | public function __construct($channel = false) { |
||
| 21 | |||
| 22 | $this->minDebugLevel = ($_ENV['APP_DEBUG_LEVEL'] ?: 'DEBUG'); |
||
| 23 | if($channel) { |
||
| 24 | $this->channel = $channel; |
||
| 25 | //TODO: get channel options |
||
| 26 | } else { |
||
| 27 | $this->channel = ($_ENV['APP_LOG_BITRIX_CHANNEL'] ?: 'bitrix'); |
||
| 28 | } |
||
| 29 | } |
||
| 30 | |||
| 31 | /** |
||
| 32 | * @param $message |
||
| 33 | * @param array $context |
||
| 34 | */ |
||
| 35 | public function alert($message, $context = []) |
||
| 36 | { |
||
| 37 | try { |
||
| 38 | $logger = $this->getLogger(); |
||
| 39 | $message = $this->formatMessage($message); |
||
| 40 | $logger->alert($message, (array) $context); |
||
| 41 | } catch (\Exception $e) { |
||
| 42 | self::logInnerException($e); |
||
| 43 | } |
||
| 44 | } |
||
| 45 | |||
| 46 | /** |
||
| 47 | * @param $message |
||
| 48 | * @param array $context |
||
| 49 | */ |
||
| 50 | public function critical($message, $context = []) |
||
| 51 | { |
||
| 52 | try { |
||
| 53 | $logger = $this->getLogger(); |
||
| 54 | $message = $this->formatMessage($message); |
||
| 55 | $logger->critical($message, (array) $context); |
||
| 56 | } catch (\Exception $e) { |
||
| 57 | self::logInnerException($e); |
||
| 58 | } |
||
| 59 | } |
||
| 60 | |||
| 61 | /** |
||
| 62 | * @param $message |
||
| 63 | * @param array $context |
||
| 64 | */ |
||
| 65 | public function error($message, $context = []) |
||
| 66 | { |
||
| 67 | if ($this->isDebugEnabled(Logger::ERROR)) { |
||
| 68 | try { |
||
| 69 | $logger = $this->getLogger(); |
||
| 70 | $message = $this->formatMessage($message); |
||
| 71 | $logger->error($message, (array) $context); |
||
| 72 | } catch (\Exception $e) { |
||
| 73 | self::logInnerException($e); |
||
| 74 | } |
||
| 75 | } |
||
| 76 | } |
||
| 77 | |||
| 78 | /** |
||
| 79 | * @param $message |
||
| 80 | * @param array $context |
||
| 81 | */ |
||
| 82 | public function warning($message, $context = []) |
||
| 83 | { |
||
| 84 | if ($this->isDebugEnabled(Logger::WARNING)) { |
||
| 85 | try { |
||
| 86 | $logger = $this->getLogger(); |
||
| 87 | $message = $this->formatMessage($message); |
||
| 88 | $logger->warning($message, (array) $context); |
||
| 89 | } catch (\Exception $e) { |
||
| 90 | self::logInnerException($e); |
||
| 91 | } |
||
| 92 | } |
||
| 93 | } |
||
| 94 | |||
| 95 | /** |
||
| 96 | * @param $message |
||
| 97 | * @param array $context |
||
| 98 | */ |
||
| 99 | public function notice($message, $context = []) |
||
| 100 | { |
||
| 101 | if ($this->isDebugEnabled(Logger::NOTICE)) { |
||
| 102 | try { |
||
| 103 | $logger = $this->getLogger(); |
||
| 104 | $message = $this->formatMessage($message); |
||
| 105 | $logger->notice($message, (array) $context); |
||
| 106 | } catch (\Exception $e) { |
||
| 107 | self::logInnerException($e); |
||
| 108 | } |
||
| 109 | } |
||
| 110 | } |
||
| 111 | |||
| 112 | /** |
||
| 113 | * @param $message |
||
| 114 | * @param array $context |
||
| 115 | */ |
||
| 116 | public function info($message, $context = []) |
||
| 117 | { |
||
| 118 | if ($this->isDebugEnabled(Logger::INFO)) { |
||
| 119 | try { |
||
| 120 | $logger = $this->getLogger(); |
||
| 121 | $message = $this->formatMessage($message); |
||
| 122 | $logger->info($message, (array) $context); |
||
| 123 | } catch (\Exception $e) { |
||
| 124 | self::logInnerException($e); |
||
| 125 | } |
||
| 126 | } |
||
| 127 | } |
||
| 128 | |||
| 129 | /** |
||
| 130 | * @param $message |
||
| 131 | * @param array $context |
||
| 132 | */ |
||
| 133 | public function debug($message, $context = []) |
||
| 134 | { |
||
| 135 | if ($this->isDebugEnabled(Logger::DEBUG)) { |
||
| 136 | try { |
||
| 137 | $logger = $this->getLogger(); |
||
| 138 | $message = $this->formatMessage($message); |
||
| 139 | $logger->debug($message, (array) $context); |
||
| 140 | } catch (\Exception $e) { |
||
| 141 | self::logInnerException($e); |
||
| 142 | } |
||
| 143 | } |
||
| 144 | } |
||
| 145 | |||
| 146 | public function emergency($message, $context = []) |
||
| 147 | { |
||
| 148 | try { |
||
| 149 | $logger = $this->getLogger(); |
||
| 150 | $message = $this->formatMessage($message); |
||
| 151 | $logger->emergency($message, (array) $context); |
||
| 152 | } catch (\Exception $e) { |
||
| 153 | self::logInnerException($e); |
||
| 154 | } |
||
| 155 | } |
||
| 156 | |||
| 157 | public function log($level, $message, $context = []) |
||
| 158 | { |
||
| 159 | if ($this->isDebugEnabled($level)) { |
||
| 160 | try { |
||
| 161 | $logger = $this->getLogger(); |
||
| 162 | $message = $this->formatMessage($message); |
||
| 163 | $logger->log($level, $message, (array) $context); |
||
| 164 | } catch (\Exception $e) { |
||
| 165 | self::logInnerException($e); |
||
| 166 | } |
||
| 167 | } |
||
| 168 | } |
||
| 169 | |||
| 170 | /** |
||
| 171 | * @param $message |
||
| 172 | * @return string |
||
| 173 | */ |
||
| 174 | private function formatMessage($message) { |
||
| 183 | } |
||
| 184 | |||
| 185 | /** |
||
| 186 | * @return Logger |
||
| 187 | */ |
||
| 188 | public function getLogger() { |
||
| 189 | |||
| 190 | if(Registry::hasLogger($this->channel)) { |
||
| 191 | return Registry::getInstance($this->channel); |
||
| 192 | } |
||
| 193 | $logPath = $_SERVER['DOCUMENT_ROOT'] . ($_ENV['APP_LOG_FOLDER'] ?: '/log/'); |
||
| 194 | $logPath .= $this->channel . '/' . date('Y-m-d') . '.log'; |
||
| 195 | $logDir = pathinfo($logPath, PATHINFO_DIRNAME); |
||
| 196 | if(!file_exists($logDir)) { |
||
| 197 | $mode = 0775; |
||
| 198 | if(defined('BX_DIR_PERMISSIONS') && BX_DIR_PERMISSIONS) { |
||
| 199 | $mode = BX_DIR_PERMISSIONS; |
||
| 200 | } |
||
| 201 | mkdir($logDir, $mode, true); |
||
| 202 | } |
||
| 203 | |||
| 204 | $handler = new StreamHandler($logPath); |
||
| 205 | $handler->setFormatter(new ArrayFormatter()); |
||
| 206 | |||
| 207 | $logger = new Logger($this->channel); |
||
| 208 | $logger->pushHandler($handler); |
||
| 209 | Registry::addLogger($logger, $this->channel, true); |
||
| 210 | |||
| 211 | return $logger; |
||
| 212 | } |
||
| 213 | |||
| 214 | /** |
||
| 215 | * @return int|mixed |
||
| 216 | */ |
||
| 217 | private function getMinErrorLevel() { |
||
| 218 | |||
| 219 | $levels = Logger::getLevels(); |
||
| 220 | |||
| 221 | if($this->minDebugLevel && isset($levels[$this->minDebugLevel])) { |
||
| 222 | return $levels[$this->minDebugLevel]; |
||
| 223 | } else { |
||
| 224 | return Logger::DEBUG; |
||
| 225 | } |
||
| 226 | } |
||
| 227 | |||
| 228 | /** |
||
| 229 | * @param int $level |
||
| 230 | * @return bool |
||
| 231 | */ |
||
| 232 | private function isDebugEnabled($level = 0) |
||
| 233 | { |
||
| 234 | if (defined('FORCE_DEBUG') && FORCE_DEBUG) { |
||
| 235 | return true; |
||
| 236 | } |
||
| 237 | $min_level = $this->getMinErrorLevel(); |
||
| 238 | if($level >= $min_level) { |
||
| 239 | return true; |
||
| 240 | } |
||
| 241 | return false; |
||
| 242 | } |
||
| 243 | |||
| 244 | /** |
||
| 245 | * @param \Exception $exception |
||
| 246 | */ |
||
| 247 | public static function logInnerException(\Exception $exception) |
||
| 248 | { |
||
| 249 | Debug::writeToFile((string) $exception, "", "inner_error.log"); |
||
| 250 | } |
||
| 251 | |||
| 252 | public static function cleanLogs($daysAgo = 15) { |
||
| 258 | } |
||
| 259 | } |
||
| 260 |
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths