itrukhin / bxconsole

src/Application.php

<?php
namespace App\BxConsole;

use Bitrix\Main\Loader;

The type Bitrix\Main\Loader was not found. Maybe you did not declare it correctly or list all dependencies?

use Bitrix\Main\ModuleManager;

The type Bitrix\Main\ModuleManager was not found. Maybe you did not declare it correctly or list all dependencies?

use Composer\Autoload\ClassLoader;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class Application extends \Symfony\Component\Console\Application {

    const VERSION = '1.0.0';

    private $isBitrixLoaded;
    
    private $bitrixCommands = [];

The private property $bitrixCommands is not used, and could be removed.

    public function __construct($name = 'BxConsole', $version = self::VERSION)
    {
        parent::__construct($name, $version);

        EnvHelper::loadEnv();
        EnvHelper::getDocumentRoot();

        $loader = new \App\BxConsole\Bitrix\Loader();

        $this->isBitrixLoaded = $loader->initializeBitrix();

        if($this->isBitrixLoaded) {
            foreach($loader->getModulesCommands() as $command) {
                $this->add($command);
            }
        }

        $pas4CliNamespace = EnvHelper::getPsr4CliNamespace();
        /** @scrutinizer ignore-call */
        $loaders = ClassLoader::getRegisteredLoaders();
        if(!empty($loaders)) {
            $loader = current($loaders);
            if($loader instanceof ClassLoader) {
                $map = $loader->getClassMap();
                foreach($map as $class => $path) {
                    if(strpos($class, $pas4CliNamespace) === 0) {
                        try {
                            $obj = new $class();
                            if($obj instanceof Command) {
                                $this->add($obj);
                            }
                        } catch (\Exception $e) { }

Consider adding a comment why this CATCH block is empty.

                    }
                }
            }
        }

        $this->add(new Cron());
    }

    public function doRun(InputInterface $input, OutputInterface $output) {

        $exitCode = parent::doRun($input, $output);

        if($this->isBitrixLoaded) {
            if ($this->getCommandName($input) === null) {
                $output->writeln(PHP_EOL . sprintf('Using Bitrix <info>kernel v%s</info>.</info>', SM_VERSION),

The constant App\BxConsole\SM_VERSION was not found. Maybe you did not declare it correctly or list all dependencies?

                    OutputInterface::VERBOSITY_VERY_VERBOSE);
            }

        } else {
            $output->writeln(PHP_EOL . sprintf('<error>No Bitrix kernel found in %s.</error> ' .
                    'Please set DOCUMENT_ROOT value in composer.json <info>{"extra":{"document-root":DOCUMENT_ROOT}}</info>', $this->getDocumentRoot()));
        }

        return $exitCode;
    }

    /**
     * @return bool
     */
    public function isBitrixLoaded(): bool
    {
        return $this->isBitrixLoaded;
    }

    /**
     * @return string
     */
    public function getDocumentRoot() {

        return (EnvHelper::getDocumentRoot() ?: '');
    }
}