Cron::execute() - Code Metrics - Inspection of "refactor crontab updates" - itrukhin/bxconsole - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( a8eabf...729b2b )

by Ioannes
created 2021-11-09 20:59 UTC
Cron::execute() F

↳ Parent: Cron
Complexity

Conditions	13
Paths	450
Size

Total Lines	90
Code Lines	50
Duplication

Lines	0
Ratio	0 %
Importance

Changes	3
Bugs	1	Features	0
Metric	Value
eloc	50
c	3
b	1
f	0
dl	0
loc	90
rs	3.2138
cc	13
nc	450
nop	2
How to fix Long Method Complexity

<?php
namespace App\BxConsole;

use Bitrix\Main\Type\DateTime;
filter:
    dependency_paths: ["lib/*"]
use Doctrine\Common\Annotations\AnnotationReader;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use App\BxConsole\Annotations\Agent;
use Symfony\Component\Lock\LockFactory;
use Symfony\Component\Lock\Store\FlockStore;

class Cron extends BxCommand {

    const EXEC_STATUS_SUCCESS = 'SUCCESS';
    const EXEC_STATUS_ERROR = 'ERROR';
    const EXEC_STATUS_WORK = 'WORK';

    /**
     * Глобальный таймаут запуска процесса.
     * Устанавливает TTL блокировки
     */
    const EXEC_TIMEOUT = 600;

    /**
     * Период запуска задач кроном
     */
    const BX_CRON_PERIOD = 60;

    private $minAgentPeriod = self::BX_CRON_PERIOD;

    protected function configure() {

        $this->setName('system:cron')
            ->setDescription('Job sheduler for application comands');
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $logger = EnvHelper::getLogger('bx_cron');
        if($logger) {
            $this->setLogger($logger);
        }

        $jobs = $this->getCronJobs();

        /*
         * Минимально допустимый период выполнения одной задачи
         * при котором гарантируется выполнение всех задач
         */
        $this->minAgentPeriod = (count($jobs) + 1) * self::BX_CRON_PERIOD;

        if(!empty($jobs)) {

            $lockStore = new FlockStore(pathinfo(EnvHelper::getCrontabFile(), PATHINFO_DIRNAME));
            $lockStore = new FlockStore(/** @scrutinizer ignore-type */ pathinfo(EnvHelper::getCrontabFile(), PATHINFO_DIRNAME));
            $lockFactory = new LockFactory($lockStore);
            if($this->logger) {
                $lockFactory->setLogger($this->logger);
            }

            foreach($jobs as $cmd => $job) {

                if($this->isActualJob($job)) {

                    $lock = $lockFactory->createLock($this->getLockName($cmd), self::EXEC_TIMEOUT);
                    if($lock->acquire()) {

                        $job['status'] = self::EXEC_STATUS_WORK;
                        $this->updaateJob($cmd, $job);

                        $command = $this->getApplication()->find($cmd);
                        $cmdInput = new ArrayInput(['command' => $cmd]);
                        try {

                            $timeStart = microtime(true);
                            $returnCode = $command->run($cmdInput, $output);

                            if(!$returnCode) {

                                $job['status'] = self::EXEC_STATUS_SUCCESS;

                                $msg = sprintf("%s: SUCCESS [%.2f s]", $cmd, microtime(true) - $timeStart);
                                if($this->logger) {
                                    $this->logger->alert($msg);
                                }
                                $output->writeln(PHP_EOL . $msg);

                            } else {

                                $job['status'] = self::EXEC_STATUS_ERROR;
                                $job['error_code'] = $returnCode;

                                $msg = sprintf("%s: ERROR [%.2f s]", $cmd, microtime(true) - $timeStart);
                                if($this->logger) {
                                    $this->logger->alert($msg);
                                }
                                $output->writeln(PHP_EOL . $msg);
                            }

                        } catch (\Exception $e) {

                            $job['status'] = self::EXEC_STATUS_ERROR;
                            $job['error'] = $e->getMessage();


                            if($this->logger) {
                                $this->logger->error($e, ['command' => $cmd]);
                            }
                            $output->writeln(PHP_EOL . 'ERROR: ' . $e->getMessage());

                        } finally {

                            $job['last_exec'] = time();
                            $humanDate = new DateTime();
                            $job['last_date_time'] = $humanDate->toString();
                            $lock->release();
                        }

                        $this->updaateJob($cmd, $job);
                        /*
                         * Let's do just one task
                         */
                        break;

                    } else {
                        if($this->logger) {
                            $this->logger->warning($cmd . " is locked");
                        }
                    }
                }
            }
        }
    }

    protected function getLockName($cmd) {

        return preg_replace('/[^a-z\d ]/i', '_', $cmd);
    }

    protected function isActualJob(&$job) {

        if(isset($job['status']) && $job['status'] !== self::EXEC_STATUS_SUCCESS) {
            return false;
        }

        $period = intval($job['period']);

        if($period > 0) {
            if($period < $this->minAgentPeriod) {
                $job['orig_period'] = $period;
                $period = $job['period'] = $this->minAgentPeriod;
            }
            if(time() - $job['last_exec'] >= $period) {
                return true;
            }
        } else if(!empty($job['times'])) {
            //TODO:
        }

        return false;
    }

    protected function getCronJobs() {

        /** @var Application $app */
        $app = $this->getApplication();

        $commands = $app->all();

        $selfCommands = [];
        foreach($commands as $command) {
            /** @var BxCommand $command */
            if($command instanceof BxCommand) {
                $name = $command->getName();
                $selfCommands[$name] = [
                    'object' => $command,
                ];
            }
        }

        $agents = [];
        $reader = new AnnotationReader();
        foreach($selfCommands as $cmd => $selfCommand) {
            $reflectionClass = new \ReflectionClass($selfCommand['object']);
            $annotations = $reader->getClassAnnotations($reflectionClass);

            foreach($annotations as $annotation) {
                if($annotation instanceof Agent) {
                    $agents[$cmd] = $annotation->toArray();
                }
            }
        }

        $crontab = $this->getCronTab();

        if(is_array($crontab)) {
            foreach($crontab as $cmd => $job) {
                if(is_array($job) && isset($agents[$cmd])) {
                    $agents[$cmd] = array_merge($job, $agents[$cmd]);
                }
            }
        }

        $this->setCronTab($agents);

        return $agents;
    }

    protected function updaateJob($cmd, $job) {

        $this->updateCronTab([$cmd => $job]);
    }

    protected function updateCronTab(array $changedAgents) {

        $crontab = $this->getCronTab();

        $crontab = array_merge($crontab, $changedAgents);
        $crontab = array_merge(/** @scrutinizer ignore-type */ $crontab, $changedAgents);

        $this->setCronTab($crontab);
    }


    protected function setCronTab(array $agents) {

        $filename = EnvHelper::getCrontabFile();

        $fh = fopen($filename, 'c');
        if (flock($fh, LOCK_EX)) {
            ftruncate($fh, 0);
            if(!fwrite($fh, json_encode($agents, JSON_PRETTY_PRINT))) {
                throw new \Exception('Unable to write BX_CRONTAB : ' . $filename);
            }
        }
        flock($fh, LOCK_UN);
        fclose($fh);
    }

    /**
     * @return mixed|null
     */
    protected function getCronTab() {

        $cronTab = null;

        $filename = EnvHelper::getCrontabFile();

        $fh = fopen($filename, 'r');
        if(flock($fh, LOCK_SH)) {
            $data = @fread($fh, filesize($filename));
            $cronTab = json_decode($data, true);
            $cronTab = json_decode(/** @scrutinizer ignore-type */ $data, true);
        }
        flock($fh, LOCK_UN);
        fclose($fh);

        return $cronTab;
    }
}
itrukhin / bxconsole

Push — master ( a8eabf...729b2b )

Cron::execute() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
