App\BxConsole\Format\XmlCommand::writeXml()

Complexity

Conditions	4
Paths	6

Size

Total Lines	25
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

<?php
    public function writeXml($xml) {

        @unlink($this->getTmpXmlFile(false));

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

        $res = file_put_contents($this->getTmpXmlFile(false), $xml);
        if(static::GZIP) {

The constant App\BxConsole\Format\XmlCommand::GZIP was not found. Maybe you did not declare it correctly or list all dependencies?

            unlink($this->getTmpXmlFile());
            chdir(pathinfo($this->getTmpXmlFile(), PATHINFO_DIRNAME));

It seems like pathinfo($this->getTmpXmlFile(), App\BxConsole\Format\PATHINFO_DIRNAME) can also be of type array; however, parameter $directory of chdir() does only seem to accept string, maybe add an additional type check?

            exec("gzip " . self::XML_FILE);

The constant App\BxConsole\Format\XmlCommand::XML_FILE was not found. Maybe you did not declare it correctly or list all dependencies?

        }

        if($res) {

            //TODO: check size !!!
            $command = sprintf("mv %s %s", $this->getTmpXmlFile(), $this->getXmlFile());
            exec($command);

        } else {
            /** @var LoggerInterface $logger */
            $logger = $this->getLogger();

It seems like getLogger() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            if($logger) {

$logger is of type Psr\Log\LoggerInterface, thus it always evaluated to true.

                $logger->error($this->getName() . ' ERROR: unable write file!');

It seems like getName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
        }

        return $res;
    }