Itkg\TranslationBundle\Writer\MessageCatalogueWriter

Complexity

Total Complexity

7

Size/Duplication

Total Lines	67
Duplicated Lines	14.93 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

90%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	write()	0	11	2
A	getDumper()	10	10	2
A	getTranslationPath()	0	8	2

<?php

namespace Itkg\TranslationBundle\Writer;

use Symfony\Component\DependencyInjection\ContainerAware;
use Symfony\Component\Translation\MessageCatalogue;
use Symfony\Component\Translation\Writer\TranslationWriter;

/**
 * Class MessageCatalogWriter
 */
class MessageCatalogueWriter extends ContainerAware

The class Symfony\Component\DependencyInjection\ContainerAware has been deprecated with message: since version 2.8, to be removed in 3.0. Use the ContainerAwareTrait instead.

{
    /**
     * @var TranslationWriter
     */
    private $translationWriter;

    /**
     * @param TranslationWriter $translationWriter
     */
    public function __construct(TranslationWriter $translationWriter)
    {
        $this->translationWriter = $translationWriter;
    }

    /**
     * @param array       $messageCatalogues
     * @param string      $format
     * @param null|string $path
     */
    public function write(array $messageCatalogues, $format, $path = null)
    {
        $this->translationWriter->addDumper($format, $this->getDumper($format));

        /** @var MessageCatalogue $messageCatalogue */
        foreach ($messageCatalogues as $messageCatalogue) {
            $this->translationWriter->writeTranslations($messageCatalogue, $format, array(
                'path' => $this->getTranslationPath($path))
            );
        }
    }
    /**
     * Returns Symfony requested format dumper
     *
     * @param string $format
     *
     * @return \Symfony\Component\Translation\Dumper\DumperInterface
     *
     * @throws \InvalidArgumentException
     */
    private function getDumper($format)

This method seems to be duplicated in your project.

    {
        $service = sprintf('translation.dumper.%s', $format);

        if (!$this->container->has($service)) {
            throw new \InvalidArgumentException(sprintf('Unable to find Symfony Translation dumper for format "%s"', $format));
        }

        return $this->container->get($service);
    }

    /**
     * Returns translation path
     *
     * @param string $outputPath
     *
     * @return string
     */
    private function getTranslationPath($outputPath = null)
    {
        if ($outputPath) {

The expression $outputPath of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            return $outputPath;
        }

        return $this->container->get('kernel')->getRootDir() . '/Resources/translations';
    }
}