Itkg\DelayEventBundle\EventDispatcher\DelayEventDispatcher

Complexity

Total Complexity

13

Size/Duplication

Total Lines	111
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	0	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	dispatch()	0	13	2
A	addListener()	0	4	1
A	addSubscriber()	0	4	1
A	removeListener()	0	4	1
A	removeSubscriber()	0	4	1
A	getListeners()	0	4	1
A	hasListeners()	0	4	1
A	__call()	0	4	1
A	isEventEligible()	0	4	3

<?php

namespace Itkg\DelayEventBundle\EventDispatcher;

use Itkg\DelayEventBundle\Event\DelayableEvent;
use Itkg\DelayEventBundle\Event\DelayableEvents;
use Symfony\Component\EventDispatcher\Event;
use Itkg\DelayEventBundle\Model\Event as DelayEvent;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;

/**
 * class DelayEventDispatcher 
 */
class DelayEventDispatcher implements EventDispatcherInterface
{
    /**
     * @var array
     */
    private $eligibleEventNames = array();

    /**
     * @var EventDispatcherInterface
     */
    private $dispatcher;

    /**
     * @param EventDispatcherInterface $dispatcher
     * @param array                    $eligibleEventNames
     */
    public function __construct(EventDispatcherInterface $dispatcher, array $eligibleEventNames)
    {
        $this->dispatcher = $dispatcher;
        $this->eligibleEventNames = $eligibleEventNames;
    }

    /**
     * {@inheritDoc}
     */
    public function dispatch($eventName, Event $event = null)
    {
        if ($this->isEventEligible($eventName, $event)) {

It seems like $event defined by parameter $event on line 40 can be null; however, Itkg\DelayEventBundle\EventDispatcher\DelayEventDispatcher::isEventEligible() does not accept null, maybe add an additional type check?

            $event->setOriginalName($eventName);

It seems like you code against a specific sub-type and not the parent class Symfony\Component\EventDispatcher\Event as the method setOriginalName() does only exist in the following sub-classes of Symfony\Component\EventDispatcher\Event: Itkg\DelayEventBundle\Document\Event, Itkg\DelayEventBundle\Model\Event. Maybe you want to instanceof check for one of these explicitly?

            // Override event name to dispatch an delayable event
            $event = new DelayableEvent($event);

$event is of type null|object<Symfony\Component\EventDispatcher\Event>, but the function expects a object<Itkg\DelayEventBundle\Model\Event>.

            $eventName = DelayableEvents::DELAY;
        }

        $this->dispatcher->dispatch($eventName, $event);

        return $event;
    }

    /**
     * {@inheritDoc}
     */
    public function addListener($eventName, $listener, $priority = 0)
    {
        $this->dispatcher->addListener($eventName, $listener, $priority);
    }

    /**
     * {@inheritDoc}
     */
    public function addSubscriber(EventSubscriberInterface $subscriber)
    {
        $this->dispatcher->addSubscriber($subscriber);
    }

    /**
     * {@inheritDoc}
     */
    public function removeListener($eventName, $listener)
    {
        $this->dispatcher->removeListener($eventName, $listener);
    }

    /**
     * {@inheritDoc}
     */
    public function removeSubscriber(EventSubscriberInterface $subscriber)
    {
        $this->dispatcher->removeSubscriber($subscriber);
    }

    /**
     * {@inheritDoc}
     */
    public function getListeners($eventName = null)
    {
        return $this->dispatcher->getListeners($eventName);
    }

    /**
     * {@inheritDoc}
     */
    public function hasListeners($eventName = null)
    {
        return $this->dispatcher->hasListeners($eventName);
    }

    /**
     * Proxies all method calls to the original event dispatcher.
     *
     * @param string $method    The method name
     * @param array  $arguments The method arguments
     *
     * @return mixed
     */
    public function __call($method, $arguments)
    {
        return call_user_func_array(array($this->dispatcher, $method), $arguments);
    }

    /**
     * @param String $eventName
     * @param Event $event
     *
     * @return bool
     */
    private function isEventEligible($eventName, $event)
    {
        return $event instanceof DelayEvent && $event->isDelayed() && in_array($eventName, $this->eligibleEventNames);
    }
}