Issues in GuardTrait.php (master) - Issues in master - italolelis/collections - Measure and Improve Code Quality continuously with Scrutinizer

Issues (142)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Traits/GuardTrait.php (4 issues)

Labels

Severity

Minor 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Collections\Traits;

use Collections\Exception\EmptyException;
use Collections\Exception\InvalidArgumentException;
use Collections\Exception\KeyException;
use Collections\Exception\TypeException;

trait GuardTrait
{
    abstract function isEmpty();


    abstract function count();


    /**
     * Ensures that we throw the correct exception when an empty collection is found
     * @param $method
     * @throws EmptyException
     */
    protected function emptyGuard($method)
    {
        if ($this->isEmpty()) {
            throw new EmptyException("{$method} cannot be called when the structure is empty");
        }
    }

    /**
     * Validates if a key is withing bounds (usually only useful with vectors)
     * @param $key
     */
    protected function validateKeyBounds($key)
    {
        if (!$this->isBoundedKey($key)) {
            throw new \OutOfBoundsException("Integer key $key is out of bounds");
        }
    }

    /**
     * @param $key
     */
    protected function validateKeyDoesNotExists($key)
    {
        if (!$this->containsKey($key)) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            throw new \OutOfBoundsException('No element at position ' . $key);
        }
    }

    /**
     * @param $key
     */
    protected function validateKeyExists($key)
    {
        if ($this->containsKey($key)) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            throw new KeyException('The key ' . $key . ' already exists!');
        }
    }

    /**
     * @param int $element
     * @return bool
     */
    protected function isBoundedKey($element)
    {
        return $element >= 0 && $element < $this->count();
    }

    /**
     * Validate if an element respects the correct type (usually only useful with vectors)
     * @param $element
     * @throws TypeException
     */
    protected function validateKeyType($element)
    {
        if (filter_var($element, FILTER_VALIDATE_INT) === false) {
            throw new TypeException('Only integer keys may be used with ' . (get_class($this)));
        }
    }

    protected function validateTraversable($traversable)
    {
        if (!is_array($traversable) && !$traversable instanceof \Traversable) {
            throw InvalidArgumentException::invalidTraversable();
        }
    }
}


1		<?php
2
3		namespace Collections\Traits;
4
5		use Collections\Exception\EmptyException;
6		use Collections\Exception\InvalidArgumentException;
7		use Collections\Exception\KeyException;
8		use Collections\Exception\TypeException;
9
10		trait GuardTrait
11		{
12		abstract function isEmpty();
		0 ignored issues – show Best Practice introduced 2015-11-22 16:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
13
14		abstract function count();
		0 ignored issues – show Best Practice introduced 2015-11-22 16:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
15
16		/**
17		* Ensures that we throw the correct exception when an empty collection is found
18		* @param $method
19		* @throws EmptyException
20		*/
21		protected function emptyGuard($method)
22		{
23		if ($this->isEmpty()) {
24		throw new EmptyException("{$method} cannot be called when the structure is empty");
25		}
26		}
27
28		/**
29		* Validates if a key is withing bounds (usually only useful with vectors)
30		* @param $key
31		*/
32	5	protected function validateKeyBounds($key)
33		{
34	5	if (!$this->isBoundedKey($key)) {
35	2	throw new \OutOfBoundsException("Integer key $key is out of bounds");
36		}
37	3	}
38
39		/**
40		* @param $key
41		*/
42		protected function validateKeyDoesNotExists($key)
43	5	{
44		if (!$this->containsKey($key)) {
		0 ignored issues – show Bug introduced 2016-06-24 22:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `containsKey()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
45	5	throw new \OutOfBoundsException('No element at position ' . $key);
46		}
47		}
48
49		/**
50		* @param $key
51		*/
52		protected function validateKeyExists($key)
53	22	{
54		if ($this->containsKey($key)) {
		0 ignored issues – show Bug introduced 2016-06-24 22:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `containsKey()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
55	22	throw new KeyException('The key ' . $key . ' already exists!');
56	4	}
57		}
58	19
59		/**
60		* @param int $element
61		* @return bool
62		*/
63		protected function isBoundedKey($element)
64		{
65		return $element >= 0 && $element < $this->count();
66		}
67
68		/**
69		* Validate if an element respects the correct type (usually only useful with vectors)
70		* @param $element
71		* @throws TypeException
72		*/
73		protected function validateKeyType($element)
74		{
75		if (filter_var($element, FILTER_VALIDATE_INT) === false) {
76		throw new TypeException('Only integer keys may be used with ' . (get_class($this)));
77		}
78		}
79
80		protected function validateTraversable($traversable)
81		{
82		if (!is_array($traversable) && !$traversable instanceof \Traversable) {
83		throw InvalidArgumentException::invalidTraversable();
84		}
85		}
86		}
87

italolelis / collections

Issues (142)

Security Analysis no request data

src/Traits/GuardTrait.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like