Collections\Traits\VectorLikeTrait

Complexity

Total Complexity

15

Size/Duplication

Total Lines	106
Duplicated Lines	12.26 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	offsetGet()	0	4	1
A	offsetSet()	0	8	2
A	offsetUnset()	0	4	1
A	set()	0	7	1
A	setAll()	13	13	3
A	add()	0	6	1
A	removeKey()	0	9	1
B	splice()	0	17	5

<?php

namespace Collections\Traits;

use Collections\Exception\InvalidOperationException;

trait VectorLikeTrait
{
    use ConstVectorLikeTrait,
        CommonMutableContainerTrait;

    /**
     * identical to at, implemented for ArrayAccess
     */
    public function offsetGet($offset)
    {
        return $this->at($offset);
    }

    public function offsetSet($offset, $value)
    {
        if (is_null($offset)) {
            $this->add($value);
        } else {
            $this->set($offset, $value);
        }
    }

    public function offsetUnset($offset)

The parameter $offset is not used and could be removed.

    {
        throw InvalidOperationException::unsupportedUnset($this);
    }

    /**
     * Stores a value into the Vector with the specified key, overwriting the
     * previous value associated with the key. If the key is not present,
     * an exception is thrown. "$vec->set($k,$v)" is semantically equivalent
     * to "$vec[$k] = $v" (except that set() returns the Vector).
     *
     * @param $key
     * @param $value
     * @return $this
     */
    public function set($key, $value)
    {
        $this->validateKeyType($key);
        $this->container[$key] = $value;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function setAll($items)

This method seems to be duplicated in your project.

    {
        $this->validateTraversable($items);

        foreach ($items as $key => $item) {
            if (is_array($item)) {
                $item = new static($item);

The call to VectorLikeTrait::__construct() has too many arguments starting with $item.

            }
            $this->set($key, $item);
        }

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function add($item)
    {
        $this->container[] = $item;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function removeKey($key)
    {
        $this->validateKeyType($key);
        $this->validateKeyBounds($key);

        array_splice($this->container, $key, 1);

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function splice($offset, $length = null)
    {
        if (!is_int($offset)) {
            throw new \InvalidArgumentException('Parameter offset must be an integer');
        }

        if (!is_null($length) && !is_int($length)) {
            throw new \InvalidArgumentException('Parameter len must be null or an integer');
        }

        $removed = is_null($length) ? array_splice($this->container, $offset) :

$removed is not used, you could remove the assignment.

            array_splice($this->container, $offset, $len);

The variable $len does not exist. Did you forget to declare it?

//        if (count($removed) > 0) {

54% of this comment could be valid code. Did you maybe forget this after debugging?

//            $this->hacklib_expireAllIterators();
//        }
    }
}