CommonMutableContainerTrait::indexBy() - Code Metrics - Inspection of "toValuesArray without keys" - italolelis/collections - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#11)

unknown

created 2016-05-01 21:33 UTC

CommonMutableContainerTrait::indexBy() A

↳ Parent: CommonMutableContainerTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	10
ccs	7
cts	7
cp	1
rs	9.4285
cc	2
eloc	6
nc	2
nop	1
crap	2

<?php

namespace Collections\Traits;

use Collections\ArrayList;
use Collections\Dictionary;
use Collections\Iterable;
use Collections\VectorInterface;

trait CommonMutableContainerTrait
{
    /**
     * {@inheritdoc}
     */
    public function values()
    {
        return new ArrayList($this);
    }

    /**
     * @return array
     */
    public function toValuesArray()
    {
        $arr = [];
        foreach ($this as $value) {

            if ($value instanceof Iterable) {
                $arr[] = $value->toArray();
            } else {
                $arr[] = $value;
            }
        }

        return $arr;
    }

    public function toKeysArray()
    {
        $res = [];
        foreach ($this as $k => $_) {

            $res[] = $k;
        }

        return $res;
    }

    /**
     * {@inheritdoc}
     */
    public function toArray()
    {
        $arr = [];
        foreach ($this as $key => $value) {

            if ($value instanceof Iterable) {
                $arr[$key] = $value->toArray();
            } else {
                $arr[$key] = $value;
            }
        }

        return $arr;
    }

    /**
     * {@inheritdoc}
     */
    public static function fromArray(array $arr)
    {
        $map = new static();
        foreach ($arr as $k => $v) {
            if (is_array($v)) {
                $map[$k] = new static($v);

            } else {
                $map[$k] = $v;
            }
        }

        return $map;
    }

    /**
     * {@inheritDoc}
     * @return $this
     */
    public function groupBy($callback)
    {
        $group = new Dictionary();
        foreach ($this as $value) {

            $key = $callback($value);
            if (!$group->containsKey($key)) {
                $element = $this instanceof VectorInterface ? new static([$value]) : new ArrayList([$value]);

                $group->add($key, $element);
            } else {
                $value = $group->get($key)->add($value);
                $group->set($key, $value);
            }
        }

        return $group;
    }

    /**
     * {@inheritDoc}
     * @return $this
     */
    public function indexBy($callback)
    {
        $group = new Dictionary();
        foreach ($this as $value) {

            $key = $callback($value);
            $group->set($key, $value);
        }

        return $group;
    }
}


1		<?php
2
3		namespace Collections\Traits;
4
5		use Collections\ArrayList;
6		use Collections\Dictionary;
7		use Collections\Iterable;
8		use Collections\VectorInterface;
9
10		trait CommonMutableContainerTrait
11		{
12		/**
13		* {@inheritdoc}
14		*/
15	1	public function values()
16		{
17	1	return new ArrayList($this);
18		}
19
20		/**
21		* @return array
22		*/
23	1	public function toValuesArray()
24		{
25		$arr = [];
26		foreach ($this as $value) {
		0 ignored issues – show Bug introduced 2016-05-01 21:35 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\...nMutableContainerTrait>` is not traversable. Loading history...
27		if ($value instanceof Iterable) {
28		$arr[] = $value->toArray();
29		} else {
30		$arr[] = $value;
31		}
32		}
33
34	1	return $arr;
35		}
36
37	3	public function toKeysArray()
38	3	{
39	1	$res = [];
40	1	foreach ($this as $k => $_) {
		0 ignored issues – show Bug introduced 2015-11-22 16:24 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\...nMutableContainerTrait>` is not traversable. Loading history...
41	1	$res[] = $k;
42	1	}
43
44	1	return $res;
45		}
46
47		/**
48		* {@inheritdoc}
49		*/
50	17	public function toArray()
51		{
52	17	$arr = [];
53	17	foreach ($this as $key => $value) {
		0 ignored issues – show Bug introduced 2015-11-22 16:24 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\...nMutableContainerTrait>` is not traversable. Loading history...
54	16	if ($value instanceof Iterable) {
55	6	$arr[$key] = $value->toArray();
56	6	} else {
57	16	$arr[$key] = $value;
58	1	}
59	17	}
60
61	17	return $arr;
62		}
63
64		/**
65		* {@inheritdoc}
66		*/
67	1	public static function fromArray(array $arr)
68		{
69	1	$map = new static();
70	1	foreach ($arr as $k => $v) {
71	1	if (is_array($v)) {
72	1	$map[$k] = new static($v);
		0 ignored issues – show Unused Code introduced 2015-11-22 16:24 UTC by Report Bug Copy Issue Report The call to `CommonMutableContainerTrait::__construct()` has too many arguments starting with `$v`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
73		} else {
74	1	$map[$k] = $v;
75		}
76	1	}
77
78	1	return $map;
79		}
80
81		/**
82		* {@inheritDoc}
83		* @return $this
84		*/
85	2	public function groupBy($callback)
86		{
87	2	$group = new Dictionary();
88	2	foreach ($this as $value) {
		0 ignored issues – show Bug introduced 2015-12-01 17:50 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\...nMutableContainerTrait>` is not traversable. Loading history...
89	2	$key = $callback($value);
90	2	if (!$group->containsKey($key)) {
91	2	$element = $this instanceof VectorInterface ? new static([$value]) : new ArrayList([$value]);
		0 ignored issues – show Unused Code introduced 2015-12-01 17:50 UTC by Report Bug Copy Issue Report The call to `CommonMutableContainerTrait::__construct()` has too many arguments starting with `array($value)`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
92	2	$group->add($key, $element);
93	2	} else {
94	2	$value = $group->get($key)->add($value);
95	2	$group->set($key, $value);
96		}
97	2	}
98
99	2	return $group;
100		}
101
102		/**
103		* {@inheritDoc}
104		* @return $this
105		*/
106	2	public function indexBy($callback)
107		{
108	2	$group = new Dictionary();
109	2	foreach ($this as $value) {
		0 ignored issues – show Bug introduced 2015-12-01 17:50 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\...nMutableContainerTrait>` is not traversable. Loading history...
110	2	$key = $callback($value);
111	2	$group->set($key, $value);
112	2	}
113
114	2	return $group;
115		}
116		}
117

italolelis / collections

Pull Request — master (#11)

CommonMutableContainerTrait::indexBy() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like