StrictIterableTrait::concatRecurse() - Code Metrics - Inspection of "Fixed problems with concat" - italolelis/collections - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 431209...0f7fe1 )

by Ítalo

created 2016-06-03 15:37 UTC

StrictIterableTrait::concatRecurse() B

↳ Parent: StrictIterableTrait

Complexity

Conditions	7
Paths	4

Size

Total Lines	20
Code Lines	11

Duplication

Lines	20
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	20
loc	20
ccs	0
cts	1
cp	0
rs	8.2222
cc	7
eloc	11
nc	4
nop	2
crap	56

<?php

namespace Collections\Traits;

use Collections\Iterable;
use Collections\VectorInterface;

trait StrictIterableTrait
{
    use CommonMutableContainerTrait;

    /**
     * {@inheritDoc}
     * @return $this
     */
    public function map(callable $callable)
    {
        $res = new static();
        foreach ($this as $v) {

            $res[] = $callable($v);
        }

        return $res;
    }

    /**
     * {@inheritDoc}
     * @return $this
     */
    public function mapWithKey($callback)

    {
        $res = new static();
        foreach ($this as $k => $v) {

            $res[$k] = $callback($k, $v);
        }

        return $res;
    }

    /**
     * {@inheritDoc}
     * @return $this
     */
    public function filter(callable $callable)

    {
        $res = new static();
        foreach ($this as $v) {

            if ($callable($v)) {
                $res[] = $v;
            }
        }

        return $res;
    }

    /**
     * {@inheritDoc}
     * @return $this
     */
    public function filterWithKey($callback)

    {
        $res = new static();
        foreach ($this as $k => $v) {

            if ($callback($k, $v)) {
                $res[$k] = $v;
            }
        }

        return $res;
    }

    /**
     * {@inheritDoc}
     * @return $this
     */
    public function zip(Iterable $iterable)

    {
        $res = new static();
        $it = $iterable->getIterator();
        foreach ($this as $v) {

            if (!$it->valid()) {
                break;
            }
            $res[] = new Pair($v, $it->current());
            $it->next();
        }

        return $res;
    }

    /**
     * {@inheritDoc}
     * @return $this
     */
    public function take($size = 1)
    {
        $res = new static();

        if ($size <= 0) {
            return $res;
        }

        foreach ($this as $v) {

            $res[] = $v;
            if (--$size === 0) {
                break;
            }
        }

        return $res;
    }

    public function takeWhile(callable $callable)

    {
        $res = new static();
        foreach ($this as $v) {

            if (!$callable($v)) {
                break;
            }
            $res[] = $v;
        }

        return $res;
    }

    public function skip($n)
    {
        $res = new static();
        foreach ($this as $v) {

            if ($n <= 0) {
                $res[] = $v;
            } else {
                --$n;
            }
        }

        return $res;
    }

    public function skipWhile(callable $callable)
    {
        $res = new static();
        $skip = true;
        foreach ($this as $v) {

            if ($skip) {
                if ($callable($v)) {
                    continue;
                }
                $skip = false;
            }
            $res[] = $v;
        }

        return $res;
    }

    public function slice($start, $length)

    {
        $res = new static();
        if ($length <= 0) {
            return $res;
        }
        foreach ($this as $v) {

            if ($start !== 0) {
                --$start;
                continue;
            }
            $res[] = $v;
            if (--$length === 0) {
                break;
            }
        }

        return $res;
    }

    /**
     * {@inheritDoc}
     * @return $this
     */
    public function first()
    {
        foreach ($this as $v) {

            return $v;
        }

        return null;
    }

    /**
     * {@inheritDoc}
     * @return $this
     */
    public function last()
    {
        $result = $this->toArray();

        return array_pop($result);
    }

    /**
     * {@inheritDoc}
     * @return $this
     */
    public function each(callable $callable)
    {
        foreach ($this as $v) {

            $callable($v);
        }

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function exists(callable $fn)
    {
        foreach ($this as $element) {

            if ($fn($element)) {
                return true;
            }
        }

        return false;
    }

    public function concatAll()

    {
        /** @var VectorInterface $results */
        $results = new static();
        $this->each(function (Iterable $subArray) use ($results) {
            $subArray->each(function ($item) use ($results) {
                $results->add($item);
            });
        });

        return $results;
    }

    /**
     * {@inheritdoc}
     */
    public function reduce(callable $callback, $initial = null)
    {
        foreach ($this as $element) {

            $initial = $callback($initial, $element);
        }

        return $initial;
    }

    private function concatRecurse($array, $array1)

    {
        $merged = $array;

        foreach ($array1 as $key => $value) {
            $isValid = function ($value) {
                return (is_array($value) || $value instanceof \Traversable);
            };

            if (($isValid($value) && isset($merged[$key])) && $isValid($merged[$key])) {
                $merged[$key] = $this->concatRecurse($merged[$key], $value);
            } else {
                if (!in_array($value, $merged->toArray())) {
                    $merged[] = $value;
                }
            }
        }

        return $merged;
    }
}


1			<?php
2
3			namespace Collections\Traits;
4
5			use Collections\Iterable;
6			use Collections\VectorInterface;
7
8			trait StrictIterableTrait
9			{
10			use CommonMutableContainerTrait;
11
12			/**
13			* {@inheritDoc}
14			* @return $this
15			*/
16	1		public function map(callable $callable)
17			{
18	1		$res = new static();
19	1		foreach ($this as $v) {
			0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictIterableTrait>` is not traversable. Loading history...
20	1		$res[] = $callable($v);
21	1		}
22
23	1		return $res;
24			}
25
26			/**
27			* {@inheritDoc}
28			* @return $this
29			*/
30		View Code Duplication	public function mapWithKey($callback)
			0 ignored issues – show Duplication introduced 2016-05-08 11:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31			{
32			$res = new static();
33			foreach ($this as $k => $v) {
			0 ignored issues – show Bug introduced 2016-02-26 13:40 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictIterableTrait>` is not traversable. Loading history...
34			$res[$k] = $callback($k, $v);
35			}
36
37			return $res;
38			}
39
40			/**
41			* {@inheritDoc}
42			* @return $this
43			*/
44	4	View Code Duplication	public function filter(callable $callable)
			0 ignored issues – show Duplication introduced 2016-05-08 11:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45			{
46	2		$res = new static();
47	2		foreach ($this as $v) {
			0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictIterableTrait>` is not traversable. Loading history...
48	2		if ($callable($v)) {
49	2		$res[] = $v;
50	2		}
51	2		}
52
53	4		return $res;
54			}
55
56			/**
57			* {@inheritDoc}
58			* @return $this
59			*/
60		View Code Duplication	public function filterWithKey($callback)
			0 ignored issues – show Duplication introduced 2016-05-08 11:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
61			{
62			$res = new static();
63			foreach ($this as $k => $v) {
			0 ignored issues – show Bug introduced 2016-02-26 13:40 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictIterableTrait>` is not traversable. Loading history...
64			if ($callback($k, $v)) {
65			$res[$k] = $v;
66			}
67			}
68
69			return $res;
70			}
71
72			/**
73			* {@inheritDoc}
74			* @return $this
75			*/
76		View Code Duplication	public function zip(Iterable $iterable)
			0 ignored issues – show Duplication introduced 2016-05-08 11:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
77			{
78			$res = new static();
79			$it = $iterable->getIterator();
80			foreach ($this as $v) {
			0 ignored issues – show Bug introduced 2015-11-22 18:48 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictIterableTrait>` is not traversable. Loading history...
81			if (!$it->valid()) {
82			break;
83			}
84			$res[] = new Pair($v, $it->current());
85			$it->next();
86			}
87
88			return $res;
89			}
90
91			/**
92			* {@inheritDoc}
93			* @return $this
94			*/
95	1		public function take($size = 1)
96			{
97	1		$res = new static();
98
99	1		if ($size <= 0) {
100			return $res;
101			}
102
103	1		foreach ($this as $v) {
			0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictIterableTrait>` is not traversable. Loading history...
104	1		$res[] = $v;
105	1		if (--$size === 0) {
106	1		break;
107			}
108	1		}
109
110	1		return $res;
111			}
112
113		View Code Duplication	public function takeWhile(callable $callable)
			0 ignored issues – show Duplication introduced 2016-05-08 11:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
114			{
115			$res = new static();
116			foreach ($this as $v) {
			0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictIterableTrait>` is not traversable. Loading history...
117			if (!$callable($v)) {
118			break;
119			}
120			$res[] = $v;
121			}
122
123			return $res;
124			}
125
126			public function skip($n)
127			{
128			$res = new static();
129			foreach ($this as $v) {
			0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictIterableTrait>` is not traversable. Loading history...
130			if ($n <= 0) {
131			$res[] = $v;
132			} else {
133			--$n;
134			}
135			}
136
137			return $res;
138			}
139
140			public function skipWhile(callable $callable)
141			{
142			$res = new static();
143			$skip = true;
144			foreach ($this as $v) {
			0 ignored issues – show Bug introduced 2015-11-22 16:24 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictIterableTrait>` is not traversable. Loading history...
145			if ($skip) {
146			if ($callable($v)) {
147			continue;
148			}
149			$skip = false;
150			}
151			$res[] = $v;
152			}
153
154			return $res;
155			}
156
157		View Code Duplication	public function slice($start, $length)
			0 ignored issues – show Duplication introduced 2016-05-08 11:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
158			{
159			$res = new static();
160			if ($length <= 0) {
161			return $res;
162			}
163			foreach ($this as $v) {
			0 ignored issues – show Bug introduced 2016-02-26 13:40 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictIterableTrait>` is not traversable. Loading history...
164			if ($start !== 0) {
165			--$start;
166			continue;
167			}
168			$res[] = $v;
169			if (--$length === 0) {
170			break;
171			}
172			}
173
174			return $res;
175			}
176
177	1		/**
178			* {@inheritDoc}
179	1		* @return $this
180			*/
181	1		public function first()
182	1		{
183	1		foreach ($this as $v) {
			0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictIterableTrait>` is not traversable. Loading history...
184			return $v;
185	1		}
186	1
187	1		return null;
188	1		}
189
190	1		/**
191			* {@inheritDoc}
192			* @return $this
193			*/
194			public function last()
195			{
196			$result = $this->toArray();
197	2
198			return array_pop($result);
199	2		}
200	1
201	1		/**
202			* {@inheritDoc}
203	1		* @return $this
204			*/
205			public function each(callable $callable)
206			{
207			foreach ($this as $v) {
			0 ignored issues – show Bug introduced 2015-12-01 17:34 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictIterableTrait>` is not traversable. Loading history...
208			$callable($v);
209			}
210	2
211			return $this;
212	2		}
213
214	2		/**
215			* {@inheritdoc}
216			*/
217			public function exists(callable $fn)
218			{
219			foreach ($this as $element) {
			0 ignored issues – show Bug introduced 2015-11-22 16:24 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictIterableTrait>` is not traversable. Loading history...
220			if ($fn($element)) {
221			return true;
222			}
223			}
224
225			return false;
226			}
227
228		View Code Duplication	public function concatAll()
			0 ignored issues – show Duplication introduced 2016-05-08 11:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
229			{
230			/** @var VectorInterface $results */
231			$results = new static();
232			$this->each(function (Iterable $subArray) use ($results) {
233	1		$subArray->each(function ($item) use ($results) {
234			$results->add($item);
235	1		});
236	1		});
237	1
238			return $results;
239	1		}
240
241	1		/**
242			* {@inheritdoc}
243			*/
244			public function reduce(callable $callback, $initial = null)
245			{
246			foreach ($this as $element) {
			0 ignored issues – show Bug introduced 2016-05-10 16:10 UTC by Report Bug Copy Issue Report The expression `$this` of type `this<Collections\Traits\StrictIterableTrait>` is not traversable. Loading history...
247			$initial = $callback($initial, $element);
248			}
249
250			return $initial;
251			}
252
253		View Code Duplication	private function concatRecurse($array, $array1)
			0 ignored issues – show Unused Code introduced 2016-06-03 15:40 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history... Duplication introduced 2016-06-03 15:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
254			{
255			$merged = $array;
256
257			foreach ($array1 as $key => $value) {
258			$isValid = function ($value) {
259			return (is_array($value) \|\| $value instanceof \Traversable);
260			};
261
262			if (($isValid($value) && isset($merged[$key])) && $isValid($merged[$key])) {
263			$merged[$key] = $this->concatRecurse($merged[$key], $value);
264			} else {
265			if (!in_array($value, $merged->toArray())) {
266			$merged[] = $value;
267			}
268			}
269			}
270
271			return $merged;
272			}
273			}
274

italolelis / collections

Push — master ( 431209...0f7fe1 )

StrictIterableTrait::concatRecurse() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like